TaskNameIsUniqueSpecificationSpec::let() - Code Metrics - Inspection of "no message" - MartinPham/todo-ddd - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 06fcec...ff7c45 )

by Martin

created 2017-02-04 17:21 UTC

TaskNameIsUniqueSpecificationSpec::let() A

↳ Parent: TaskNameIsUniqueSpecificationSpec

Complexity

Conditions	1
Paths	1

Size

Total Lines	16
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	16
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	12
nc	1
nop	1

<?php

namespace spec\Todo\Domain\Specification;

use Todo\Domain\Exception\TaskNotFoundException;
use Todo\Domain\Factory\TaskFactory;
use Todo\Domain\Repository\TaskRepositoryInterface;
use Todo\Domain\Specification\TaskNameIsUniqueSpecification;
use Todo\Domain\Task;
use PhpSpec\ObjectBehavior;
use Prophecy\Argument;

class TaskNameIsUniqueSpecificationSpec extends ObjectBehavior
{
    protected $taskRepository;

    protected $taskNameExists = 'Buying milk';
    protected $taskNameNonExists = 'Buying sugar';
    protected $task;

    function it_is_initializable()
    {
        $this->shouldHaveType(TaskNameIsUniqueSpecification::class);
    }

    function let(TaskRepositoryInterface $taskRepository)
    {
        $this->task = new Task;
        $this->task->setId(1);
        $this->task->setName($this->taskNameExists);

        $this->taskRepository = $taskRepository;
        $this->taskRepository

            ->findByName($this->taskNameExists)
            ->willReturn($this->task);
        $this->taskRepository

            ->findByName($this->taskNameNonExists)
            ->willThrow(TaskNotFoundException::class);

        $this->beConstructedWith($this->taskRepository);
    }

    function it_is_satisfied()
    {
        $this->isSatisfiedBy($this->taskNameExists)->shouldBe(false);
        $this->isSatisfiedBy($this->taskNameNonExists)->shouldBe(true);

        $this->isSatisfiedBy($this->taskNameExists, 1)->shouldBe(true);
    }
}


1			<?php
2
3			namespace spec\Todo\Domain\Specification;
4
5			use Todo\Domain\Exception\TaskNotFoundException;
6			use Todo\Domain\Factory\TaskFactory;
7			use Todo\Domain\Repository\TaskRepositoryInterface;
8			use Todo\Domain\Specification\TaskNameIsUniqueSpecification;
9			use Todo\Domain\Task;
10			use PhpSpec\ObjectBehavior;
11			use Prophecy\Argument;
12
13			class TaskNameIsUniqueSpecificationSpec extends ObjectBehavior
14			{
15			protected $taskRepository;
16
17			protected $taskNameExists = 'Buying milk';
18			protected $taskNameNonExists = 'Buying sugar';
19			protected $task;
20
21			function it_is_initializable()
22			{
23			$this->shouldHaveType(TaskNameIsUniqueSpecification::class);
24			}
25
26			function let(TaskRepositoryInterface $taskRepository)
27			{
28			$this->task = new Task;
29			$this->task->setId(1);
30			$this->task->setName($this->taskNameExists);
31
32			$this->taskRepository = $taskRepository;
33			$this->taskRepository
			0 ignored issues – show Bug introduced 2017-02-04 17:29 UTC by Report Bug Copy Issue Report The method `willReturn()` does not seem to exist on `object<Todo\Domain\Task>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
34			->findByName($this->taskNameExists)
35			->willReturn($this->task);
36			$this->taskRepository
			0 ignored issues – show Bug introduced 2017-02-04 17:29 UTC by Report Bug Copy Issue Report The method `willThrow()` does not seem to exist on `object<Todo\Domain\Task>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
37			->findByName($this->taskNameNonExists)
38			->willThrow(TaskNotFoundException::class);
39
40			$this->beConstructedWith($this->taskRepository);
41			}
42
43			function it_is_satisfied()
44			{
45			$this->isSatisfiedBy($this->taskNameExists)->shouldBe(false);
46			$this->isSatisfiedBy($this->taskNameNonExists)->shouldBe(true);
47
48			$this->isSatisfiedBy($this->taskNameExists, 1)->shouldBe(true);
49			}
50			}
51

MartinPham / todo-ddd

Push — master ( 06fcec...ff7c45 )

TaskNameIsUniqueSpecificationSpec::let() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like