Issues in TimeEntryService.php (master) - Issues in master - MarioBlazek/Toggable - Measure and Improve Code Quality continuously with Scrutinizer

Issues (47)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Service/TimeEntry/TimeEntryService.php (2 issues)

Labels

Duplication 2

Severity

Informational 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Marek\Toggable\Service\TimeEntry;

use Marek\Toggable\API\Http\Request\RequestInterface;
use Marek\Toggable\API\Http\Request\TimeEntry\BulkUpdateTimeEntriesTags;
use Marek\Toggable\API\Http\Request\TimeEntry\CreateTimeEntry;
use Marek\Toggable\API\Http\Request\TimeEntry\DeleteTimeEntry;
use Marek\Toggable\API\Http\Request\TimeEntry\GetRunningTimeEntry;
use Marek\Toggable\API\Http\Request\TimeEntry\GetTimeEntriesStartedInDateRange;
use Marek\Toggable\API\Http\Request\TimeEntry\GetTimeEntry;
use Marek\Toggable\API\Http\Request\TimeEntry\StartTimeEntry;
use Marek\Toggable\API\Http\Request\TimeEntry\StopTimeEntry;
use Marek\Toggable\API\Http\Request\TimeEntry\UpdateTimeEntry;
use Marek\Toggable\API\Http\Response\TimeEntry\TimeEntries;
use Marek\Toggable\API\Http\Response\TimeEntry\TimeEntry as TimeEntryResponse;
use Marek\Toggable\API\Toggl\Values\TimeEntry\TimeEntry;
use Marek\Toggable\Service\AbstractService;

/**
 * Class TimeEntryService
 * @package Marek\Toggable\Service\TimeEntry
 */
class TimeEntryService extends AbstractService implements \Marek\Toggable\API\Toggl\TimeEntryServiceInterface
{
    /**
     * @inheritDoc
     */
    public function createTimeEntry(\Marek\Toggable\API\Toggl\Values\TimeEntry\TimeEntry $timeEntry)
    {
        $request = new CreateTimeEntry(
            array(
                'data' => $this->extractDataFromObject($timeEntry),
            )
        );

      return $this->delegateHydrateAndReturnResponse($request);
    }

    /**
     * @inheritDoc
     */
    public function startTimeEntry(\Marek\Toggable\API\Toggl\Values\TimeEntry\TimeEntry $timeEntry)
    {
        $request = new StartTimeEntry(
            array(
                'data' => $this->extractDataFromObject($timeEntry),
            )
        );

        return $this->delegateHydrateAndReturnResponse($request);
    }

    /**
     * @inheritDoc
     */
    public function stopTimeEntry($timeEntryId)
    {
        $request = new StopTimeEntry(
            array(
                'timeEntryId' => $this->validate($timeEntryId),
            )
        );

        return $this->delegateHydrateAndReturnResponse($request);
    }

    /**
     * @inheritDoc
     */
    public function getTimeEntry($timeEntryId)
    {
        $request = new GetTimeEntry(
            array(
                'timeEntryId' => $this->validate($timeEntryId),
            )
        );

        return $this->delegateHydrateAndReturnResponse($request);
    }

    /**
     * @inheritDoc
     */
    public function getRunningTimeEntry()
    {
        $request = new GetRunningTimeEntry();

        return $this->delegateHydrateAndReturnResponse($request);
    }

    /**
     * @inheritDoc
     */
    public function updateTimeEntry($timeEntryId, \Marek\Toggable\API\Toggl\Values\TimeEntry\TimeEntry $timeEntry)
    {
        $request = new UpdateTimeEntry(
            array(
                'timeEntryId'   => $this->validate($timeEntryId),
                'data'          => $this->extractDataFromObject($timeEntry),
            )
        );

        return $this->delegateHydrateAndReturnResponse($request);
    }

    /**
     * @inheritDoc
     */
    public function deleteTimeEntry($timeEntryId)
    {
        $request = new DeleteTimeEntry(
            array(
                'timeEntryId'   => $this->validate($timeEntryId),
            )
        );

        return $this->delegate($request);
    }

    /**
     * @inheritDoc
     */
    public function getTimeEntriesStartedInDateRange(\DateTime $startDate, \DateTime $endDate)

    {
        $request = new GetTimeEntriesStartedInDateRange(
            array(
                'startDate' => $startDate,
                'endDate'   => $endDate,
            )
        );

        $response = $this->delegate($request);

        $entries = array();
        foreach ($response->body as $entry) {
            $entries[] = $this->hydrator->hydrate($entry, new TimeEntry());
        }

        return new TimeEntries(
            array(
                'timeEntries' => $entries,
            )
        );
    }

    /**
     * @inheritDoc
     */
    public function bulkUpdateTimeEntriesTags(array $timeEntries, array $tags, $tagAction = \Marek\Toggable\API\Toggl\Values\TagAction::ADD)

    {
        $data = array(
            'tags' => $tags,
            'tag_action' => $tagAction
        );

        $request = new BulkUpdateTimeEntriesTags(
            array(
                'timeEntryIds'   => $timeEntries,
                'data'           => $data,
            )
        );

        $response = $this->delegate($request);

        $entries = array();
        foreach ($response->body['data'] as $entry) {
            $entries[] = $this->hydrator->hydrate($entry, new TimeEntry());
        }

        return new TimeEntries(
            array(
                'timeEntries' => $entries,
            )
        );
    }

    /**
     * @inheritdoc
     */
    protected function delegateHydrateAndReturnResponse(RequestInterface $request)
    {
        $response = $this->delegate($request);

        return new TimeEntryResponse(
            array(
                'timeEntry' => $this->hydrateDataFromArrayToObject($response, new TimeEntry()),
            )
        );
    }
}


1		<?php
2
3		namespace Marek\Toggable\Service\TimeEntry;
4
5		use Marek\Toggable\API\Http\Request\RequestInterface;
6		use Marek\Toggable\API\Http\Request\TimeEntry\BulkUpdateTimeEntriesTags;
7		use Marek\Toggable\API\Http\Request\TimeEntry\CreateTimeEntry;
8		use Marek\Toggable\API\Http\Request\TimeEntry\DeleteTimeEntry;
9		use Marek\Toggable\API\Http\Request\TimeEntry\GetRunningTimeEntry;
10		use Marek\Toggable\API\Http\Request\TimeEntry\GetTimeEntriesStartedInDateRange;
11		use Marek\Toggable\API\Http\Request\TimeEntry\GetTimeEntry;
12		use Marek\Toggable\API\Http\Request\TimeEntry\StartTimeEntry;
13		use Marek\Toggable\API\Http\Request\TimeEntry\StopTimeEntry;
14		use Marek\Toggable\API\Http\Request\TimeEntry\UpdateTimeEntry;
15		use Marek\Toggable\API\Http\Response\TimeEntry\TimeEntries;
16		use Marek\Toggable\API\Http\Response\TimeEntry\TimeEntry as TimeEntryResponse;
17		use Marek\Toggable\API\Toggl\Values\TimeEntry\TimeEntry;
18		use Marek\Toggable\Service\AbstractService;
19
20		/**
21		* Class TimeEntryService
22		* @package Marek\Toggable\Service\TimeEntry
23		*/
24		class TimeEntryService extends AbstractService implements \Marek\Toggable\API\Toggl\TimeEntryServiceInterface
25		{
26		/**
27		* @inheritDoc
28		*/
29	1	public function createTimeEntry(\Marek\Toggable\API\Toggl\Values\TimeEntry\TimeEntry $timeEntry)
30		{
31	1	$request = new CreateTimeEntry(
32		array(
33	1	'data' => $this->extractDataFromObject($timeEntry),
34		)
35	1	);
36
37	1	return $this->delegateHydrateAndReturnResponse($request);
38		}
39
40		/**
41		* @inheritDoc
42		*/
43	1	public function startTimeEntry(\Marek\Toggable\API\Toggl\Values\TimeEntry\TimeEntry $timeEntry)
44		{
45	1	$request = new StartTimeEntry(
46		array(
47	1	'data' => $this->extractDataFromObject($timeEntry),
48		)
49	1	);
50
51	1	return $this->delegateHydrateAndReturnResponse($request);
52		}
53
54		/**
55		* @inheritDoc
56		*/
57	2	public function stopTimeEntry($timeEntryId)
58		{
59	2	$request = new StopTimeEntry(
60		array(
61	2	'timeEntryId' => $this->validate($timeEntryId),
62		)
63	1	);
64
65	1	return $this->delegateHydrateAndReturnResponse($request);
66		}
67
68		/**
69		* @inheritDoc
70		*/
71	2	public function getTimeEntry($timeEntryId)
72		{
73	2	$request = new GetTimeEntry(
74		array(
75	2	'timeEntryId' => $this->validate($timeEntryId),
76		)
77	1	);
78
79	1	return $this->delegateHydrateAndReturnResponse($request);
80		}
81
82		/**
83		* @inheritDoc
84		*/
85	1	public function getRunningTimeEntry()
86		{
87	1	$request = new GetRunningTimeEntry();
88
89	1	return $this->delegateHydrateAndReturnResponse($request);
90		}
91
92		/**
93		* @inheritDoc
94		*/
95	2	public function updateTimeEntry($timeEntryId, \Marek\Toggable\API\Toggl\Values\TimeEntry\TimeEntry $timeEntry)
96		{
97	2	$request = new UpdateTimeEntry(
98		array(
99	2	'timeEntryId' => $this->validate($timeEntryId),
100	1	'data' => $this->extractDataFromObject($timeEntry),
101		)
102	1	);
103
104	1	return $this->delegateHydrateAndReturnResponse($request);
105		}
106
107		/**
108		* @inheritDoc
109		*/
110	2	public function deleteTimeEntry($timeEntryId)
111		{
112	2	$request = new DeleteTimeEntry(
113		array(
114	2	'timeEntryId' => $this->validate($timeEntryId),
115		)
116	1	);
117
118	1	return $this->delegate($request);
119		}
120
121		/**
122		* @inheritDoc
123		*/
124	1	public function getTimeEntriesStartedInDateRange(\DateTime $startDate, \DateTime $endDate)
		0 ignored issues – show Duplication introduced 2016-04-26 11:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
125		{
126	1	$request = new GetTimeEntriesStartedInDateRange(
127		array(
128	1	'startDate' => $startDate,
129	1	'endDate' => $endDate,
130		)
131	1	);
132
133	1	$response = $this->delegate($request);
134
135	1	$entries = array();
136	1	foreach ($response->body as $entry) {
137	1	$entries[] = $this->hydrator->hydrate($entry, new TimeEntry());
138	1	}
139
140	1	return new TimeEntries(
141		array(
142	1	'timeEntries' => $entries,
143		)
144	1	);
145		}
146
147		/**
148		* @inheritDoc
149		*/
150	1	public function bulkUpdateTimeEntriesTags(array $timeEntries, array $tags, $tagAction = \Marek\Toggable\API\Toggl\Values\TagAction::ADD)
		0 ignored issues – show Duplication introduced 2016-04-26 11:52 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
151		{
152		$data = array(
153	1	'tags' => $tags,
154		'tag_action' => $tagAction
155	1	);
156
157	1	$request = new BulkUpdateTimeEntriesTags(
158		array(
159	1	'timeEntryIds' => $timeEntries,
160	1	'data' => $data,
161		)
162	1	);
163
164	1	$response = $this->delegate($request);
165
166	1	$entries = array();
167	1	foreach ($response->body['data'] as $entry) {
168	1	$entries[] = $this->hydrator->hydrate($entry, new TimeEntry());
169	1	}
170
171	1	return new TimeEntries(
172		array(
173	1	'timeEntries' => $entries,
174		)
175	1	);
176		}
177
178		/**
179		* @inheritdoc
180		*/
181	6	protected function delegateHydrateAndReturnResponse(RequestInterface $request)
182		{
183	6	$response = $this->delegate($request);
184
185	6	return new TimeEntryResponse(
186		array(
187	6	'timeEntry' => $this->hydrateDataFromArrayToObject($response, new TimeEntry()),
188		)
189	6	);
190		}
191		}
192

MarioBlazek / Toggable

Issues (47)

Security Analysis no request data

src/Service/TimeEntry/TimeEntryService.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like