Marek\OpenWeatherMap\Denormalizer\WeatherDenormalizer

Complexity

Total Complexity

8

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	denormalize()	0	8	2
A	denormalizeSingle()	0	22	3
A	denormalizeMultiple()	0	12	3

<?php

declare(strict_types=1);

namespace Marek\OpenWeatherMap\Denormalizer;

use Marek\OpenWeatherMap\API\Value\Response\APIResponse;
use Marek\OpenWeatherMap\API\Value\Response\Clouds;
use Marek\OpenWeatherMap\API\Value\Response\GeographicCoordinates;
use Marek\OpenWeatherMap\API\Value\Response\Main;
use Marek\OpenWeatherMap\API\Value\Response\Rain;
use Marek\OpenWeatherMap\API\Value\Response\Snow;
use Marek\OpenWeatherMap\API\Value\Response\Sys;
use Marek\OpenWeatherMap\API\Value\Response\Weather\AggregatedWeather;
use Marek\OpenWeatherMap\API\Value\Response\Weather\Weather;
use Marek\OpenWeatherMap\API\Value\Response\WeatherValue;
use Marek\OpenWeatherMap\API\Value\Response\Wind;

class WeatherDenormalizer extends AbstractDenormalizer
{
    public function denormalize(array $data, APIResponse $response): APIResponse
    {
        if ($response instanceof AggregatedWeather) {
            return $this->denormalizeMultiple($data, $response);
        }

        return $this->denormalizeSingle($data, $response);

$response of type object<Marek\OpenWeatherMap\API\Value\Response\APIResponse> is not a sub-type of object<Marek\OpenWeatherMap\API\Value\Response\Weather\Weather>. It seems like you assume a child class of the class Marek\OpenWeatherMap\API\Value\Response\APIResponse to be always present.

    }

    /**
     * @param $data
     * @param Weather $weather
     *
     * @return Weather
     */
    protected function denormalizeSingle(array $data, Weather $weather): Weather
    {
        $innerWeather = [];
        foreach ($data['weather'] as $w) {
            $innerWeather[] = $this->denormalizer->denormalize($w, WeatherValue::class);
        }

        $weather->id = $data['id'];
        $weather->name = $data['name'];
        $weather->visibility = empty($data['visibility']) ?? $data['visibility'];
        $weather->coord = $this->getValue('coord', $data, GeographicCoordinates::class);
        $weather->rain = $this->getValue('rain', $data, Rain::class);
        $weather->snow = $this->getValue('snow', $data, Snow::class);
        $weather->wind = $this->getValue('wind', $data, Wind::class);
        $weather->clouds = $this->getValue('clouds', $data, Clouds::class);
        $weather->main = $this->getValue('main', $data, Main::class);
        $weather->sys = $this->getValue('sys', $data, Sys::class);
        $weather->weather = $innerWeather;
        $weather->dt = empty($data['dt']) ? null : new \DateTimeImmutable("@{$data['dt']}");

It seems like empty($data['dt']) ? null : new \DateTimeImmutable("@{$data['dt']}") of type object<DateTimeImmutable> is incompatible with the declared type object<DateTime> of property $dt.

        return $weather;
    }

    /**
     * @param array $data
     * @param AggregatedWeather $weather
     *
     * @return AggregatedWeather
     */
    protected function denormalizeMultiple($data, AggregatedWeather $weather): AggregatedWeather
    {
        $weathers = [];
        foreach ($data['list'] as $datum) {
            $weathers[] = $this->denormalizeSingle($datum, new Weather());
        }

        $weather->count = empty($data['cnt']) ? $data['count'] : $data['cnt'];
        $weather->weathers = $weathers;

        return $weather;
    }
}