StringValue - Code Metrics - Inspection of "Compiler value" - MarcusSchwarz/lesserphp - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#5)

unknown

created 2017-03-09 19:43 UTC

StringValue A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	4
lcom	1
cbo	2
dl	0
loc	36
ccs	10
cts	10
cp	1
rs	10
c	0
b	0
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getCompiled()	0	11	3
A	initializeFromOldFormat()	0	5	1

<?php
namespace LesserPhp\Compiler\Value;

/**
 * lesserphp
 * https://www.maswaba.de/lesserphp
 *
 * LESS CSS compiler, adapted from http://lesscss.org
 *
 * Copyright 2013, Leaf Corcoran <[email protected]>
 * Copyright 2016, Marcus Schwarz <[email protected]>
 * Copyright 2017, Stefan Pöhner <[email protected]>
 * Licensed under MIT or GPLv3, see LICENSE
 *
 * @package LesserPhp
 */

class StringValue extends AbstractValue
{
    /**
     * @var string
     */
    private $delimiter;

    /**
     * @var array|string
     */
    private $content;

    /**
     * @inheritdoc
     */
    public function getCompiled()
    {
        $content = $this->content;
        foreach ($content as &$part) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            if (is_array($part)) {
                $part = $this->compiler->compileValue($part);
            }
        }

        return $this->delimiter . implode($content) . $this->delimiter;
    }

    /**
     * @inheritdoc
     */
    public function initializeFromOldFormat(array $value)
    {
        $this->delimiter = $value[1];
        $this->content   = $value[2];
    }
}


1		<?php
2		namespace LesserPhp\Compiler\Value;
3
4		/**
5		* lesserphp
6		* https://www.maswaba.de/lesserphp
7		*
8		* LESS CSS compiler, adapted from http://lesscss.org
9		*
10		* Copyright 2013, Leaf Corcoran <[email protected]>
11		* Copyright 2016, Marcus Schwarz <[email protected]>
12		* Copyright 2017, Stefan Pöhner <[email protected]>
13		* Licensed under MIT or GPLv3, see LICENSE
14		*
15		* @package LesserPhp
16		*/
17
18		class StringValue extends AbstractValue
19		{
20		/**
21		* @var string
22		*/
23		private $delimiter;
24
25		/**
26		* @var array\|string
27		*/
28		private $content;
29
30		/**
31		* @inheritdoc
32		*/
33	27	public function getCompiled()
34		{
35	27	$content = $this->content;
36	27	foreach ($content as &$part) {
		0 ignored issues – show Bug introduced 2017-03-09 19:46 UTC by Report Bug Copy Issue Report The expression `$content` of type `array\|string` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
37	27	if (is_array($part)) {
38	27	$part = $this->compiler->compileValue($part);
39		}
40		}
41
42	27	return $this->delimiter . implode($content) . $this->delimiter;
43		}
44
45		/**
46		* @inheritdoc
47		*/
48	27	public function initializeFromOldFormat(array $value)
49		{
50	27	$this->delimiter = $value[1];
51	27	$this->content = $value[2];
52	27	}
53		}
54

MarcusSchwarz / lesserphp

Pull Request — master (#5)

StringValue A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

2 Methods

Duplication Side-by-Side

Filter issues like