Hex::__invoke() - Code Metrics - Inspection of "finished refactoring test and updated docs" - MarcusFulbright/Validate - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b6d955...929034 )

by Marcus

created 2018-07-09 22:33 UTC

Hex::__invoke() A

↳ Parent: Hex

Complexity

Conditions	5
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	8
CRAP Score	5.5069

Importance

Changes

Metric	Value
dl	0
loc	21
ccs	8
cts	11
cp	0.7272
rs	9.2728
c	0
b	0
f	0
cc	5
nc	4
nop	2
crap	5.5069

<?php

namespace Mbright\Validation\Rule\Sanitize;

class Hex
{
    /** @var int|null */
    protected $max;

    /**
     * @param int|null $max
     */
    public function __construct(int $max = null)
    {
        $this->max = $max;
    }

    /**
     * @param $subject
     * @param $field
     *
     * @return bool
     */
    public function __invoke($subject, string $field): bool
    {
        $value = $subject->$field;

        if (!is_scalar($value)) {
            return false;
        }

        $value = preg_replace('/[^0-9a-f]/i', '', $value);
        if ($value === '') {
            return false;
        }

        if ($this->max && strlen($value) > $this->max) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            $value = substr($value, 0, $this->max);
        }

        $subject->$field = $value;

        return true;
    }
}


1		<?php
2
3		namespace Mbright\Validation\Rule\Sanitize;
4
5		class Hex
6		{
7		/** @var int\|null */
8		protected $max;
9
10		/**
11		* @param int\|null $max
12		*/
13	3	public function __construct(int $max = null)
14		{
15	3	$this->max = $max;
16	3	}
17
18		/**
19		* @param $subject
20		* @param $field
21		*
22		* @return bool
23		*/
24	3	public function __invoke($subject, string $field): bool
25		{
26	3	$value = $subject->$field;
27
28	3	if (!is_scalar($value)) {
29		return false;
30		}
31
32	3	$value = preg_replace('/[^0-9a-f]/i', '', $value);
33	3	if ($value === '') {
34		return false;
35		}
36
37	3	if ($this->max && strlen($value) > $this->max) {
		0 ignored issues – show Bug Best Practice introduced 2018-07-09 22:35 UTC by Report Bug Copy Issue Report The expression `$this->max` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be zero. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
38		$value = substr($value, 0, $this->max);
39		}
40
41	3	$subject->$field = $value;
42
43	3	return true;
44		}
45		}
46

MarcusFulbright / Validate

Push — master ( b6d955...929034 )

Hex::__invoke() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like