Field::__construct() - Code Metrics - Inspection of "finished refactoring test and updated docs" - MarcusFulbright/Validate - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b6d955...929034 )

by Marcus

created 2018-07-09 22:33 UTC

Field::__construct() A

↳ Parent: Field

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	4
Ratio	100 %

Code Coverage

Tests	3
CRAP Score	1

Importance

Changes

Metric	Value
dl	4
loc	4
ccs	3
cts	3
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	1

<?php

namespace Mbright\Validation\Rule\Sanitize;

class Field implements SanitizeRuleInterface

{
    /** @var string */
    protected $otherField;

    /**
     * @param string $other_field The name of the other subject field.
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     */
    public function __construct(string $otherField)
    {
        $this->otherField = $otherField;
    }

    /**
     * Modifies the field value to match that of another field.
     *
     * @param object $subject The subject to be filtered.
     * @param string $field The subject field name.
     *
     * @return bool True if the value was sanitized, false if not.
     */
    public function __invoke($subject, string $field): bool
    {
        // the other field needs to exist and *not* be null
        if (! isset($subject->{$this->otherField})) {
            return false;
        }
        $subject->$field = $subject->{$this->otherField};

        return true;
    }
}


1			<?php
2
3			namespace Mbright\Validation\Rule\Sanitize;
4
5		View Code Duplication	class Field implements SanitizeRuleInterface
			0 ignored issues – show Duplication introduced 2018-07-09 22:35 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
6			{
7			/** @var string */
8			protected $otherField;
9
10			/**
11			* @param string $other_field The name of the other subject field.
			0 ignored issues – show Bug introduced 2018-07-09 22:35 UTC by Report Bug Copy Issue Report There is no parameter named `$other_field`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
12			*/
13	18		public function __construct(string $otherField)
14			{
15	18		$this->otherField = $otherField;
16	18		}
17
18			/**
19			* Modifies the field value to match that of another field.
20			*
21			* @param object $subject The subject to be filtered.
22			* @param string $field The subject field name.
23			*
24			* @return bool True if the value was sanitized, false if not.
25			*/
26	18		public function __invoke($subject, string $field): bool
27			{
28			// the other field needs to exist and not be null
29	18		if (! isset($subject->{$this->otherField})) {
30	3		return false;
31			}
32	15		$subject->$field = $subject->{$this->otherField};
33
34	15		return true;
35			}
36			}
37

MarcusFulbright / Validate

Push — master ( b6d955...929034 )

Field::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like