Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 5 | View Code Duplication | class StrictEqualToField implements ValidateRuleInterface |
|
|
|
|||
| 6 | { |
||
| 7 | /** @var string */ |
||
| 8 | protected $otherField; |
||
| 9 | |||
| 10 | /** |
||
| 11 | * @param string $otherField Check against the value of this element in $subject. |
||
| 12 | */ |
||
| 13 | 15 | public function __construct(string $otherField) |
|
| 17 | |||
| 18 | /** |
||
| 19 | * Validates that this value is strictly equal to some other subject field. |
||
| 20 | * |
||
| 21 | * If the other element does not exist in $subject, or is null, the validation will fail. |
||
| 22 | * |
||
| 23 | * @param object $subject The subject to be filtered. |
||
| 24 | * @param string $field The subject field name. |
||
| 25 | * |
||
| 26 | * @return bool True if the values are equal, false if not equal. |
||
| 27 | */ |
||
| 28 | 15 | public function __invoke($subject, string $field): bool |
|
| 37 | } |
||
| 38 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.