MarcinOrlowski\ResponseBuilder\Converter::convertArray()

Complexity

Conditions	15
Paths	24

Size

Total Lines	60
Code Lines	33

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
	protected function convertArray(array $data = null): ?array
	{
		if ($data === null) {
			return null;
		}

		if (!is_array($data) && !is_object($data)) {

The condition is_array($data) is always true.

			throw new \InvalidArgumentException(
				sprintf('Invalid payload data. Must be null, array or class with mapping ("%s" given).', gettype($data)));
		}

		if (is_object($data)) {

The condition is_object($data) is always false.

			$cfg = $this->getClassMappingConfigOrThrow($data);

			return [$cfg[ ResponseBuilder::KEY_KEY ] => $data->{$cfg[ ResponseBuilder::KEY_METHOD ]}()];
		}

		// This is to ensure that we either have array with user provided keys i.e. ['foo'=>'bar'], which will then
		// be turned into JSON object or array without user specified keys (['bar']) which we would return as JSON
		// array. But you can't mix these two as the final JSON would not produce predictable results.
		$user_keys_cnt = 0;
		$builtin_keys_cnt = 0;
		foreach ($data as $key => $val) {
			if (is_int($key)) {
				$builtin_keys_cnt++;
			} elseif (is_string($key)) {
				$user_keys_cnt++;
			} else {
				throw new \RuntimeException('Invalid data array. Array keys must either use strings as keys, or not use user provide keys.');
			}

			if (($user_keys_cnt > 0) && ($builtin_keys_cnt > 0)) {
				throw new \RuntimeException(
					'Invalid data array. Either set own keys for all the items or do not specify any keys at all. ' .
					'Arrays with mixed keys are not supported by design.');
			}
		}

		foreach ($data as $key => $val) {
			if (is_array($val)) {
				foreach ($val as $val_key => $val_val) {
//					if (is_object($val_val) && (!is_string($val_key))) {
//						throw new \InvalidArgumentException(
//							sprintf('Invalid payload data. Must be null, array or object ("%s" given).', gettype($data)));
//					}
				}
				$data[ $key ] = $this->convertArray($val);
			} elseif (is_object($val)) {
				$cls = get_class($val);
				$cfg = $this->getClassMappingConfigOrThrow($val);

The assignment to $cfg is dead and can be removed.

				if (array_key_exists($cls, $this->classes)) {

It seems like $this->classes can also be of type null; however, parameter $search of array_key_exists() does only seem to accept array, maybe add an additional type check?

					$conversion_method = $this->classes[ $cls ][ ResponseBuilder::KEY_METHOD ];
					$converted_data = $val->$conversion_method();
//							$data = [$this->classes[ $cls ][ ResponseBuilder::KEY_KEY ] => $converted_data];
					$data[ $key ] = $converted_data;
				}
			}
		}

		return $data;
	}