FieldHandleUpload::beforeValidation() - Code Metrics - Inspection of "FileUploadField, tests and doc" - MarceauKa/laravel-crudable - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( ca95e4...2437e1 )

by Marceau

created 2016-11-12 18:42 UTC

FieldHandleUpload::beforeValidation() B

↳ Parent: FieldHandleUpload

Complexity

Conditions	5
Paths	8

Size

Total Lines	25
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	5
eloc	11
nc	8
nop	1
dl	0
loc	25
rs	8.439
c	0
b	0
f	0

<?php

namespace Akibatech\Crud\Traits;

use Illuminate\Http\UploadedFile;
use Illuminate\Validation\Validator;

/**
 * Class FieldHandleUpload
 *
 * @package Akibatech\Crud\Traits
 */
trait FieldHandleUpload
{
    /**
     * @var string
     */
    protected $disk = 'public';

    /**
     * @var string
     */
    protected $path = 'uploads';

    /**
     * @var string
     */
    protected $mimes;

    /**
     * @var int
     */
    protected $max_size;

    /**
     * @param   string $disk
     * @return  self
     */
    public function uploadToDisk($disk = 'public')
    {
        $this->disk = $disk;

        return $this;
    }

    /**
     * @param   string $path
     * @return  self
     */
    public function uploadToPath($path = 'uploads')
    {
        $this->path = $path;

        return $this;
    }

    /**
     * @param   string $types
     * @return  self
     */
    public function withTypes($types)
    {
        $this->mimes = $types;

        return $this;
    }

    /**
     * @param   int $size
     * @return  self
     */
    public function withMaxSize($size = 2048)
    {
        $this->max_size = $size;

        return $this;
    }

    /**
     * @param   Validator $validator
     * @return  Validator
     */
    public function beforeValidation(Validator $validator)
    {
        $rules = [];
        $identifier = $this->getIdentifier();
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        if ($this->mimes)
        {
            $rules[] = 'mimes:' . $this->mimes;
        }

        if ($this->max_size)
        {
            $rules[] = 'max:' . $this->max_size;
        }

        if (count($rules) > 0)
        {
            $validator->sometimes($this->getIdentifier(), $rules, function ($input) use ($identifier)
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
            {
                return is_null($input->{$identifier}) ? false : true;
            });
        }

        return $validator;
    }
}


1			<?php
2
3			namespace Akibatech\Crud\Traits;
4
5			use Illuminate\Http\UploadedFile;
6			use Illuminate\Validation\Validator;
7
8			/**
9			* Class FieldHandleUpload
10			*
11			* @package Akibatech\Crud\Traits
12			*/
13			trait FieldHandleUpload
14			{
15			/**
16			* @var string
17			*/
18			protected $disk = 'public';
19
20			/**
21			* @var string
22			*/
23			protected $path = 'uploads';
24
25			/**
26			* @var string
27			*/
28			protected $mimes;
29
30			/**
31			* @var int
32			*/
33			protected $max_size;
34
35			/**
36			* @param string $disk
37			* @return self
38			*/
39			public function uploadToDisk($disk = 'public')
40			{
41			$this->disk = $disk;
42
43			return $this;
44			}
45
46			/**
47			* @param string $path
48			* @return self
49			*/
50			public function uploadToPath($path = 'uploads')
51			{
52			$this->path = $path;
53
54			return $this;
55			}
56
57			/**
58			* @param string $types
59			* @return self
60			*/
61			public function withTypes($types)
62			{
63			$this->mimes = $types;
64
65			return $this;
66			}
67
68			/**
69			* @param int $size
70			* @return self
71			*/
72			public function withMaxSize($size = 2048)
73			{
74			$this->max_size = $size;
75
76			return $this;
77			}
78
79			/**
80			* @param Validator $validator
81			* @return Validator
82			*/
83			public function beforeValidation(Validator $validator)
84			{
85			$rules = [];
86			$identifier = $this->getIdentifier();
			0 ignored issues – show Bug introduced 2016-11-12 18:48 UTC by Report Bug Copy Issue Report It seems like `getIdentifier()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
87
88			if ($this->mimes)
89			{
90			$rules[] = 'mimes:' . $this->mimes;
91			}
92
93			if ($this->max_size)
94			{
95			$rules[] = 'max:' . $this->max_size;
96			}
97
98			if (count($rules) > 0)
99			{
100			$validator->sometimes($this->getIdentifier(), $rules, function ($input) use ($identifier)
			0 ignored issues – show Bug introduced 2016-11-12 18:48 UTC by Report Bug Copy Issue Report It seems like `getIdentifier()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
101			{
102			return is_null($input->{$identifier}) ? false : true;
103			});
104			}
105
106			return $validator;
107			}
108			}
109

MarceauKa / laravel-crudable

GitHub Access Token became invalid

Push — master ( ca95e4...2437e1 )

FieldHandleUpload::beforeValidation() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like