FieldWithOptions - Code Metrics - Inspection of "Fields" - MarceauKa/laravel-crudable - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4e0f46...61af64 )

by Marceau

created 2016-11-06 18:38 UTC

FieldWithOptions A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	65
rs	10
c	1
b	0
f	0
wmc	7
lcom	1
cbo	0

6 Methods

Rating	Name	Size	Complexity
A	withOptions()	8	1
A	hasOption()	4	1
A	getOptions()	4	1
A	getOptionsKeys()	4	1
A	getOption()	4	2
A	getTableValue()	4	1

<?php

namespace Akibatech\Crud\Traits;

/**
 * Class FieldWithOptions
 *
 * @package Akibatech\Crud\Traits
 */
trait FieldWithOptions
{
    /**
     * @var array
     */
    protected $options;

    /**
     * @param   array $options
     * @return  self
     */
    public function withOptions($options = [])
    {
        $this->options = $options;

        $this->addRule('in:' . implode(',', array_keys($this->getOptionsKeys())));
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}

        return $this;
    }

    /**
     * @param   mixed $identifier
     * @return  bool
     */
    public function hasOption($identifier)
    {
        return array_key_exists($identifier, $this->getOptions());
    }

    /**
     * @param   void
     * @return  array
     */
    public function getOptions()
    {
        return $this->options;
    }

    /**
     * @param   void
     * @return  array
     */
    public function getOptionsKeys()
    {
        return array_keys($this->options);
    }

    /**
     * @param   void
     * @return  string|null
     */
    public function getOption($identifier)
    {
        return $this->hasOption($identifier) ? $this->options[$identifier] : null;
    }

    /**
     * @param   void
     * @return  string|null
     */
    public function getTableValue()
    {
        return $this->getOption($this->getValue());
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }
}


1			<?php
2
3			namespace Akibatech\Crud\Traits;
4
5			/**
6			* Class FieldWithOptions
7			*
8			* @package Akibatech\Crud\Traits
9			*/
10			trait FieldWithOptions
11			{
12			/**
13			* @var array
14			*/
15			protected $options;
16
17			/**
18			* @param array $options
19			* @return self
20			*/
21			public function withOptions($options = [])
22			{
23			$this->options = $options;
24
25			$this->addRule('in:' . implode(',', array_keys($this->getOptionsKeys())));
			0 ignored issues – show Bug introduced 2016-11-06 18:42 UTC by Report Bug Copy Issue Report It seems like `addRule()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
26
27			return $this;
28			}
29
30			/**
31			* @param mixed $identifier
32			* @return bool
33			*/
34			public function hasOption($identifier)
35			{
36			return array_key_exists($identifier, $this->getOptions());
37			}
38
39			/**
40			* @param void
41			* @return array
42			*/
43			public function getOptions()
44			{
45			return $this->options;
46			}
47
48			/**
49			* @param void
50			* @return array
51			*/
52			public function getOptionsKeys()
53			{
54			return array_keys($this->options);
55			}
56
57			/**
58			* @param void
59			* @return string\|null
60			*/
61			public function getOption($identifier)
62			{
63			return $this->hasOption($identifier) ? $this->options[$identifier] : null;
64			}
65
66			/**
67			* @param void
68			* @return string\|null
69			*/
70			public function getTableValue()
71			{
72			return $this->getOption($this->getValue());
			0 ignored issues – show Bug introduced 2016-11-06 18:42 UTC by Report Bug Copy Issue Report It seems like `getValue()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
73			}
74			}
75

MarceauKa / laravel-crudable

GitHub Access Token became invalid

Push — master ( 4e0f46...61af64 )

FieldWithOptions A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

6 Methods

Duplication Side-by-Side

Filter issues like