Malezha\Menu\Tests\CompareUrlTest

Complexity

Total Complexity

6

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	3
Bugs	1	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	makeComparativeUrl()	0	8	1
A	testEquals()	0	15	2
A	testSkipped()	0	7	2
A	testPaths()	0	8	1

<?php
namespace Malezha\Menu\Tests;

use Illuminate\Routing\UrlGenerator;
use Malezha\Menu\Support\ComparativeUrl;

class CompareUrlTest extends TestCase
{
    protected function makeComparativeUrl($currentUrl)
    {
        $mock = $this->createMock(UrlGenerator::class);
        $mock->method('current')->willReturn(url($currentUrl));
        $mock->method('to')->willReturnCallback('url');

        return new ComparativeUrl($mock, config('menu.skippedPaths'));
    }
    
    public function testSkipped()
    {
        $compare = $this->makeComparativeUrl(url('/'));
        foreach (config('menu.skippedPaths') as $value) {
            $this->assertFalse($compare->isEquals($value));
        }
    }

    public function testEquals()
    {
        $stub = [
            'http://username:password@hostname/path?arg=value#anchor',
            '//www.example.com/path?googleguy=googley',
            'http://usr:pss@example.com:81/mypath/myfile.html?a=b&b[]=2&b[]=3#myfragment',
            url('/'),
            '/',
        ];
        
        foreach ($stub as $value) {
            $compare = $this->makeComparativeUrl($value);
            $this->assertTrue($compare->isEquals($value));

It seems like $value defined by $value on line 36 can also be of type object<Illuminate\Contracts\Routing\UrlGenerator>; however, Malezha\Menu\Support\ComparativeUrl::isEquals() does only seem to accept string, maybe add an additional type check?

        }
    }

    public function testPaths()
    {
        $index = $this->makeComparativeUrl(url('/'));
        $this->assertFalse($index->isEquals(url('profile')));

It seems like url('profile') targeting url() can also be of type object<Illuminate\Contracts\Routing\UrlGenerator>; however, Malezha\Menu\Support\ComparativeUrl::isEquals() does only seem to accept string, maybe add an additional type check?

        $profile = $this->makeComparativeUrl(url('profile'));
        $this->assertFalse($profile->isEquals(url('/')));
    }
}