Malezha\Menu\Entity\Item

Complexity

Total Complexity

7

Size/Duplication

Total Lines	90
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Test Coverage

Coverage

100%

Importance

Changes	3
Bugs	1	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	getLink()	0	4	1
A	__construct()	0	8	1
A	buildAttributes()	0	8	2
A	isActive()	0	7	1
A	isUrlEqual()	0	15	2

<?php
namespace Malezha\Menu\Entity;

use Illuminate\Http\Request;
use Malezha\Menu\Contracts\Attributes as AttributesContract;
use Malezha\Menu\Contracts\Builder as BuilderContract;
use Malezha\Menu\Contracts\Link as LinkContract;
use Malezha\Menu\Contracts\Item as ItemContract;
use Malezha\Menu\Traits\DisplayRule;
use Malezha\Menu\Traits\HasAttributes;
use Malezha\Menu\Support\MergeAttributes;

/**
 * Class Item
 * @package Malezha\Menu\Entity
 */
class Item implements ItemContract
{
    use HasAttributes, DisplayRule;

    /**
     * @var LinkContract
     */
    protected $link;

    /**
     * @var BuilderContract
     */
    protected $builder;

    /**
     * @var Request
     */
    protected $request;

    /**
     * Item constructor.
     * @param BuilderContract $builder
     * @param AttributesContract $attributes
     * @param LinkContract $link
     * @param Request $request
     */
    public function __construct(BuilderContract $builder, AttributesContract $attributes, 
                                LinkContract $link, Request $request)

You have injected the Request via parameter $request. This is generally not recommended as there might be multiple instances during a request cycle (f.e. when using sub-requests). Instead, it is recommended to inject the RequestStack and retrieve the current request each time you need it via getCurrentRequest().

    {
        $this->builder = $builder;
        $this->attributes = $attributes;
        $this->link = $link;
        $this->request = $request;
    }

    /**
     * @return Link
     */
    public function getLink()
    {
        return $this->link;
    }

    /**
     * @param array $attributes
     * @return string
     */
    public function buildAttributes($attributes = [])
    {
        $attributes = $this->isActive() ?
            (new MergeAttributes($this->builder->activeAttributes()->all(), $attributes))->merge() :
            $attributes;

        return $this->attributes->build($attributes);
    }

    /**
     * @return bool
     */
    protected function isActive()
    {
        $currentUrl = $this->request->url();
        $url = url($this->getLink()->getUrl());
        
        return $this->isUrlEqual($url, $currentUrl);

It seems like $url defined by url($this->getLink()->getUrl()) on line 79 can also be of type object<Illuminate\Contracts\Routing\UrlGenerator>; however, Malezha\Menu\Entity\Item::isUrlEqual() does only seem to accept string, maybe add an additional type check?

    }

    /**
     * Check is two url equal
     *
     * @param string $first
     * @param string $second
     * @return bool
     */
    protected function isUrlEqual($first, $second)
    {
        $uriForTrim = [
            '#',
            '/index',
            '/'
        ];
        
        foreach ($uriForTrim as $trim) {
            $first = rtrim($first, $trim);
            $second = rtrim($second, $trim);
        }

        return $first == $second;
    }
}