FromArrayBuilder::getInstance() - Code Metrics - Inspection of "Laravel 5.4 update" - Malezha/menu - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3afbe4...79027c )

by Oleg

created 2017-07-11 14:11 UTC

FromArrayBuilder::getInstance() A

↳ Parent: FromArrayBuilder

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	2
eloc	4
nc	2
nop	0
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0

<?php
namespace Malezha\Menu\Support;

use Illuminate\Contracts\Config\Repository;
use Illuminate\Contracts\Container\Container;
use Malezha\Menu\Contracts\Attributes;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php
use Malezha\Menu\Contracts\Builder;
use Malezha\Menu\Contracts\ElementFactory;
use Malezha\Menu\Contracts\FromArrayBuilder as FromArrayBuilderContract;
use Malezha\Menu\Contracts\HasBuilder;

class FromArrayBuilder implements FromArrayBuilderContract
{
    /**
     * @var static
     */
    protected static $instance = null;

    /**
     * @var Container
     */
    private $container;

    /**
     * FromArrayBuilder constructor.
     *
     * @param Container $container
     */
    public function __construct(Container $container)
    {
        $this->container = $container;
    }

    /**
     * @inheritdoc
     */
    public static function getInstance()
    {
        if (is_null(static::$instance)) {
            throw new \RuntimeException(static::class . ' must be set instance.');
        }

        return static::$instance;
    }

    /**
     * @param @inheritdoc
     */
    public static function setInstance($instance)
    {
        static::$instance = $instance;
class Alien {}

class Dalek extends Alien {}

class Plot
{
    /** @var  Dalek */
    public $villain;
}

$alien = new Alien();
$plot = new Plot();
if ($alien instanceof Dalek) {
    $plot->villain = $alien;
}
    }

    /**
     * @param @inheritdoc
     */
    public function build(array $array)
    {
        $aliases = $this->container->make(Repository::class)->get('menu.alias');

        /** @var Builder $builder */
        $builder = $this->container->makeWith(Builder::class, [
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            'attributes' => $this->container->makeWith(Attributes::class,
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                ['attributes' => $array['attributes']]),
            'activeAttributes' => $this->container->makeWith(Attributes::class,
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                ['attributes' => $array['activeAttributes']]),
            'view' => $array['view'],
            'type' => $array['type'],
        ]);

        foreach ($array['elements'] as $key => $element) {
            $class = $aliases[$element['type']];

            $builder->create($key, $class, function (ElementFactory $factory) use ($class, $element) {
                // If element is submenu
                if ($this->isBuilder($class)) {
                    $element['builder'] = $this->build($element['builder']);
                }

                $attributes = preg_grep("/.*(attributes)/i", array_keys($element));

                foreach ($attributes as $key) {
                    $element[$key] = $this->container->makeWith(Attributes::class, ['attributes' => $element[$key]]);
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                }

                return $factory->build($element);
            });
        }

        return $builder;
    }

    /**
     * @param string $class
     * @return bool
     */
    private function isBuilder($class)
    {
        $reflection = new \ReflectionClass($class);

        return $reflection->implementsInterface(HasBuilder::class);
    }
}

1			<?php
2			namespace Malezha\Menu\Support;
3
4			use Illuminate\Contracts\Config\Repository;
5			use Illuminate\Contracts\Container\Container;
6			use Malezha\Menu\Contracts\Attributes;
			0 ignored issues – show Bug introduced 2017-07-11 14:18 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `Malezha\Menu\Support\Attributes`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
7			use Malezha\Menu\Contracts\Builder;
8			use Malezha\Menu\Contracts\ElementFactory;
9			use Malezha\Menu\Contracts\FromArrayBuilder as FromArrayBuilderContract;
10			use Malezha\Menu\Contracts\HasBuilder;
11
12			class FromArrayBuilder implements FromArrayBuilderContract
13			{
14			/**
15			* @var static
16			*/
17			protected static $instance = null;
18
19			/**
20			* @var Container
21			*/
22			private $container;
23
24			/**
25			* FromArrayBuilder constructor.
26			*
27			* @param Container $container
28			*/
29			public function __construct(Container $container)
30			{
31			$this->container = $container;
32			}
33
34			/**
35			* @inheritdoc
36			*/
37			public static function getInstance()
38			{
39			if (is_null(static::$instance)) {
40			throw new \RuntimeException(static::class . ' must be set instance.');
41			}
42
43			return static::$instance;
44			}
45
46			/**
47			* @param @inheritdoc
48			*/
49			public static function setInstance($instance)
50			{
51			static::$instance = $instance;
			0 ignored issues – show Documentation Bug introduced 2017-07-11 14:18 UTC by Report Bug Copy Issue Report `$instance` is of type `object<Malezha\Menu\Contracts\FromArrayBuilder>`, but the property `$instance` was declared to be of type `object<Malezha\Menu\Support\FromArrayBuilder>`. Are you sure that you always receive this specific sub-class here, or does it make sense to add an `instanceof` check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a given class or a super-class is assigned to a property that is type hinted more strictly. Either this assignment is in error or an instanceof check should be added for that assignment. class Alien {} class Dalek extends Alien {} class Plot { /** @var Dalek */ public $villain; } $alien = new Alien(); $plot = new Plot(); if ($alien instanceof Dalek) { $plot->villain = $alien; } Loading history...
52			}
53
54			/**
55			* @param @inheritdoc
56			*/
57			public function build(array $array)
58			{
59			$aliases = $this->container->make(Repository::class)->get('menu.alias');
60
61			/** @var Builder $builder */
62			$builder = $this->container->makeWith(Builder::class, [
			0 ignored issues – show Bug introduced 2017-07-11 14:18 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Illuminate\Contracts\Container\Container` as the method `makeWith()` does only exist in the following implementations of said interface: `Illuminate\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
63			'attributes' => $this->container->makeWith(Attributes::class,
			0 ignored issues – show Bug introduced 2017-07-11 14:18 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Illuminate\Contracts\Container\Container` as the method `makeWith()` does only exist in the following implementations of said interface: `Illuminate\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
64			['attributes' => $array['attributes']]),
65			'activeAttributes' => $this->container->makeWith(Attributes::class,
			0 ignored issues – show Bug introduced 2017-07-11 14:18 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Illuminate\Contracts\Container\Container` as the method `makeWith()` does only exist in the following implementations of said interface: `Illuminate\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
66			['attributes' => $array['activeAttributes']]),
67			'view' => $array['view'],
68			'type' => $array['type'],
69			]);
70
71			foreach ($array['elements'] as $key => $element) {
72			$class = $aliases[$element['type']];
73
74			$builder->create($key, $class, function (ElementFactory $factory) use ($class, $element) {
75			// If element is submenu
76			if ($this->isBuilder($class)) {
77			$element['builder'] = $this->build($element['builder']);
78			}
79
80			$attributes = preg_grep("/.*(attributes)/i", array_keys($element));
81
82			foreach ($attributes as $key) {
83			$element[$key] = $this->container->makeWith(Attributes::class, ['attributes' => $element[$key]]);
			0 ignored issues – show Bug introduced 2017-07-11 14:18 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Illuminate\Contracts\Container\Container` as the method `makeWith()` does only exist in the following implementations of said interface: `Illuminate\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
84			}
85
86			return $factory->build($element);
87			});
88			}
89
90			return $builder;
91			}
92
93			/**
94			* @param string $class
95			* @return bool
96			*/
97			private function isBuilder($class)
98			{
99			$reflection = new \ReflectionClass($class);
100
101			return $reflection->implementsInterface(HasBuilder::class);
102			}
103			}

Malezha / menu

Push — master ( 3afbe4...79027c )

FromArrayBuilder::getInstance() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like