Malezha\Menu\Tests\RenderTest

Complexity

Total Complexity

5

Size/Duplication

Total Lines	58
Duplicated Lines	13.79 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
B	getBuilder()	8	28	1
A	getStub()	0	4	1
A	makeTest()	0	10	1
A	testBladeRender()	0	5	1
A	testBasicRender()	0	4	1

<?php
namespace Malezha\Menu\Tests;

use Illuminate\Contracts\Container\Container;
use Malezha\Menu\Contracts\Attributes;
use Malezha\Menu\Contracts\Builder;
use Malezha\Menu\Contracts\Item;
use Malezha\Menu\Contracts\MenuRender;
use Malezha\Menu\Render\Basic;
use Malezha\Menu\Render\Blade;

class RenderTest extends TestCase
{
    protected function getBuilder()
    {
        /** @var Builder $builder */
        $builder = $this->app->make(Builder::class, [
            'name' => 'test',
            'activeAttributes' => $this->app->make(Attributes::class, ['attributes' => ['class' => 'active']]),
            'attributes' => $this->app->make(Attributes::class, ['attributes' => ['class' => 'menu']]),
        ]);
        $index = $builder->add('index', 'Index Page', url('/'));
        $index->getLink()->getAttributes()->push(['class' => 'menu-link']);

        $builder->group('orders', function(Item $item) {
            $item->getAttributes()->push(['class' => 'child-menu']);

            $link = $item->getLink();
            $link->setTitle('Orders');
            $link->setUrl('javascript:;');
        }, function(Builder $menu) {

This code seems to be duplicated across your project.

            $menu->add('all', 'All', url('/orders/all'));

It seems like url('/orders/all') targeting url() can also be of type object<Illuminate\Contracts\Routing\UrlGenerator>; however, Malezha\Menu\Contracts\Builder::add() does only seem to accept string, maybe add an additional type check?

            $menu->add('type_1', 'Type 1', url('/orders/1'), [], ['class' => 'text-color-red']);

It seems like url('/orders/1') targeting url() can also be of type object<Illuminate\Contracts\Routing\UrlGenerator>; however, Malezha\Menu\Contracts\Builder::add() does only seem to accept string, maybe add an additional type check?

            $menu->add('type_2', 'Type 2', url('/orders/2'), [], [], function(Item $item) {

It seems like url('/orders/2') targeting url() can also be of type object<Illuminate\Contracts\Routing\UrlGenerator>; however, Malezha\Menu\Contracts\Builder::add() does only seem to accept string, maybe add an additional type check?

                $item->getLink()->getAttributes()->push(['data-attribute' => 'value']);
            });
        });

        return $builder;
    }

    protected function getStub()
    {
        return $file = file_get_contents(__DIR__ . '/stub/menu.html');

$file is not used, you could remove the assignment.

    }

    protected function makeTest($render)
    {
        $this->app->instance('menu.render', $render);
        $this->app->alias('menu.render', MenuRender::class);

        $builder = $this->getBuilder();
        $stub = $this->getStub();
        $this->assertAttributeInstanceOf(get_class($render), 'viewFactory', $builder);
        $this->assertEquals($stub, $builder->render());
    }

    public function testBladeRender()
    {
        $this->makeTest(new Blade($this->app));

    }

    public function testBasicRender()
    {
        $this->makeTest(new Basic($this->app));
    }
}