AbstractElement::unserialize() - Code Metrics - Inspection of "fixes" - Malezha/menu - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 5a9d2e...4895be )

by Oleg

created 2016-05-31 20:56 UTC

AbstractElement::unserialize() B

↳ Parent: AbstractElement

Complexity

Conditions	6
Paths	6

Size

Total Lines	21
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	16
CRAP Score	6

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	21
ccs	16
cts	16
cp	1
rs	8.7624
cc	6
eloc	12
nc	6
nop	1
crap	6

<?php
namespace Malezha\Menu\Element;

use Illuminate\Container\Container;
use Malezha\Menu\Contracts\DisplayRule;
use Malezha\Menu\Contracts\Element;
use Malezha\Menu\Contracts\MenuRender;
use Serafim\Properties\Properties;

/**
 * Class AbstractElement
 * @package Malezha\Menu\Element
 */
abstract class AbstractElement implements Element
{
    use Properties;

    /**
     * @var string
     */
    protected $view;

    /**
     * @var MenuRender
     */
    protected $render;

    /**
     * @inheritdoc
     */
    public function getView()
    {
        return $this->view;
    }

    /**
     * @inheritdoc
     */
    public function setView($view)
    {
        if ($this->render->exists($view)) {
            $this->view = $view;
        }
    }

    protected function propertiesForSerialization()
    {
        return [
            'view' => $this->view,
        ];
    }

    /**
     * @inheritDoc
     */
    public function toArray()
    {
        return [
            'view' => $this->view,
        ];
    }

    /**
     * @inheritDoc
     */
    public function serialize()
    {
        return serialize($this->propertiesForSerialization());
    }

    /**
     * @inheritDoc
     */
    public function unserialize($serialized)
    {
        $data = unserialize($serialized);

        if ($this instanceof DisplayRule
            && method_exists($this, 'unserializeRule')
            && array_key_exists('displayRule', $data)
        ) {
            $this->unserializeRule($data['displayRule']);

            unset($data['displayRule']);
        }

        foreach ($data as $key => $value) {
            if (property_exists($this, $key)) {
                $this->{$key} = $value;
            }
        }

        $app = Container::getInstance();
        $this->render = $app->make(MenuRender::class);
    }
}

1		<?php
2		namespace Malezha\Menu\Element;
3
4		use Illuminate\Container\Container;
5		use Malezha\Menu\Contracts\DisplayRule;
6		use Malezha\Menu\Contracts\Element;
7		use Malezha\Menu\Contracts\MenuRender;
8		use Serafim\Properties\Properties;
9
10		/**
11		* Class AbstractElement
12		* @package Malezha\Menu\Element
13		*/
14		abstract class AbstractElement implements Element
15		{
16		use Properties;
17
18		/**
19		* @var string
20		*/
21		protected $view;
22
23		/**
24		* @var MenuRender
25		*/
26		protected $render;
27
28		/**
29		* @inheritdoc
30		*/
31	1	public function getView()
32		{
33	1	return $this->view;
34		}
35
36		/**
37		* @inheritdoc
38		*/
39	1	public function setView($view)
40		{
41	1	if ($this->render->exists($view)) {
42	1	$this->view = $view;
43	1	}
44	1	}
45
46	3	protected function propertiesForSerialization()
47		{
48		return [
49	3	'view' => $this->view,
50	3	];
51		}
52
53		/**
54		* @inheritDoc
55		*/
56	3	public function toArray()
57		{
58		return [
59	3	'view' => $this->view,
60	3	];
61		}
62
63		/**
64		* @inheritDoc
65		*/
66	3	public function serialize()
67		{
68	3	return serialize($this->propertiesForSerialization());
69		}
70
71		/**
72		* @inheritDoc
73		*/
74	3	public function unserialize($serialized)
75		{
76	3	$data = unserialize($serialized);
77
78		if ($this instanceof DisplayRule
79	3	&& method_exists($this, 'unserializeRule')
80	3	&& array_key_exists('displayRule', $data)
81	3	) {
82	3	$this->unserializeRule($data['displayRule']);
		0 ignored issues – show Bug introduced 2016-05-31 20:01 UTC by Report Bug Copy Issue Report The method `unserializeRule()` does not exist on `Malezha\Menu\Element\AbstractElement`. Did you maybe mean `serialize()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
83	3	unset($data['displayRule']);
84	3	}
85
86	3	foreach ($data as $key => $value) {
87	3	if (property_exists($this, $key)) {
88	3	$this->{$key} = $value;
89	3	}
90	3	}
91
92	3	$app = Container::getInstance();
93	3	$this->render = $app->make(MenuRender::class);
94		}
95		}

Malezha / menu

Push — master ( 5a9d2e...4895be )

AbstractElement::unserialize() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like