ComparativeUrl::__construct() - Code Metrics - Inspection of "url" - Malezha/menu - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4895be...67409c )

by Oleg

created 2016-06-09 15:52 UTC

ComparativeUrl::__construct() A

↳ Parent: ComparativeUrl

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	6
ccs	5
cts	5
cp	1
rs	9.4285
cc	1
eloc	4
nc	1
nop	2
crap	1

<?php
namespace Malezha\Menu\Support;

use Illuminate\Contracts\Routing\UrlGenerator;
use Malezha\Menu\Contracts\ComparativeUrl as ComparativeUrlContract;

class ComparativeUrl implements ComparativeUrlContract
{
    /**
     * @var UrlGenerator
     */
    protected $urlGenerator;

    /**
     * @var array
     */
    protected $skippedPaths = [];

    /**
     * @var array
     */
    protected $components = [
        'host', 'path', 'query',
    ];

    /**
     * @var array
     */
    protected $parsedCurrentUrl;

    /**
     * @inheritDoc
     */
    public function __construct(UrlGenerator $generator, $skippedPaths = [])
    {
        $this->urlGenerator = $generator;
        $this->skippedPaths = $skippedPaths;
        $this->parsedCurrentUrl = parse_url($generator->current());
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
    }

    /**
     * @inheritDoc
     */
    public function isEquals($url)
    {
        if (in_array($url, $this->skippedPaths)) {
            return false;
        }

        $parsedUrl = parse_url($this->buildUrl($url));

        $counterMin = count(array_intersect($this->components, array_keys($parsedUrl)));
        $counter = 0;
        
        foreach ($this->components as $component) {
            if ($this->checkComponent($component, $parsedUrl)) {
<?php

function getDate($date)
{
    if ($date !== null) {
        return new DateTime($date);
    }

    return false;
}
                $counter++;
            }
        }
        
        if ($counter >= $counterMin) {
            return true;
        }
        
        return false;
    }

    /**
     * @param string $url
     * @return string
     */
    protected function buildUrl($url)
    {
        return $this->urlGenerator->to($url);
    }

    /**
     * @param string $component
     * @param array $parsedUrl
     * @return bool
     */
    protected function checkComponent($component, $parsedUrl)
    {
        if (array_key_exists($component, $this->parsedCurrentUrl)) {
            if (array_key_exists($component, $parsedUrl)
                && $parsedUrl[$component] === $this->parsedCurrentUrl[$component]) {
                    return true;
            }
        }

        return false;
    }
}

1		<?php
2		namespace Malezha\Menu\Support;
3
4		use Illuminate\Contracts\Routing\UrlGenerator;
5		use Malezha\Menu\Contracts\ComparativeUrl as ComparativeUrlContract;
6
7		class ComparativeUrl implements ComparativeUrlContract
8		{
9		/**
10		* @var UrlGenerator
11		*/
12		protected $urlGenerator;
13
14		/**
15		* @var array
16		*/
17		protected $skippedPaths = [];
18
19		/**
20		* @var array
21		*/
22		protected $components = [
23		'host', 'path', 'query',
24		];
25
26		/**
27		* @var array
28		*/
29		protected $parsedCurrentUrl;
30
31		/**
32		* @inheritDoc
33		*/
34	24	public function __construct(UrlGenerator $generator, $skippedPaths = [])
35		{
36	24	$this->urlGenerator = $generator;
37	24	$this->skippedPaths = $skippedPaths;
38	24	$this->parsedCurrentUrl = parse_url($generator->current());
		0 ignored issues – show Documentation Bug introduced 2016-06-09 15:57 UTC by Report Bug Copy Issue Report It seems like `parse_url($generator->current())` can also be of type `false`. However, the property `$parsedCurrentUrl` is declared as type `array`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
39	24	}
40
41		/**
42		* @inheritDoc
43		*/
44	8	public function isEquals($url)
45		{
46	8	if (in_array($url, $this->skippedPaths)) {
47	4	return false;
48		}
49
50	8	$parsedUrl = parse_url($this->buildUrl($url));
51
52	8	$counterMin = count(array_intersect($this->components, array_keys($parsedUrl)));
53	8	$counter = 0;
54
55	8	foreach ($this->components as $component) {
56	8	if ($this->checkComponent($component, $parsedUrl)) {
		0 ignored issues – show Security Bug introduced 2016-06-09 15:57 UTC by Report Bug Copy Issue Report It seems like `$parsedUrl` defined by `parse_url($this->buildUrl($url))` on line `50` can also be of type `false`; however, `Malezha\Menu\Support\Com...veUrl::checkComponent()` does only seem to accept `array`, did you maybe forget to handle an error condition? This check looks for type mismatches where the missing type is `false`. This is usually indicative of an error condtion. Consider the follow example <?php function getDate($date) { if ($date !== null) { return new DateTime($date); } return false; } This function either returns a new `DateTime` object or false, if there was an error. This is a typical pattern in PHP programming to show that an error has occurred without raising an exception. The calling code should check for this returned `false` before passing on the value to another function or method that may not be able to handle a `false`. Loading history...
57	8	$counter++;
58		}
59		}
60
61	8	if ($counter >= $counterMin) {
62	6	return true;
63		}
64
65	8	return false;
66		}
67
68		/**
69		* @param string $url
70		* @return string
71		*/
72	8	protected function buildUrl($url)
73		{
74	8	return $this->urlGenerator->to($url);
75		}
76
77		/**
78		* @param string $component
79		* @param array $parsedUrl
80		* @return bool
81		*/
82	8	protected function checkComponent($component, $parsedUrl)
83		{
84	8	if (array_key_exists($component, $this->parsedCurrentUrl)) {
85	8	if (array_key_exists($component, $parsedUrl)
86	8	&& $parsedUrl[$component] === $this->parsedCurrentUrl[$component]) {
87	8	return true;
88		}
89		}
90
91	8	return false;
92		}
93		}

Malezha / menu

Push — master ( 4895be...67409c )

ComparativeUrl::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like