Menu::fromArray() - Code Metrics - Malezha/menu - Measure and Improve Code Quality continuously with Scrutinizer

Menu::fromArray() A
last analyzed 2017-07-11 14:23 UTC

↳ Parent: Menu

Complexity

Conditions	1
Paths	1

Size

Total Lines	14
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	7
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	7
nc	1
nop	2
dl	0
loc	14
ccs	7
cts	7
cp	1
crap	1
rs	9.4285
c	0
b	0
f	0

<?php

namespace Malezha\Menu;

use Illuminate\Contracts\Container\Container;
use Malezha\Menu\Contracts\Attributes;
use Malezha\Menu\Contracts\Builder as BuilderContract;
use Malezha\Menu\Contracts\Menu as MenuContract;

/**
 * Class Menu
 * @package Malezha\Menu
 */
class Menu implements MenuContract
{
    /**
     * @var BuilderContract[]
     */
    protected $menuList = [];

    /**
     * @var Container
     */
    protected $container;

    /**
     * @inheritDoc
     */
    public function __construct(Container $container)
    {
        $this->container = $container;
    }

    /**
     * @inheritDoc
     */
    public function make($name, callable $callback = null, $type = Builder::UL, $attributes = [], $activeAttributes = [])
    {
        $menu = $this->container->makeWith(BuilderContract::class, [
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            'container' => $this->container, 
            'name' => $name, 
            'type' => $type, 
            'attributes' => $this->container->makeWith(Attributes::class, ['attributes' => $attributes]),
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            'activeAttributes' => $this->container->makeWith(Attributes::class, ['attributes' => $activeAttributes]),
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        ]);

        call_if_callable($callback, $menu);

        $this->menuList[$name] = $menu;

        return $menu;
    }

    /**
     * @inheritDoc
     */
    public function get($name)
    {
        if (array_key_exists($name, $this->menuList) && ($menu = $this->menuList[$name]) instanceof BuilderContract) {
            return $menu;
        }

        throw new \RuntimeException('Menu not found');
    }

    /**
     * @inheritDoc
     */
    public function render($name, $view = null)
    {
        return $this->get($name)->render($view);
    }

    /**
     * @inheritDoc
     */
    public function has($name)
    {
        return array_key_exists($name, $this->menuList);
    }

    /**
     * @inheritDoc
     */
    public function forget($name)
    {
        if ($this->has($name)) {
            unset($this->menuList[$name]);
        }
    }

    /**
     * @inheritDoc
     */
    public function fromArray($name, array $builder)
    {
        /** @var BuilderContract $menu */
        $menu = $this->container->makeWith(BuilderContract::class, [
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            'attributes' => $this->container->makeWith(Attributes::class, ['attributes' => []]),
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            'activeAttributes' => $this->container->makeWith(Attributes::class, ['attributes' => []]),
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        ]);
        
        $menu = $menu->fromArray($builder);

        $this->menuList[$name] = $menu;
        
        return $menu;
    }

    /**
     * @inheritDoc
     */
    public function toArray($name)
    {
        if (!$this->has($name)) {
            throw new \RuntimeException("Menu not found");
        }
        
        return $this->menuList[$name]->toArray();
    }
}

1		<?php
2
3		namespace Malezha\Menu;
4
5		use Illuminate\Contracts\Container\Container;
6		use Malezha\Menu\Contracts\Attributes;
7		use Malezha\Menu\Contracts\Builder as BuilderContract;
8		use Malezha\Menu\Contracts\Menu as MenuContract;
9
10		/**
11		* Class Menu
12		* @package Malezha\Menu
13		*/
14		class Menu implements MenuContract
15		{
16		/**
17		* @var BuilderContract[]
18		*/
19		protected $menuList = [];
20
21		/**
22		* @var Container
23		*/
24		protected $container;
25
26		/**
27		* @inheritDoc
28		*/
29	8	public function __construct(Container $container)
30		{
31	8	$this->container = $container;
32	8	}
33
34		/**
35		* @inheritDoc
36		*/
37	5	public function make($name, callable $callback = null, $type = Builder::UL, $attributes = [], $activeAttributes = [])
38		{
39	5	$menu = $this->container->makeWith(BuilderContract::class, [
		0 ignored issues – show Bug introduced 2017-07-11 14:18 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Illuminate\Contracts\Container\Container` as the method `makeWith()` does only exist in the following implementations of said interface: `Illuminate\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
40	5	'container' => $this->container,
41	5	'name' => $name,
42	5	'type' => $type,
43	5	'attributes' => $this->container->makeWith(Attributes::class, ['attributes' => $attributes]),
		0 ignored issues – show Bug introduced 2017-07-11 14:18 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Illuminate\Contracts\Container\Container` as the method `makeWith()` does only exist in the following implementations of said interface: `Illuminate\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
44	5	'activeAttributes' => $this->container->makeWith(Attributes::class, ['attributes' => $activeAttributes]),
		0 ignored issues – show Bug introduced 2017-07-11 14:18 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Illuminate\Contracts\Container\Container` as the method `makeWith()` does only exist in the following implementations of said interface: `Illuminate\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
45		]);
46
47	5	call_if_callable($callback, $menu);
48
49	5	$this->menuList[$name] = $menu;
50
51	5	return $menu;
52		}
53
54		/**
55		* @inheritDoc
56		*/
57	4	public function get($name)
58		{
59	4	if (array_key_exists($name, $this->menuList) && ($menu = $this->menuList[$name]) instanceof BuilderContract) {
60	3	return $menu;
61		}
62
63	1	throw new \RuntimeException('Menu not found');
64		}
65
66		/**
67		* @inheritDoc
68		*/
69	1	public function render($name, $view = null)
70		{
71	1	return $this->get($name)->render($view);
72		}
73
74		/**
75		* @inheritDoc
76		*/
77	3	public function has($name)
78		{
79	3	return array_key_exists($name, $this->menuList);
80		}
81
82		/**
83		* @inheritDoc
84		*/
85	1	public function forget($name)
86		{
87	1	if ($this->has($name)) {
88	1	unset($this->menuList[$name]);
89		}
90	1	}
91
92		/**
93		* @inheritDoc
94		*/
95	1	public function fromArray($name, array $builder)
96		{
97		/** @var BuilderContract $menu */
98	1	$menu = $this->container->makeWith(BuilderContract::class, [
		0 ignored issues – show Bug introduced 2017-07-11 14:18 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Illuminate\Contracts\Container\Container` as the method `makeWith()` does only exist in the following implementations of said interface: `Illuminate\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
99	1	'attributes' => $this->container->makeWith(Attributes::class, ['attributes' => []]),
		0 ignored issues – show Bug introduced 2017-07-11 14:18 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Illuminate\Contracts\Container\Container` as the method `makeWith()` does only exist in the following implementations of said interface: `Illuminate\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
100	1	'activeAttributes' => $this->container->makeWith(Attributes::class, ['attributes' => []]),
		0 ignored issues – show Bug introduced 2017-07-11 14:18 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Illuminate\Contracts\Container\Container` as the method `makeWith()` does only exist in the following implementations of said interface: `Illuminate\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
101		]);
102
103	1	$menu = $menu->fromArray($builder);
104
105	1	$this->menuList[$name] = $menu;
106
107	1	return $menu;
108		}
109
110		/**
111		* @inheritDoc
112		*/
113	1	public function toArray($name)
114		{
115	1	if (!$this->has($name)) {
116		throw new \RuntimeException("Menu not found");
117		}
118
119	1	return $this->menuList[$name]->toArray();
120		}
121		}

Malezha / menu

Menu::fromArray() A last analyzed 2017-07-11 14:23 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

Menu::fromArray() A
last analyzed 2017-07-11 14:23 UTC