TextFactory::build() - Code Metrics - Malezha/menu - Measure and Improve Code Quality continuously with Scrutinizer

TextFactory::build() A
last analyzed 2017-07-11 14:23 UTC

↳ Parent: TextFactory

Complexity

Conditions	2
Paths	2

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	5
CRAP Score	2

Importance

Changes

Metric	Value
cc	2
eloc	5
nc	2
nop	1
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0
ccs	5
cts	5
cp	1
crap	2

<?php
namespace Malezha\Menu\Factory;

use Illuminate\Contracts\Container\Container;
use Malezha\Menu\Contracts\Attributes;
use Malezha\Menu\Element\Text;

/**
 * Class TextFactory
 * @package Malezha\Menu\Factory
 * 
 * @property string $text
 * @property Attributes $attributes
 * @property mixed $displayRule
 */
class TextFactory extends AbstractElementFactory
{
    /**
     * @param array $parameters
     * @return Text
     */
    public function build($parameters = [])
    {
        $text = $this->app->makeWith(Text::class, $this->mergeParameters($parameters));
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        if (array_key_exists('displayRule', $this->parameters)) {
            $text->setDisplayRule($this->parameters['displayRule']);
        }

        return $text;
    }

    /**
     * @inheritDoc
     */
    public function __construct(Container $container)
    {
        parent::__construct($container);
        
        $this->parameters = [
            'text' => null,
            'displayRule' => true,
            'attributes' => $this->app->makeWith(Attributes::class, ['attributes' => []]),
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            'view' => $this->getElementConfig(Text::class)['view'],
        ];
    }
}

TextFactory::build() A
last analyzed 2017-07-11 14:23 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

1		<?php
2		namespace Malezha\Menu\Factory;
3
4		use Illuminate\Contracts\Container\Container;
5		use Malezha\Menu\Contracts\Attributes;
6		use Malezha\Menu\Element\Text;
7
8		/**
9		* Class TextFactory
10		* @package Malezha\Menu\Factory
11		*
12		* @property string $text
13		* @property Attributes $attributes
14		* @property mixed $displayRule
15		*/
16		class TextFactory extends AbstractElementFactory
17		{
18		/**
19		* @param array $parameters
20		* @return Text
21		*/
22	8	public function build($parameters = [])
23		{
24	8	$text = $this->app->makeWith(Text::class, $this->mergeParameters($parameters));
		0 ignored issues – show Bug introduced 2017-07-11 14:18 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Illuminate\Contracts\Container\Container` as the method `makeWith()` does only exist in the following implementations of said interface: `Illuminate\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
25	8	if (array_key_exists('displayRule', $this->parameters)) {
26	8	$text->setDisplayRule($this->parameters['displayRule']);
27		}
28
29	8	return $text;
30		}
31
32		/**
33		* @inheritDoc
34		*/
35	8	public function __construct(Container $container)
36		{
37	8	parent::__construct($container);
38
39	8	$this->parameters = [
40	8	'text' => null,
41		'displayRule' => true,
42	8	'attributes' => $this->app->makeWith(Attributes::class, ['attributes' => []]),
		0 ignored issues – show Bug introduced 2017-07-11 14:18 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Illuminate\Contracts\Container\Container` as the method `makeWith()` does only exist in the following implementations of said interface: `Illuminate\Container\Container`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
43	8	'view' => $this->getElementConfig(Text::class)['view'],
44		];
45		}
46		}

Malezha / menu

TextFactory::build() A last analyzed 2017-07-11 14:23 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

TextFactory::build() A
last analyzed 2017-07-11 14:23 UTC