Majkl578 / doctrine-dbal

lib/Doctrine/DBAL/Platforms/PostgreSQL91Platform.php

Spacing +1 added lines, -1 removed lines

@@ -62,6 +62,6 @@
         $sql = parent::getListTableColumnsSQL($table, $database);
         $parts = explode('AS complete_type,', $sql, 2);
 
-        return $parts[0].'AS complete_type, (SELECT tc.collcollate FROM pg_catalog.pg_collation tc WHERE tc.oid = a.attcollation) AS collation,'.$parts[1];
+        return $parts[0] . 'AS complete_type, (SELECT tc.collcollate FROM pg_catalog.pg_collation tc WHERE tc.oid = a.attcollation) AS collation,' . $parts[1];
     }
 }

lib/Doctrine/DBAL/Platforms/PostgreSqlPlatform.php

Spacing +12 added lines, -12 removed lines

@@ -134,10 +134,10 @@ 
         if ($startPos !== false) {
             $str = $this->getSubstringExpression($str, $startPos);
 
-            return 'CASE WHEN (POSITION('.$substr.' IN '.$str.') = 0) THEN 0 ELSE (POSITION('.$substr.' IN '.$str.') + '.($startPos-1).') END';
+            return 'CASE WHEN (POSITION(' . $substr . ' IN ' . $str . ') = 0) THEN 0 ELSE (POSITION(' . $substr . ' IN ' . $str . ') + ' . ($startPos - 1) . ') END';
         }
 
-        return 'POSITION('.$substr.' IN '.$str.')';
+        return 'POSITION(' . $substr . ' IN ' . $str . ')';
     }
 
     /**
@@ -150,7 +150,7 @@ 
             $unit      = DateIntervalUnit::MONTH;
         }
 
-        return "(" . $date ." " . $operator . " (" . $interval . " || ' " . $unit . "')::interval)";
+        return "(" . $date . " " . $operator . " (" . $interval . " || ' " . $unit . "')::interval)";
     }
 
     /**
@@ -310,7 +310,7 @@ 
                   (
                       SELECT c.oid
                       FROM pg_catalog.pg_class c, pg_catalog.pg_namespace n
-                      WHERE " .$this->getTableWhereClause($table) ." AND n.oid = c.relnamespace
+                      WHERE " .$this->getTableWhereClause($table) . " AND n.oid = c.relnamespace
                   )
                   AND r.contype = 'f'";
     }
@@ -328,7 +328,7 @@ 
      */
     public function getDropViewSQL($name)
     {
-        return 'DROP VIEW '. $name;
+        return 'DROP VIEW ' . $name;
     }
 
     /**
@@ -367,7 +367,7 @@ 
                  WHERE oid IN (
                     SELECT indexrelid
                     FROM pg_index si, pg_class sc, pg_namespace sn
-                    WHERE " . $this->getTableWhereClause($table, 'sc', 'sn')." AND sc.oid=si.indrelid AND sc.relnamespace = sn.oid
+                    WHERE " . $this->getTableWhereClause($table, 'sc', 'sn') . " AND sc.oid=si.indrelid AND sc.relnamespace = sn.oid
                  ) AND pg_index.indexrelid = oid";
     }
 
@@ -380,7 +380,7 @@ 
      */
     private function getTableWhereClause($table, $classAlias = 'c', $namespaceAlias = 'n')
     {
-        $whereClause = $namespaceAlias.".nspname NOT IN ('pg_catalog', 'information_schema', 'pg_toast') AND ";
+        $whereClause = $namespaceAlias . ".nspname NOT IN ('pg_catalog', 'information_schema', 'pg_toast') AND ";
         if (strpos($table, ".") !== false) {
             list($schema, $table) = explode(".", $table);
             $schema = $this->quoteStringLiteral($schema);
@@ -424,7 +424,7 @@ 
                         FROM pg_description WHERE pg_description.objoid = c.oid AND a.attnum = pg_description.objsubid
                     ) AS comment
                     FROM pg_attribute a, pg_class c, pg_type t, pg_namespace n
-                    WHERE ".$this->getTableWhereClause($table, 'c', 'n') ."
+                    WHERE ".$this->getTableWhereClause($table, 'c', 'n') . "
                         AND a.attnum > 0
                         AND a.attrelid = c.oid
                         AND a.atttypid = t.oid
@@ -822,7 +822,7 @@ 
             return $callback($value ? true : false);
         }
 
-        if (!is_string($value)) {
+        if ( ! is_string($value)) {
             return $callback(true);
         }
 
@@ -878,7 +878,7 @@ 
 
         return $this->doConvertBooleans(
             $item,
-            function ($boolean) {
+            function($boolean) {
                 if (null === $boolean) {
                     return 'NULL';
                 }
@@ -899,7 +899,7 @@ 
 
         return $this->doConvertBooleans(
             $item,
-            function ($boolean) {
+            function($boolean) {
                 return null === $boolean ? null : (int) $boolean;
             }
         );
@@ -1236,7 +1236,7 @@ 
      */
     private function typeChangeBreaksDefaultValue(ColumnDiff $columnDiff) : bool
     {
-        if (! $columnDiff->fromColumn) {
+        if ( ! $columnDiff->fromColumn) {
             return $columnDiff->hasChanged('type');
         }
 

lib/Doctrine/DBAL/Platforms/SqlitePlatform.php

Spacing +12 added lines, -12 removed lines

@@ -131,10 +131,10 @@ 
     public function getLocateExpression($str, $substr, $startPos = false)
     {
         if ($startPos == false) {
-            return 'LOCATE('.$str.', '.$substr.')';
+            return 'LOCATE(' . $str . ', ' . $substr . ')';
         }
 
-        return 'LOCATE('.$str.', '.$substr.', '.$startPos.')';
+        return 'LOCATE(' . $str . ', ' . $substr . ', ' . $startPos . ')';
     }
 
     /**
@@ -161,7 +161,7 @@ 
                         break;
                 }
 
-                if (! is_numeric($interval)) {
+                if ( ! is_numeric($interval)) {
                     $interval = "' || " . $interval . " || '";
                 }
 
@@ -174,7 +174,7 @@ 
      */
     public function getDateDiffExpression($date1, $date2)
     {
-        return 'ROUND(JULIANDAY('.$date1 . ')-JULIANDAY('.$date2.'))';
+        return 'ROUND(JULIANDAY(' . $date1 . ')-JULIANDAY(' . $date2 . '))';
     }
 
     /**
@@ -345,12 +345,12 @@ 
 
         if (isset($options['primary']) && ! empty($options['primary'])) {
             $keyColumns = array_unique(array_values($options['primary']));
-            $queryFields.= ', PRIMARY KEY('.implode(', ', $keyColumns).')';
+            $queryFields .= ', PRIMARY KEY(' . implode(', ', $keyColumns) . ')';
         }
 
         if (isset($options['foreignKeys'])) {
             foreach ($options['foreignKeys'] as $foreignKey) {
-                $queryFields.= ', '.$this->getForeignKeyDeclarationSQL($foreignKey);
+                $queryFields .= ', ' . $this->getForeignKeyDeclarationSQL($foreignKey);
             }
         }
 
@@ -480,7 +480,7 @@ 
      */
     public function getDropViewSQL($name)
     {
-        return 'DROP VIEW '. $name;
+        return 'DROP VIEW ' . $name;
     }
 
     /**
@@ -682,7 +682,7 @@ 
         }
 
         $sql = [];
-        $tableName = $diff->newName ? $diff->getNewName(): $diff->getName($this);
+        $tableName = $diff->newName ? $diff->getNewName() : $diff->getName($this);
         foreach ($this->getIndexesInAlteredTable($diff) as $index) {
             if ($index->isPrimary()) {
                 continue;
@@ -886,7 +886,7 @@ 
         $sql = [];
         $tableSql = [];
         if ( ! $this->onSchemaAlterTable($diff, $tableSql)) {
-            $dataTable = new Table('__temp__'.$table->getName());
+            $dataTable = new Table('__temp__' . $table->getName());
 
             $newTable = new Table($table->getQuotedName($this), $columns, $this->getPrimaryIndexInAlteredTable($diff), $this->getForeignKeysInAlteredTable($diff), 0, $table->getOptions());
             $newTable->addOption('alter', true);
@@ -902,7 +902,7 @@ 
 
             if ($diff->newName && $diff->newName != $diff->name) {
                 $renamedTable = $diff->getNewName();
-                $sql[] = 'ALTER TABLE '.$newTable->getQuotedName($this).' RENAME TO '.$renamedTable->getQuotedName($this);
+                $sql[] = 'ALTER TABLE ' . $newTable->getQuotedName($this) . ' RENAME TO ' . $renamedTable->getQuotedName($this);
             }
 
             $sql = array_merge($sql, $this->getPostAlterTableIndexForeignKeySQL($diff));
@@ -975,13 +975,13 @@ 
                 $field['length'] = 255;
             }
 
-            $sql[] = 'ALTER TABLE '.$table->getQuotedName($this).' ADD COLUMN '.$this->getColumnDeclarationSQL($field['name'], $field);
+            $sql[] = 'ALTER TABLE ' . $table->getQuotedName($this) . ' ADD COLUMN ' . $this->getColumnDeclarationSQL($field['name'], $field);
         }
 
         if ( ! $this->onSchemaAlterTable($diff, $tableSql)) {
             if ($diff->newName !== false) {
                 $newTable = new Identifier($diff->newName);
-                $sql[] = 'ALTER TABLE '.$table->getQuotedName($this).' RENAME TO '.$newTable->getQuotedName($this);
+                $sql[] = 'ALTER TABLE ' . $table->getQuotedName($this) . ' RENAME TO ' . $newTable->getQuotedName($this);
             }
         }
 

lib/Doctrine/DBAL/Platforms/OraclePlatform.php

Spacing +13 added lines, -13 removed lines

@@ -98,10 +98,10 @@ 
     public function getLocateExpression($str, $substr, $startPos = false)
     {
         if ($startPos == false) {
-            return 'INSTR('.$str.', '.$substr.')';
+            return 'INSTR(' . $str . ', ' . $substr . ')';
         }
 
-        return 'INSTR('.$str.', '.$substr.', '.$startPos.')';
+        return 'INSTR(' . $str . ', ' . $substr . ', ' . $startPos . ')';
     }
 
     /**
@@ -167,7 +167,7 @@ 
      */
     public function getDateDiffExpression($date1, $date2)
     {
-        return "TRUNC(TO_NUMBER(SUBSTR((" . $date1 . "-" . $date2 . "), 1, INSTR(" . $date1 . "-" . $date2 .", ' '))))";
+        return "TRUNC(TO_NUMBER(SUBSTR((" . $date1 . "-" . $date2 . "), 1, INSTR(" . $date1 . "-" . $date2 . ", ' '))))";
     }
 
     /**
@@ -175,7 +175,7 @@ 
      */
     public function getBitAndComparisonExpression($value1, $value2)
     {
-        return 'BITAND('.$value1 . ', ' . $value2 . ')';
+        return 'BITAND(' . $value1 . ', ' . $value2 . ')';
     }
 
     /**
@@ -389,7 +389,7 @@ 
         $database = $this->normalizeIdentifier($database);
         $database = $this->quoteStringLiteral($database->getName());
 
-        return "SELECT sequence_name, min_value, increment_by FROM sys.all_sequences ".
+        return "SELECT sequence_name, min_value, increment_by FROM sys.all_sequences " .
                "WHERE SEQUENCE_OWNER = " . $database;
     }
 
@@ -491,7 +491,7 @@ 
      */
     public function getDropViewSQL($name)
     {
-        return 'DROP VIEW '. $name;
+        return 'DROP VIEW ' . $name;
     }
 
     /**
@@ -522,7 +522,7 @@ 
 BEGIN
   SELECT COUNT(CONSTRAINT_NAME) INTO constraints_Count FROM USER_CONSTRAINTS WHERE TABLE_NAME = \'' . $unquotedTableName . '\' AND CONSTRAINT_TYPE = \'P\';
   IF constraints_Count = 0 OR constraints_Count = \'\' THEN
-    EXECUTE IMMEDIATE \''.$this->getCreateConstraintSQL($idx, $quotedTableName).'\';
+    EXECUTE IMMEDIATE \''.$this->getCreateConstraintSQL($idx, $quotedTableName) . '\';
   END IF;
 END;';
 
@@ -542,7 +542,7 @@ 
    last_InsertID NUMBER;
 BEGIN
    SELECT ' . $sequenceName . '.NEXTVAL INTO :NEW.' . $quotedName . ' FROM DUAL;
-   IF (:NEW.' . $quotedName . ' IS NULL OR :NEW.'.$quotedName.' = 0) THEN
+   IF (:NEW.' . $quotedName . ' IS NULL OR :NEW.' . $quotedName . ' = 0) THEN
       SELECT ' . $sequenceName . '.NEXTVAL INTO :NEW.' . $quotedName . ' FROM DUAL;
    ELSE
       SELECT NVL(Last_Number, 0) INTO last_Sequence
@@ -711,11 +711,11 @@ 
      */
     public function getDropForeignKeySQL($foreignKey, $table)
     {
-        if (! $foreignKey instanceof ForeignKeyConstraint) {
+        if ( ! $foreignKey instanceof ForeignKeyConstraint) {
             $foreignKey = new Identifier($foreignKey);
         }
 
-        if (! $table instanceof Table) {
+        if ( ! $table instanceof Table) {
             $table = new Identifier($table);
         }
 
@@ -856,7 +856,7 @@ 
             $oldColumnName = new Identifier($oldColumnName);
 
             $sql[] = 'ALTER TABLE ' . $diff->getName($this)->getQuotedName($this) .
-                ' RENAME COLUMN ' . $oldColumnName->getQuotedName($this) .' TO ' . $column->getQuotedName($this);
+                ' RENAME COLUMN ' . $oldColumnName->getQuotedName($this) . ' TO ' . $column->getQuotedName($this);
         }
 
         $fields = [];
@@ -869,7 +869,7 @@ 
         }
 
         if (count($fields)) {
-            $sql[] = 'ALTER TABLE ' . $diff->getName($this)->getQuotedName($this) . ' DROP (' . implode(', ', $fields).')';
+            $sql[] = 'ALTER TABLE ' . $diff->getName($this)->getQuotedName($this) . ' DROP (' . implode(', ', $fields) . ')';
         }
 
         $tableSql = [];
@@ -994,7 +994,7 @@ 
         }
 
         if (preg_match('/^\s*SELECT/i', $query)) {
-            if (!preg_match('/\sFROM\s/i', $query)) {
+            if ( ! preg_match('/\sFROM\s/i', $query)) {
                 $query .= " FROM dual";
             }
 

lib/Doctrine/DBAL/Platforms/SQLAzurePlatform.php

Spacing +1 added lines, -1 removed lines

@@ -33,7 +33,7 @@
     /**
      * {@inheritDoc}
      */
-    public function getCreateTableSQL(Table $table, $createFlags=self::CREATE_INDEXES)
+    public function getCreateTableSQL(Table $table, $createFlags = self::CREATE_INDEXES)
     {
         $sql = parent::getCreateTableSQL($table, $createFlags);
 

lib/Doctrine/DBAL/Platforms/Keywords/PostgreSQL100Keywords.php

Spacing +1 added lines, -1 removed lines

@@ -1,6 +1,6 @@
 <?php
 
-declare(strict_types=1);
+declare(strict_types = 1);
 
 namespace Doctrine\DBAL\Platforms\Keywords;
 

lib/Doctrine/DBAL/Platforms/DrizzlePlatform.php

Spacing +9 added lines, -9 removed lines

@@ -232,7 +232,7 @@ 
 
         $query = 'CREATE ';
 
-        if (!empty($options['temporary'])) {
+        if ( ! empty($options['temporary'])) {
             $query .= 'TEMPORARY ';
         }
 
@@ -430,7 +430,7 @@ 
     /**
      * {@inheritDoc}
      */
-    public function getDropIndexSQL($index, $table=null)
+    public function getDropIndexSQL($index, $table = null)
     {
         if ($index instanceof Index) {
             $indexName = $index->getQuotedName($this);
@@ -442,7 +442,7 @@ 
 
         if ($table instanceof Table) {
             $table = $table->getQuotedName($this);
-        } elseif (!is_string($table)) {
+        } elseif ( ! is_string($table)) {
             throw new \InvalidArgumentException('DrizzlePlatform::getDropIndexSQL() expects $table parameter to be string or \Doctrine\DBAL\Schema\Table.');
         }
 
@@ -500,7 +500,7 @@ 
         $queryParts = [];
 
         if ($diff->newName !== false) {
-            $queryParts[] =  'RENAME TO ' . $diff->getNewName()->getQuotedName($this);
+            $queryParts[] = 'RENAME TO ' . $diff->getNewName()->getQuotedName($this);
         }
 
         foreach ($diff->addedColumns as $column) {
@@ -518,7 +518,7 @@ 
                 continue;
             }
 
-            $queryParts[] =  'DROP ' . $column->getQuotedName($this);
+            $queryParts[] = 'DROP ' . $column->getQuotedName($this);
         }
 
         foreach ($diff->changedColumns as $columnDiff) {
@@ -541,7 +541,7 @@ 
             }
 
             $columnArray['comment'] = $this->getColumnComment($column);
-            $queryParts[] =  'CHANGE ' . ($columnDiff->getOldColumnName()->getQuotedName($this)) . ' '
+            $queryParts[] = 'CHANGE ' . ($columnDiff->getOldColumnName()->getQuotedName($this)) . ' '
                     . $this->getColumnDeclarationSQL($column->getQuotedName($this), $columnArray);
         }
 
@@ -554,7 +554,7 @@ 
 
             $columnArray = $column->toArray();
             $columnArray['comment'] = $this->getColumnComment($column);
-            $queryParts[] =  'CHANGE ' . $oldColumnName->getQuotedName($this) . ' '
+            $queryParts[] = 'CHANGE ' . $oldColumnName->getQuotedName($this) . ' '
                     . $this->getColumnDeclarationSQL($column->getQuotedName($this), $columnArray);
         }
 
@@ -582,7 +582,7 @@ 
     {
         if ($table instanceof Table) {
             $table = $table->getQuotedName($this);
-        } elseif (!is_string($table)) {
+        } elseif ( ! is_string($table)) {
             throw new \InvalidArgumentException('getDropTableSQL() expects $table parameter to be string or \Doctrine\DBAL\Schema\Table.');
         }
 
@@ -616,7 +616,7 @@ 
             return 'LOCATE(' . $substr . ', ' . $str . ')';
         }
 
-        return 'LOCATE(' . $substr . ', ' . $str . ', '.$startPos.')';
+        return 'LOCATE(' . $substr . ', ' . $str . ', ' . $startPos . ')';
     }
 
     /**

lib/Doctrine/DBAL/DBALException.php

Spacing +16 added lines, -16 removed lines

@@ -47,7 +47,7 @@ 
     public static function invalidPlatformSpecified() : self
     {
         return new self(
-            "Invalid 'platform' option specified, need to give an instance of ".
+            "Invalid 'platform' option specified, need to give an instance of " .
             "\Doctrine\DBAL\Platforms\AbstractPlatform.");
     }
 
@@ -101,7 +101,7 @@ 
     public static function invalidPdoInstance()
     {
         return new self(
-            "The 'pdo' option was used in DriverManager::getConnection() but no ".
+            "The 'pdo' option was used in DriverManager::getConnection() but no " .
             "instance of PDO was given."
         );
     }
@@ -123,7 +123,7 @@ 
             );
         }
 
-        return new self("The options 'driver' or 'driverClass' are mandatory if no PDO ".
+        return new self("The options 'driver' or 'driverClass' are mandatory if no PDO " .
             "instance is given to DriverManager::getConnection().");
     }
 
@@ -135,8 +135,8 @@ 
      */
     public static function unknownDriver($unknownDriverName, array $knownDrivers)
     {
-        return new self("The given 'driver' ".$unknownDriverName." is unknown, ".
-            "Doctrine currently supports only the following drivers: ".implode(", ", $knownDrivers));
+        return new self("The given 'driver' " . $unknownDriverName . " is unknown, " .
+            "Doctrine currently supports only the following drivers: " . implode(", ", $knownDrivers));
     }
 
     /**
@@ -149,11 +149,11 @@ 
      */
     public static function driverExceptionDuringQuery(Driver $driver, \Exception $driverEx, $sql, array $params = [])
     {
-        $msg = "An exception occurred while executing '".$sql."'";
+        $msg = "An exception occurred while executing '" . $sql . "'";
         if ($params) {
             $msg .= " with params " . self::formatParameters($params);
         }
-        $msg .= ":\n\n".$driverEx->getMessage();
+        $msg .= ":\n\n" . $driverEx->getMessage();
 
         return static::wrapException($driver, $driverEx, $msg);
     }
@@ -197,14 +197,14 @@ 
      */
     private static function formatParameters(array $params)
     {
-        return '[' . implode(', ', array_map(function ($param) {
+        return '[' . implode(', ', array_map(function($param) {
             if (is_resource($param)) {
                 return (string) $param;
             }
             
             $json = @json_encode($param);
 
-            if (! is_string($json) || $json == 'null' && is_string($param)) {
+            if ( ! is_string($json) || $json == 'null' && is_string($param)) {
                 // JSON encoding failed, this is not a UTF-8 string.
                 return '"\x' . implode('\x', str_split(bin2hex($param), 2)) . '"';
             }
@@ -220,7 +220,7 @@ 
      */
     public static function invalidWrapperClass($wrapperClass)
     {
-        return new self("The given 'wrapperClass' ".$wrapperClass." has to be a ".
+        return new self("The given 'wrapperClass' " . $wrapperClass . " has to be a " .
             "subtype of \Doctrine\DBAL\Connection.");
     }
 
@@ -231,7 +231,7 @@ 
      */
     public static function invalidDriverClass($driverClass)
     {
-        return new self("The given 'driverClass' ".$driverClass." has to implement the ".
+        return new self("The given 'driverClass' " . $driverClass . " has to implement the " .
             "\Doctrine\DBAL\Driver interface.");
     }
 
@@ -242,7 +242,7 @@ 
      */
     public static function invalidTableName($tableName)
     {
-        return new self("Invalid table name specified: ".$tableName);
+        return new self("Invalid table name specified: " . $tableName);
     }
 
     /**
@@ -252,7 +252,7 @@ 
      */
     public static function noColumnsSpecifiedForTable($tableName)
     {
-        return new self("No columns specified for table ".$tableName);
+        return new self("No columns specified for table " . $tableName);
     }
 
     /**
@@ -270,7 +270,7 @@ 
      */
     public static function typeExists($name)
     {
-        return new self('Type '.$name.' already exists.');
+        return new self('Type ' . $name . ' already exists.');
     }
 
     /**
@@ -280,7 +280,7 @@ 
      */
     public static function unknownColumnType($name)
     {
-        return new self('Unknown column type "'.$name.'" requested. Any Doctrine type that you use has ' .
+        return new self('Unknown column type "' . $name . '" requested. Any Doctrine type that you use has ' .
             'to be registered with \Doctrine\DBAL\Types\Type::addType(). You can get a list of all the ' .
             'known types with \Doctrine\DBAL\Types\Type::getTypesMap(). If this error occurs during database ' .
             'introspection then you might have forgotten to register all database types for a Doctrine Type. Use ' .
@@ -297,6 +297,6 @@ 
      */
     public static function typeNotFound($name)
     {
-        return new self('Type to be overwritten '.$name.' does not exist.');
+        return new self('Type to be overwritten ' . $name . ' does not exist.');
     }
 }

tests/Doctrine/Tests/DbalPerformanceTestListener.php

Spacing +4 added lines, -4 removed lines

@@ -33,7 +33,7 @@ 
             // we identify perf tests by class, method, and dataset
             $class = str_replace('Doctrine\Tests\DBAL\Performance\\', '', get_class($test));
 
-            if (!isset($this->timings[$class])) {
+            if ( ! isset($this->timings[$class])) {
                 $this->timings[$class] = [];
             }
 
@@ -50,13 +50,13 @@ 
      */
     public function __destruct()
     {
-        if (!empty($this->timings)) {
+        if ( ! empty($this->timings)) {
             // Report timings.
             print("\nPerformance test results:\n\n");
 
-            foreach($this->timings as $class => $tests) {
+            foreach ($this->timings as $class => $tests) {
                 printf("%s:\n", $class);
-                foreach($tests as $test => $time) {
+                foreach ($tests as $test => $time) {
                     printf("\t%s: %.3f seconds\n", $test, $time);
                 }
             }