NamedEntry::__construct() - Code Metrics - Inspection of "Rework arrays support to allow mixed named/positio..." - Majkl578/doctrine-annotations - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — mixed-collections ( 23b545...27e0f6 )

by Michael

created 2019-01-07 09:50 UTC

NamedEntry::__construct() A

↳ Parent: NamedEntry

Complexity

Conditions	5
Paths	1

Size

Total Lines	12
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	8
dl	0
loc	12
rs	9.6111
c	0
b	0
f	0
cc	5
nc	1
nop	2

<?php

declare(strict_types=1);

namespace Doctrine\Annotations\Parser\Ast\Collection;

use Doctrine\Annotations\Parser\Ast\ClassConstantFetch;
use Doctrine\Annotations\Parser\Ast\ConstantFetch;
use Doctrine\Annotations\Parser\Ast\Scalar\Identifier;
use Doctrine\Annotations\Parser\Ast\Scalar\IntegerScalar;
use Doctrine\Annotations\Parser\Ast\Scalar\StringScalar;
use Doctrine\Annotations\Parser\Ast\ValuableNode;
use Doctrine\Annotations\Parser\Ast\Value;
use Doctrine\Annotations\Parser\Visitor\Visitor;
use function assert;

final class NamedEntry implements Entry
{
    /** @var StringScalar|IntegerScalar|ConstantFetch|ClassConstantFetch */
    private $key;

    /** @var ValuableNode */
    private $value;

    public function __construct(Value $key, ValuableNode $value)
    {
        assert(
            $key instanceof StringScalar
            || $key instanceof IntegerScalar
            || $key instanceof Identifier
            || $key instanceof ConstantFetch
            || $key instanceof ClassConstantFetch
        );

        $this->key   = $key;
        $this->value = $value;
    }

    /**
     * @return ClassConstantFetch|ConstantFetch|IntegerScalar|StringScalar|null
     */
    public function getKey() : ?Value
    {
        return $this->key;

    }

    public function getValue() : ValuableNode
    {
        return $this->value;
    }

    public function dispatch(Visitor $visitor) : void
    {
        $visitor->visitCollectionNamedEntry($this);
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Doctrine\Annotations\Parser\Ast\Collection;
6
7			use Doctrine\Annotations\Parser\Ast\ClassConstantFetch;
8			use Doctrine\Annotations\Parser\Ast\ConstantFetch;
9			use Doctrine\Annotations\Parser\Ast\Scalar\Identifier;
10			use Doctrine\Annotations\Parser\Ast\Scalar\IntegerScalar;
11			use Doctrine\Annotations\Parser\Ast\Scalar\StringScalar;
12			use Doctrine\Annotations\Parser\Ast\ValuableNode;
13			use Doctrine\Annotations\Parser\Ast\Value;
14			use Doctrine\Annotations\Parser\Visitor\Visitor;
15			use function assert;
16
17			final class NamedEntry implements Entry
18			{
19			/** @var StringScalar\|IntegerScalar\|ConstantFetch\|ClassConstantFetch */
20			private $key;
21
22			/** @var ValuableNode */
23			private $value;
24
25			public function __construct(Value $key, ValuableNode $value)
26			{
27			assert(
28			$key instanceof StringScalar
29			\|\| $key instanceof IntegerScalar
30			\|\| $key instanceof Identifier
31			\|\| $key instanceof ConstantFetch
32			\|\| $key instanceof ClassConstantFetch
33			);
34
35			$this->key = $key;
36			$this->value = $value;
37			}
38
39			/**
40			* @return ClassConstantFetch\|ConstantFetch\|IntegerScalar\|StringScalar\|null
41			*/
42			public function getKey() : ?Value
43			{
44			return $this->key;
			0 ignored issues – show Bug Best Practice introduced 2019-01-07 09:52 UTC by Report Bug Copy Issue Report The expression `return $this->key` could return the type `Doctrine\Annotations\Par...arser\Ast\ConstantFetch` which is incompatible with the type-hinted return `Doctrine\Annotations\Parser\Ast\Value\|null`. Consider adding an additional type-check to rule them out. Loading history...
45			}
46
47			public function getValue() : ValuableNode
48			{
49			return $this->value;
50			}
51
52			public function dispatch(Visitor $visitor) : void
53			{
54			$visitor->visitCollectionNamedEntry($this);
55			}
56			}
57

Majkl578 / doctrine-annotations

Push — mixed-collections ( 23b545...27e0f6 )

NamedEntry::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like