PropertyMetadataTest::testNotValidatesValuesNotMatchingTypeAndThrows() - Code Metrics - Inspection of "Value validation" - Majkl578/doctrine-annotations - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Pull Request — new-parser-ast-metadata (#3)

unknown

created 2018-10-24 17:06 UTC

testNotValidatesValuesNotMatchingTypeAndThrows() A

↳ Parent: PropertyMetadataTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	3
dl	0
loc	7
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	2

<?php

declare(strict_types=1);

namespace Doctrine\Tests\Annotations\Metadata;

use Doctrine\Annotations\Metadata\InvalidPropertyValue;
use Doctrine\Annotations\Metadata\Type\StringType;
use Doctrine\Annotations\Metadata\Type\Type;
use Doctrine\Tests\Annotations\Metadata\Type\PropertyMetadataMother;
use PHPUnit\Framework\TestCase;

class PropertyMetadataTest extends TestCase
{
    /**
     * @param mixed $value
     *
     * @dataProvider validTypeValidationExamples
     */
    public function testValidatesValuesMatchingType(Type $type, $value) : void
    {
        $metadata = PropertyMetadataMother::withType($type);

        $metadata->validateValue($value);

        $this->assertTrue(true);
    }

    /**
     * @return mixed[]
     */
    public function validTypeValidationExamples() : iterable
    {
        yield 'valid string' => [

            new StringType(),
            'foo',
        ];
    }

    /**
     * @param mixed $value
     *
     * @dataProvider invalidTypeValidationExamples
     */
    public function testNotValidatesValuesNotMatchingTypeAndThrows(Type $type, $value) : void
    {
        $metadata = PropertyMetadataMother::withType($type);

        $this->expectException(InvalidPropertyValue::class);

        $metadata->validateValue($value);
    }

    /**
     * @return mixed[]
     */
    public function invalidTypeValidationExamples() : iterable
    {
        yield 'value not matching property type' => [

            new StringType(),
            42,
        ];
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Doctrine\Tests\Annotations\Metadata;
6
7			use Doctrine\Annotations\Metadata\InvalidPropertyValue;
8			use Doctrine\Annotations\Metadata\Type\StringType;
9			use Doctrine\Annotations\Metadata\Type\Type;
10			use Doctrine\Tests\Annotations\Metadata\Type\PropertyMetadataMother;
11			use PHPUnit\Framework\TestCase;
12
13			class PropertyMetadataTest extends TestCase
14			{
15			/**
16			* @param mixed $value
17			*
18			* @dataProvider validTypeValidationExamples
19			*/
20			public function testValidatesValuesMatchingType(Type $type, $value) : void
21			{
22			$metadata = PropertyMetadataMother::withType($type);
23
24			$metadata->validateValue($value);
25
26			$this->assertTrue(true);
27			}
28
29			/**
30			* @return mixed[]
31			*/
32			public function validTypeValidationExamples() : iterable
33			{
34			yield 'valid string' => [
			0 ignored issues – show Bug Best Practice introduced 2018-10-24 17:08 UTC by Report Bug Copy Issue Report The expression `yield 'valid string' => ...pe\StringType(), 'foo')` returns the type `Generator` which is incompatible with the documented return type `array<mixed,mixed>`. Loading history...
35			new StringType(),
36			'foo',
37			];
38			}
39
40			/**
41			* @param mixed $value
42			*
43			* @dataProvider invalidTypeValidationExamples
44			*/
45			public function testNotValidatesValuesNotMatchingTypeAndThrows(Type $type, $value) : void
46			{
47			$metadata = PropertyMetadataMother::withType($type);
48
49			$this->expectException(InvalidPropertyValue::class);
50
51			$metadata->validateValue($value);
52			}
53
54			/**
55			* @return mixed[]
56			*/
57			public function invalidTypeValidationExamples() : iterable
58			{
59			yield 'value not matching property type' => [
			0 ignored issues – show Bug Best Practice introduced 2018-10-24 17:08 UTC by Report Bug Copy Issue Report The expression `yield 'value not matchin...\Type\StringType(), 42)` returns the type `Generator` which is incompatible with the documented return type `array<mixed,mixed>`. Loading history...
60			new StringType(),
61			42,
62			];
63			}
64			}
65

Majkl578 / doctrine-annotations

Pull Request — new-parser-ast-metadata (#3)

testNotValidatesValuesNotMatchingTypeAndThrows() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like