Majkl578 /
doctrine-annotations
| Conditions | 4 |
| Paths | 1 |
| Total Lines | 78 |
| Code Lines | 49 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 61 | public function docBlocksProvider() : iterable |
||
| 62 | { |
||
| 63 | yield 'single without parameters' => [ |
||
| 64 | new Annotations( |
||
| 65 | new Annotation( |
||
| 66 | new Reference('Foo', true), |
||
| 67 | new Parameters() |
||
| 68 | ) |
||
| 69 | ), |
||
| 70 | function (AnnotationMetadataAssembler $assembler) : void { |
||
| 71 | $assembler->method('assemble') |
||
|
|
|||
| 72 | ->with( |
||
| 73 | $this->callback(static function (Reference $reference) : bool { |
||
| 74 | return $reference->getIdentifier() === 'Foo' && $reference->isFullyQualified() === true; |
||
| 75 | }), |
||
| 76 | $this->isInstanceOf(Scope::class) |
||
| 77 | ) |
||
| 78 | ->willReturn(new AnnotationMetadata( |
||
| 79 | 'Foo', |
||
| 80 | new AnnotationTarget(AnnotationTarget::TARGET_ALL), |
||
| 81 | false, |
||
| 82 | [] |
||
| 83 | )); |
||
| 84 | }, |
||
| 85 | static function (AnnotationMetadata ...$metadatas) : void { |
||
| 86 | self::assertCount(1, $metadatas); |
||
| 87 | self::assertSame('Foo', $metadatas[0]->getName()); |
||
| 88 | }, |
||
| 89 | ]; |
||
| 90 | yield 'nested' => [ |
||
| 91 | new Annotations( |
||
| 92 | new Annotation( |
||
| 93 | new Reference('Foo', true), |
||
| 94 | new Parameters( |
||
| 95 | new UnnamedParameter( |
||
| 96 | new Annotation( |
||
| 97 | new Reference('Bar', false), |
||
| 98 | new Parameters() |
||
| 99 | ) |
||
| 100 | ) |
||
| 101 | ) |
||
| 102 | ) |
||
| 103 | ), |
||
| 104 | function (AnnotationMetadataAssembler $assembler) : void { |
||
| 105 | $assembler->method('assemble') |
||
| 106 | ->withConsecutive( |
||
| 107 | [ |
||
| 108 | $this->callback(static function (Reference $reference) : bool { |
||
| 109 | return $reference->getIdentifier() === 'Bar' && $reference->isFullyQualified() === false; |
||
| 110 | }), |
||
| 111 | $this->isInstanceOf(Scope::class), |
||
| 112 | ], |
||
| 113 | [ |
||
| 114 | $this->callback(static function (Reference $reference) : bool { |
||
| 115 | return $reference->getIdentifier() === 'Foo' && $reference->isFullyQualified() === true; |
||
| 116 | }), |
||
| 117 | $this->isInstanceOf(Scope::class), |
||
| 118 | ] |
||
| 119 | ) |
||
| 120 | ->willReturnOnConsecutiveCalls( |
||
| 121 | new AnnotationMetadata( |
||
| 122 | 'Bar', |
||
| 123 | new AnnotationTarget(AnnotationTarget::TARGET_ALL), |
||
| 124 | false, |
||
| 125 | [] |
||
| 126 | ), |
||
| 127 | new AnnotationMetadata( |
||
| 128 | 'Foo', |
||
| 129 | new AnnotationTarget(AnnotationTarget::TARGET_ALL), |
||
| 130 | false, |
||
| 131 | [] |
||
| 132 | ) |
||
| 133 | ); |
||
| 134 | }, |
||
| 135 | static function (AnnotationMetadata ...$metadatas) : void { |
||
| 136 | self::assertCount(2, $metadatas); |
||
| 137 | self::assertSame('Bar', $metadatas[0]->getName()); |
||
| 138 | self::assertSame('Foo', $metadatas[1]->getName()); |
||
| 139 | }, |
||
| 143 |
This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces.
This is most likely a typographical error or the method has been renamed.