MapType::validate() - Code Metrics - Inspection of "wip" - Majkl578/doctrine-annotations - Measure and Improve Code Quality continuously with Scrutinizer

Failed Conditions

Push — type ( 257e93...5997a7 )

by Michael

created 2019-03-06 16:20 UTC

MapType::validate() A

↳ Parent: MapType

Complexity

Conditions	5
Paths	5

Size

Total Lines	17
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	30

Importance

Changes

Metric	Value
eloc	8
dl	0
loc	17
ccs	0
cts	14
cp	0
rs	9.6111
c	0
b	0
f	0
cc	5
nc	5
nop	1
crap	30

<?php

declare(strict_types=1);

namespace Doctrine\Annotations\Type;

use function assert;
use function is_array;
use function sprintf;

/**
 * @internal
 */
class MapType implements Type
{
    /** @var ScalarType|UnionType */
    private $keyType;

    /** @var Type */
    private $valueType;

    public function __construct(Type $keyType, Type $valueType)
    {
        assert(
            $keyType instanceof ScalarType || $keyType instanceof UnionType,
            sprintf('Invalid key type %s', $keyType->describe())
        );

        $this->keyType   = $keyType;
        $this->valueType = $valueType;
    }

    public function getKeyType() : ScalarType
    {
        return $this->keyType;

    }

    public function getValueType() : Type
    {
        return $this->valueType;
    }

    public function describe() : string
    {
        return sprintf('array<%s, %s>', $this->keyType->describe(), $this->valueType->describe());
    }

    /**
     * @param mixed $value
     */
    public function validate($value) : bool
    {
        if (! is_array($value)) {
            return false;
        }

        foreach ($value as $key => $innerValue) {
            if (! $this->keyType->validate($key)) {
                return false;
            }

            if (! $this->valueType->validate($innerValue)) {
                return false;
            }
        }

        return true;
    }

    public function acceptsNull() : bool
    {
        return $this->valueType->acceptsNull();
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Doctrine\Annotations\Type;
6
7			use function assert;
8			use function is_array;
9			use function sprintf;
10
11			/**
12			* @internal
13			*/
14			class MapType implements Type
15			{
16			/** @var ScalarType\|UnionType */
17			private $keyType;
18
19			/** @var Type */
20			private $valueType;
21
22			public function __construct(Type $keyType, Type $valueType)
23			{
24			assert(
25			$keyType instanceof ScalarType \|\| $keyType instanceof UnionType,
26			sprintf('Invalid key type %s', $keyType->describe())
27			);
28
29			$this->keyType = $keyType;
30			$this->valueType = $valueType;
31			}
32
33			public function getKeyType() : ScalarType
34			{
35			return $this->keyType;
			0 ignored issues – show Bug Best Practice introduced 2019-03-06 16:23 UTC by Report Bug Copy Issue Report The expression `return $this->keyType` could return the type `Doctrine\Annotations\Type\UnionType` which is incompatible with the type-hinted return `Doctrine\Annotations\Type\ScalarType`. Consider adding an additional type-check to rule them out. Loading history...
36			}
37
38			public function getValueType() : Type
39			{
40			return $this->valueType;
41			}
42
43			public function describe() : string
44			{
45			return sprintf('array<%s, %s>', $this->keyType->describe(), $this->valueType->describe());
46			}
47
48			/**
49			* @param mixed $value
50			*/
51			public function validate($value) : bool
52			{
53			if (! is_array($value)) {
54			return false;
55			}
56
57			foreach ($value as $key => $innerValue) {
58			if (! $this->keyType->validate($key)) {
59			return false;
60			}
61
62			if (! $this->valueType->validate($innerValue)) {
63			return false;
64			}
65			}
66
67			return true;
68			}
69
70			public function acceptsNull() : bool
71			{
72			return $this->valueType->acceptsNull();
73			}
74			}
75

Majkl578 / doctrine-annotations

Push — type ( 257e93...5997a7 )

MapType::validate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like