Doctrine\Tests\Annotations\Metadata\Type\MixedTypeTest

Complexity

Total Complexity

5

Size/Duplication

Total Lines	41
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	createType()	0	3	1
A	testDescribe()	0	3	1
A	invalidValidateValuesProvider()	0	6	1
A	testAcceptsNull()	0	3	1
A	validValidateValuesProvider()	0	9	1

<?php

declare(strict_types=1);

namespace Doctrine\Tests\Annotations\Metadata\Type;

use Doctrine\Annotations\Metadata\Type\MixedType;
use Doctrine\Annotations\Metadata\Type\Type;
use stdClass;
use function fclose;
use function fopen;

final class MixedTypeTest extends TypeTest
{
    protected function createType() : Type
    {
        return new MixedType();
    }

    public function testDescribe() : void
    {
        self::assertSame('mixed', $this->getType()->describe());
    }

    /**
     * @return mixed[]
     */
    public function validValidateValuesProvider() : iterable
    {
        yield [null];

The expression yield array(null) returns the type Generator which is incompatible with the documented return type array<mixed,mixed>.

        yield [true];
        yield [123];
        yield [1.234];
        yield ['hello'];
        yield [[123]];
        yield [new stdClass()];
    }

    /**
     * @return resource[][]
     */
    public function invalidValidateValuesProvider() : iterable
    {
        try {
            yield [$f = fopen(__FILE__, 'r')];

The expression yield array($f = fopen(__FILE__, 'r')) returns the type Generator which is incompatible with the documented return type array<mixed,array<mixed,resource>>.

        } finally {
            @fclose($f);

It seems like you do not handle an error condition for fclose(). This can introduce security issues, and is generally not recommended.

It seems like $f can also be of type false; however, parameter $handle of fclose() does only seem to accept resource, maybe add an additional type check?

        }
    }

    public function testAcceptsNull() : void
    {
        self::assertTrue($this->getType()->acceptsNull());
    }
}