FormBelegungsplanCategorySelect::parse() - Code Metrics - Inspection of "Create FormBelegungsplanCategorySelect.php" - Mailwurm/belegungsplan-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( be4565...88ca1d )

by Jan

created 2017-12-13 08:30 UTC

FormBelegungsplanCategorySelect::parse() B

↳ Parent: FormBelegungsplanCategorySelect

Complexity

Conditions	5
Paths	12

Size

Total Lines	25
Code Lines	12

Duplication

Lines	10
Ratio	40 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	5
eloc	12
c	1
b	0
f	0
nc	12
nop	1
dl	10
loc	25
rs	8.439

<?php
/**
* Contao Open Source CMS
*
* Copyright (c) Jan Karai
*
* @license LGPL-3.0+
*/
namespace Mailwurm\Belegung;

/**
 * Class FormBelegungsplanCategorySelect
 *
 * @property integer $mSize
 * @property boolean $mandatory
 * @property boolean $multiple
 * @property array   $options
 * @property boolean $chosen
 *
 * @author Jan Karai <https://www.sachsen-it.de>
 */
class FormBelegungsplanCategorySelect extends \Widget
{
  /**
  * Template
  *
  * @var string
  */
  protected $strTemplate = 'form_belegungsplancategoryselect';
  
  /**
  * The CSS class prefix
  *
  * @var string
  */
  protected $strPrefix = 'widget widget-select';

  /**
  * Add specific attributes
  *
  * @param string $strKey   The attribute name
  * @param mixed  $varValue The attribute value
  */
	public function __set($strKey, $varValue)
	{
		switch ($strKey)
		{
			case 'mandatory':
				if ($varValue)
				{
					$this->arrAttributes['required'] = 'required';
				}
				else
				{
					unset($this->arrAttributes['required']);
				}
				parent::__set($strKey, $varValue);
				break;
			case 'multiple':
				if ($varValue != '')
				{
					$this->arrAttributes['multiple'] = 'multiple';
				}
				break;
			case 'options':
				$this->arrOptions = \StringUtil::deserialize($varValue);
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
				break;
			case 'rgxp':
			case 'minlength':
			case 'maxlength':
				// Ignore
				break;
			default:
				parent::__set($strKey, $varValue);
				break;
		}
	}
  
  /**
  * Check options if the field is mandatory
  */
	public function validate()
	{
		$mandatory = $this->mandatory;
		$options = $this->getPost($this->strName);
		// Check if there is at least one value
		if ($mandatory && is_array($options))
		{
			foreach ($options as $option)
			{
				if (strlen($option))
				{
					$this->mandatory = false;
					break;
				}
			}
		}
		$varInput = $this->validator($options);
		// Check for a valid option (see #4383)
		if (!empty($varInput) && !$this->isValidOption($varInput))
		{
			$this->addError($GLOBALS['TL_LANG']['ERR']['invalid']);
		}
		// Add class "error"
		if ($this->hasErrors())
		{
			$this->class = 'error';
		}
		else
		{
			$this->varValue = $varInput;
		}
		// Reset the property
		if ($mandatory)
		{
			$this->mandatory = true;
		}
	}
  
  /**
  * Return a parameter
  *
  * @param string $strKey The parameter name
  *
  * @return mixed The parameter value
  */
	public function __get($strKey)
	{
		if ($strKey == 'options')
		{
			return $this->arrOptions;
		}
		return parent::__get($strKey);
	}
  
  /**
  * Parse the template file and return it as string
  *
  * @param array $arrAttributes An optional attributes array
  *
  * @return string The template markup
  */
	public function parse($arrAttributes=null)
	{
		$strClass = 'select';
		if ($this->multiple)

		{
			$this->strName .= '[]';
			$strClass = 'multiselect';
		}
		// Make sure there are no multiple options in single mode
		elseif (is_array($this->varValue))
		{
			$this->varValue = $this->varValue[0];
		}
		// Chosen
		if ($this->chosen)
		{
			$strClass .= ' tl_chosen';
		}
		// Custom class
		if ($this->strClass != '')
		{
			$strClass .= ' ' . $this->strClass;
		}
		$this->strClass = $strClass;
		return parent::parse($arrAttributes);
	}
  
  /**
  * Generate the options
  *
  * @return array The options array
  */
	protected function getOptions()
	{
		$arrOptions = array();
		// Add empty option if there are none
		if (empty($this->arrOptions) || !is_array($this->arrOptions))

		{
			$this->arrOptions = array(array('value' => '', 'label' => '-'));
		}
		// Generate options
		foreach ($this->arrOptions as $arrOption)
		{
			  $arrOptions[] = array_replace
				(
					$arrOption,
					array
					(
						'type'     => 'option',
						'value'    => $arrOption['value'],
						'selected' => $this->isSelected($arrOption),
						'label'    => $arrOption['label'],
					)
				);
		}
		return $arrOptions;
	}
  
  /**
  * Generate the widget and return it as string
  *
  * @return string The widget markup
  */
	public function generate()
	{
		$strOptions = '';
		
		if ($this->multiple)

		{
			$this->strName .= '[]';
		}
		// Make sure there are no multiple options in single mode
		elseif (is_array($this->varValue))
		{
			$this->varValue = $this->varValue[0];
		}
		// Add empty option if there are none
		if (empty($this->arrOptions) || !is_array($this->arrOptions))

		{
			$this->arrOptions = array(array('value'=>'', 'label'=>'-'));
		}
		foreach ($this->arrOptions as $arrOption)
		{
			$strOptions .= sprintf('<option value="%s"%s>%s</option>',
									$arrOption['value'],
									$this->isSelected($arrOption),
									$arrOption['label']);
		}
		
		return sprintf('<select name="%s" id="ctrl_%s" class="%s"%s>%s</select>',
						$this->strName,
						$this->strId,
						$this->class,
						$this->getAttributes(),
						$strOptions);
	}
}


1		<?php
2		/**
3		* Contao Open Source CMS
4		*
5		* Copyright (c) Jan Karai
6		*
7		* @license LGPL-3.0+
8		*/
9		namespace Mailwurm\Belegung;
10
11		/**
12		* Class FormBelegungsplanCategorySelect
13		*
14		* @property integer $mSize
15		* @property boolean $mandatory
16		* @property boolean $multiple
17		* @property array $options
18		* @property boolean $chosen
19		*
20		* @author Jan Karai <https://www.sachsen-it.de>
21		*/
22		class FormBelegungsplanCategorySelect extends \Widget
23		{
24		/**
25		* Template
26		*
27		* @var string
28		*/
29		protected $strTemplate = 'form_belegungsplancategoryselect';
30
31		/**
32		* The CSS class prefix
33		*
34		* @var string
35		*/
36		protected $strPrefix = 'widget widget-select';
37
38		/**
39		* Add specific attributes
40		*
41		* @param string $strKey The attribute name
42		* @param mixed $varValue The attribute value
43		*/
44		public function __set($strKey, $varValue)
45		{
46		switch ($strKey)
47		{
48		case 'mandatory':
49		if ($varValue)
50		{
51		$this->arrAttributes['required'] = 'required';
52		}
53		else
54		{
55		unset($this->arrAttributes['required']);
56		}
57		parent::__set($strKey, $varValue);
58		break;
59		case 'multiple':
60		if ($varValue != '')
61		{
62		$this->arrAttributes['multiple'] = 'multiple';
63		}
64		break;
65		case 'options':
66		$this->arrOptions = \StringUtil::deserialize($varValue);
		0 ignored issues – show Documentation Bug introduced 2017-12-13 08:36 UTC by Report Bug Copy Issue Report It seems like `StringUtil::deserialize($varValue)` can also be of type `string`. However, the property `$arrOptions` is declared as type `array`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
67		break;
68		case 'rgxp':
69		case 'minlength':
70		case 'maxlength':
71		// Ignore
72		break;
73		default:
74		parent::__set($strKey, $varValue);
75		break;
76		}
77		}
78
79		/**
80		* Check options if the field is mandatory
81		*/
82		public function validate()
83		{
84		$mandatory = $this->mandatory;
85		$options = $this->getPost($this->strName);
86		// Check if there is at least one value
87		if ($mandatory && is_array($options))
88		{
89		foreach ($options as $option)
90		{
91		if (strlen($option))
92		{
93		$this->mandatory = false;
94		break;
95		}
96		}
97		}
98		$varInput = $this->validator($options);
99		// Check for a valid option (see #4383)
100		if (!empty($varInput) && !$this->isValidOption($varInput))
101		{
102		$this->addError($GLOBALS['TL_LANG']['ERR']['invalid']);
103		}
104		// Add class "error"
105		if ($this->hasErrors())
106		{
107		$this->class = 'error';
108		}
109		else
110		{
111		$this->varValue = $varInput;
112		}
113		// Reset the property
114		if ($mandatory)
115		{
116		$this->mandatory = true;
117		}
118		}
119
120		/**
121		* Return a parameter
122		*
123		* @param string $strKey The parameter name
124		*
125		* @return mixed The parameter value
126		*/
127		public function __get($strKey)
128		{
129		if ($strKey == 'options')
130		{
131		return $this->arrOptions;
132		}
133		return parent::__get($strKey);
134		}
135
136		/**
137		* Parse the template file and return it as string
138		*
139		* @param array $arrAttributes An optional attributes array
140		*
141		* @return string The template markup
142		*/
143		public function parse($arrAttributes=null)
144		{
145		$strClass = 'select';
146	View Code Duplication	if ($this->multiple)
		0 ignored issues – show Duplication introduced 2017-12-13 08:36 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
147		{
148		$this->strName .= '[]';
149		$strClass = 'multiselect';
150		}
151		// Make sure there are no multiple options in single mode
152		elseif (is_array($this->varValue))
153		{
154		$this->varValue = $this->varValue[0];
155		}
156		// Chosen
157		if ($this->chosen)
158		{
159		$strClass .= ' tl_chosen';
160		}
161		// Custom class
162		if ($this->strClass != '')
163		{
164		$strClass .= ' ' . $this->strClass;
165		}
166		$this->strClass = $strClass;
167		return parent::parse($arrAttributes);
168		}
169
170		/**
171		* Generate the options
172		*
173		* @return array The options array
174		*/
175		protected function getOptions()
176		{
177		$arrOptions = array();
178		// Add empty option if there are none
179	View Code Duplication	if (empty($this->arrOptions) \|\| !is_array($this->arrOptions))
		0 ignored issues – show Duplication introduced 2017-12-13 08:36 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
180		{
181		$this->arrOptions = array(array('value' => '', 'label' => '-'));
182		}
183		// Generate options
184		foreach ($this->arrOptions as $arrOption)
185		{
186		$arrOptions[] = array_replace
187		(
188		$arrOption,
189		array
190		(
191		'type' => 'option',
192		'value' => $arrOption['value'],
193		'selected' => $this->isSelected($arrOption),
194		'label' => $arrOption['label'],
195		)
196		);
197		}
198		return $arrOptions;
199		}
200
201		/**
202		* Generate the widget and return it as string
203		*
204		* @return string The widget markup
205		*/
206		public function generate()
207		{
208		$strOptions = '';
209
210	View Code Duplication	if ($this->multiple)
		0 ignored issues – show Duplication introduced 2017-12-13 08:36 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
211		{
212		$this->strName .= '[]';
213		}
214		// Make sure there are no multiple options in single mode
215		elseif (is_array($this->varValue))
216		{
217		$this->varValue = $this->varValue[0];
218		}
219		// Add empty option if there are none
220	View Code Duplication	if (empty($this->arrOptions) \|\| !is_array($this->arrOptions))
		0 ignored issues – show Duplication introduced 2017-12-13 08:36 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
221		{
222		$this->arrOptions = array(array('value'=>'', 'label'=>'-'));
223		}
224		foreach ($this->arrOptions as $arrOption)
225		{
226		$strOptions .= sprintf('<option value="%s"%s>%s</option>',
227		$arrOption['value'],
228		$this->isSelected($arrOption),
229		$arrOption['label']);
230		}
231
232		return sprintf('<select name="%s" id="ctrl_%s" class="%s"%s>%s</select>',
233		$this->strName,
234		$this->strId,
235		$this->class,
236		$this->getAttributes(),
237		$strOptions);
238		}
239		}
240

Mailwurm / belegungsplan-bundle

GitHub Access Token became invalid

Push — master ( be4565...88ca1d )

FormBelegungsplanCategorySelect::parse() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like