Malm18\IPChecker\IPHandler::checkIP()

Complexity

Conditions	2
Paths	2

Size

Total Lines	26
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	4
CRAP Score	3.4578

Importance

Changes	1
Bugs	0	Features	0

<?php
    public function checkIP($theIP)
    {
        if (filter_var($theIP, FILTER_VALIDATE_IP)) {
            $url = 'http://api.ipstack.com/';
            $keys = require ANAX_INSTALL_PATH . "/config/keys.php";
            // $this->ipstackKey = $keys["ipstackKey"];
            // $apiKey = $this->ipstackKey;
            $apiKey = $keys["ipstackKey"];
            $requestUrl = $url . $theIP . '?access_key=' . $apiKey;
            $curl = curl_init($requestUrl);
            curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);

It seems like $curl can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

        // curl_setopt($curl, CURLOPT_HTTPHEADER, [
        //   'X-RapidAPI-Host: kvstore.p.rapidapi.com',
        //   'X-RapidAPI-Key: 7xxxxxxxxxxxxxxxxxxxxxxx',
        //   'Content-Type: application/json'
        // ]);
            $response = curl_exec($curl);

It seems like $curl can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

            $response2 = json_decode($response, true);
            curl_close($curl);

It seems like $curl can also be of type false; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

            // echo $response . PHP_EOL;
            return $response2;
        } else {
            $response = array("type" => "not valid ip", "ip" => "", "latitude"=> "", "longitude"=> "",
            "city" => "", "country_name" => "", "region_name" => "", "continent_name" => "", "location['country_code']" => "");
            // $response2 = json_decode($response, true);
            return $response;
        }