Malm18\Vader\VaderHandler::checkWeather()

Complexity

Conditions	6
Paths	9

Size

Total Lines	88
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	38
CRAP Score	6

Importance

Changes	2
Bugs	0	Features	0

<?php
    public function checkWeather($latitude, $longitude, $pastOrFuture)
    {

        $url1 = 'https://api.darksky.net/forecast/';

        $keys = require ANAX_INSTALL_PATH . "/config/keys.php";
        $apiKey = $keys["darkskyKey"];
        $endStuff = '?exclude=minutely,hourly,currently,alerts,flags&extend=daily&lang=sv&units=si';

        if ($pastOrFuture == "future") {
            $requestUrl = $url1 . $apiKey . "/" . $latitude . "," . $longitude . $endStuff;
            // $requestUrl = 'https://nominatim.openstreetmap.org/?format=json&addressdetails=1&q=bakery+in+berlin+wedding&format=json&limit=1&email=a@b.se';
            $curl = curl_init($requestUrl);
            // if ($curl) {
            curl_setopt($curl, CURLOPT_RETURNTRANSFER, true);

It seems like $curl can also be of type false; however, parameter $ch of curl_setopt() does only seem to accept resource, maybe add an additional type check?

        // curl_setopt($curl, CURLOPT_HTTPHEADER, [
        //   'X-RapidAPI-Host: kvstore.p.rapidapi.com',
        //   'X-RapidAPI-Key: 7xxxxxxxxxxxxxxxxxxxxxxx',
        //   'Content-Type: application/json'
        // ]);
            $response = curl_exec($curl);

It seems like $curl can also be of type false; however, parameter $ch of curl_exec() does only seem to accept resource, maybe add an additional type check?

            $response2 = json_decode($response, true);
            curl_close($curl);

It seems like $curl can also be of type false; however, parameter $ch of curl_close() does only seem to accept resource, maybe add an additional type check?

            // $coordinates['latitude'] = $response2[0]['lat'];
            // $coordinates['longitude'] = $response2[0]['lon'];
            // echo $response . PHP_EOL;
            return $response2['daily']['data'];
        // }
        } else {
        // array of curl handles
            $multiCurl = array();
            // data to be returned
            $response = array();
            // multi handle
            $mhbutlonger = curl_multi_init();




        // for ($i=0; $i < 30; $i++) {
        //     $unixTime = time() - ($i * 24 * 60 * 60);
        //     $multiRequests[] = $url1 . $apiKey . "/" . $latitude . "," . $longitude . ','.$unixTime . $endStuff;
        // }





            for ($i = 0; $i < 30; $i++) {
                $unixTime = time() - ($i * 24 * 60 * 60);
                $requestUrl = $url1 . $apiKey . "/" . $latitude . "," . $longitude . ',' . $unixTime . $endStuff;
                $multiCurl[$i] = curl_init();
                curl_setopt($multiCurl[$i], CURLOPT_URL, $requestUrl);
                curl_setopt($multiCurl[$i], CURLOPT_HEADER, 0);
                curl_setopt($multiCurl[$i], CURLOPT_RETURNTRANSFER, 1);
                curl_multi_add_handle($mhbutlonger, $multiCurl[$i]);
            }
            $index = null;
            do {
                curl_multi_exec($mhbutlonger, $index);
            } while ($index > 0);
        // get content and remove handles
            foreach ($multiCurl as $k => $ch) {
                $response[$k] = curl_multi_getcontent($ch);
                curl_multi_remove_handle($mhbutlonger, $ch);
            }
            // close
            curl_multi_close($mhbutlonger);

            // $response2 = json_decode($response, true);

            // $daily = [];
            // $anArray = [];
            // $data = [];
            $data2 = [];
            $i = 0;
            foreach ($response as $item) {
                $data = json_decode($item, true);
                $data2[$i] = $data['daily']['data'][0];
                // $data[$i] = $item;
                $i = $i + 1;
            }
            // $daily['data'] = $data;
            // $anArray['daily'] = $daily;

            // return $data[0]['daily']['data'];
            // $response2 = json_decode($data, true);
            return $data2;
        }