Ps2alerts\Api\Controller\EndpointBaseController

Complexity

Total Complexity

2

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	6
Bugs	0	Features	2

1 Method

Rating	Name	Duplication	Size	Complexity
A	readSingle()	0	10	2

<?php

namespace Ps2alerts\Api\Controller;

use Symfony\Component\HttpFoundation\Request;
use League\Route\Http\JsonResponse as Response;
use Ps2alerts\Api\QueryObjects\QueryObject;

abstract class EndpointBaseController
{
    protected $loader;

    /**
     * Returns a single entry
     *
     * @param  Symfony\Component\HttpFoundation\Request $request
     * @param  array   $args
     *
     * @return \League\Route\Http\JsonResponse
     */
    public function readSingle(Request $request, array $args)

The parameter $request is not used and could be removed.

    {
        $return = $this->loader->readSingle($args['resultID']);

The method readSingle does only exist in Ps2alerts\Api\Loader\Metrics\MapInitialMetricsLoader and Ps2alerts\Api\Loader\Metrics\MapMetricsLoader and Ps2alerts\Api\Loader\Metrics\OutfitMetricsLoader and Ps2alerts\Api\Loader\ResultLoader, but not in Ps2alerts\Api\Loader\Statistics\OutfitTotalsMetricsLoader.

        if (empty($return)) {
            return new Response\NoContent();
        }

        return new Response\Ok($return);
    }
}