AlertEndpointController::getSingle() - Code Metrics - Inspection of "Linking it all together. Big ass file." - Maelstromeous/ps2alerts-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — staging ( 5f9089...8e7d49 )

by Matthew

created 2016-01-17 00:18 UTC

AlertEndpointController::getSingle() A

↳ Parent: AlertEndpointController

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	0
loc	10
rs	9.4285
cc	2
eloc	5
nc	2
nop	3

<?php

namespace Ps2alerts\Api\Controller\Endpoint;

use League\Fractal\Manager;
use Ps2alerts\Api\Controller\Endpoint\AbstractEndpointController;
use Ps2alerts\Api\Repository\AlertRepository;
use Ps2alerts\Api\Transformer\AlertTransformer;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;

class AlertEndpointController extends AbstractEndpointController
{
    public function __construct(
        AlertRepository  $repository,
        AlertTransformer $transformer,
        Manager          $fractal
    ) {
        $this->repository  = $repository;
        $this->transformer = $transformer;
        $this->fractal     = $fractal;

    }

    /**
     * Returns a single alert's information
     *
     * @see AbstractEndpointController::respondWithItem
     *
     * @param  Symfony\Component\HttpFoundation\Request  $request
     * @param  Symfony\Component\HttpFoundation\Response $response
     * @param  array
     *
     * @return array
     */
    public function getSingle(Request $request, Response $response, array $args)
    {
        $alert = $this->repository->readSingle($args['id']);

        if (empty($alert)) {
            return $this->errorEmpty($response);
        }

        return $this->respond('item', $alert, $this->transformer, $request, $response);
    }
}


1			<?php
2
3			namespace Ps2alerts\Api\Controller\Endpoint;
4
5			use League\Fractal\Manager;
6			use Ps2alerts\Api\Controller\Endpoint\AbstractEndpointController;
7			use Ps2alerts\Api\Repository\AlertRepository;
8			use Ps2alerts\Api\Transformer\AlertTransformer;
9			use Symfony\Component\HttpFoundation\Request;
10			use Symfony\Component\HttpFoundation\Response;
11
12			class AlertEndpointController extends AbstractEndpointController
13			{
14			public function __construct(
15			AlertRepository $repository,
16			AlertTransformer $transformer,
17			Manager $fractal
18			) {
19			$this->repository = $repository;
20			$this->transformer = $transformer;
21			$this->fractal = $fractal;
			0 ignored issues – show Documentation Bug introduced 2016-01-17 00:22 UTC by Report Bug Copy Issue Report It seems like `$fractal` of type `object<League\Fractal\Manager>` is incompatible with the declared type `object<League\Fractal>` of property `$fractal`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
22			}
23
24			/**
25			* Returns a single alert's information
26			*
27			* @see AbstractEndpointController::respondWithItem
28			*
29			* @param Symfony\Component\HttpFoundation\Request $request
30			* @param Symfony\Component\HttpFoundation\Response $response
31			* @param array
32			*
33			* @return array
34			*/
35			public function getSingle(Request $request, Response $response, array $args)
36			{
37			$alert = $this->repository->readSingle($args['id']);
38
39			if (empty($alert)) {
40			return $this->errorEmpty($response);
41			}
42
43			return $this->respond('item', $alert, $this->transformer, $request, $response);
44			}
45			}
46

Maelstromeous / ps2alerts-api

Push — staging ( 5f9089...8e7d49 )

AlertEndpointController::getSingle() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like