AlertControllerTest::testAlertReturnsBody() - Code Metrics - Inspection of "Linking it all together. Big ass file." - Maelstromeous/ps2alerts-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — staging ( 5f9089...8e7d49 )

by Matthew

created 2016-01-17 00:18 UTC

AlertControllerTest::testAlertReturnsBody() A

↳ Parent: AlertControllerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	5

Duplication

Lines	8
Ratio	100 %

Metric	Value
dl	8
loc	8
rs	9.4285
cc	1
eloc	5
nc	1
nop	0

<?php

use GuzzleHttp\Client;
use GuzzleHttp\Psr7\Request;
use GuzzleHttp\Psr7\Response;

class AlertControllerTest extends \PHPUnit_Framework_TestCase
namespace YourVendor;

class YourClass { }
{
    public function testAlertReturnsCorrectNonEmptyHttpCode()

    {
        $client = new Client();
        $response = $client->request('GET', 'http://192.168.33.10/ps2alerts-api/public/v2/alerts/10000');

        $this->assertEquals(200, $response->getStatusCode());
        $data = json_decode($response->getBody(true), true);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    public function testAlertHandlesEmptyData()
    {
        $client = new Client();
        $response = $client->request(
            'GET',
            'http://192.168.33.10/ps2alerts-api/public/v2/alerts/1',
            ['http_errors' => false]
        );

        $this->assertEquals(404, $response->getStatusCode());
        $this->assertTrue($response->hasHeader('Content-Type'));
        $data = json_decode($response->getBody(true), true);


        $this->assertArrayHasKey('error', $data);
        $this->assertArrayHasKey('code', $data['error']);
        $this->assertArrayHasKey('http_code', $data['error']);
        $this->assertArrayHasKey('message', $data['error']);
    }

    public function testAlertReturnsBody()

    {
        $client = new Client();
        $response = $client->request('GET', 'http://192.168.33.10/ps2alerts-api/public/v2/alerts/10000');

        $this->assertEquals(200, $response->getStatusCode());
        $data = json_decode($response->getBody(true), true);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
    }

    public function testAlertReturnsJsonHeaders()
    {
        $client = new Client();
        $response = $client->request('GET', 'http://192.168.33.10/ps2alerts-api/public/v2/alerts/10000');

        $this->assertTrue($response->hasHeader('Content-Type'));
        $this->assertEquals('application/json', $response->getHeader('Content-Type')[0]);
    }

    public function testAlertReturnsAnyData()
    {
        $client = new Client();
        $response = $client->request('GET', 'http://192.168.33.10/ps2alerts-api/public/v2/alerts/10000');

        $this->assertEquals(200, $response->getStatusCode());
        $this->assertTrue($response->hasHeader('Content-Type'));
        $data = json_decode($response->getBody(true), true);

        $this->assertArrayHasKey('data', $data);
        $this->assertArrayHasKey('id', $data['data']);
    }

    public function testAlertReturnsExpectedData()
    {
        $client = new Client();
        $response = $client->request('GET', 'http://192.168.33.10/ps2alerts-api/public/v2/alerts/10000');

        $this->assertEquals(200, $response->getStatusCode());
        $this->assertTrue($response->hasHeader('Content-Type'));
        $data = json_decode($response->getBody(true), true);


        $this->assertArrayHasKey('data', $data);
        $this->assertArrayHasKey('id', $data['data']);
        $this->assertArrayHasKey('started', $data['data']);
        $this->assertArrayHasKey('ended', $data['data']);
        $this->assertArrayHasKey('server', $data['data']);
        $this->assertArrayHasKey('zone', $data['data']);
        $this->assertArrayHasKey('winner', $data['data']);
        $this->assertArrayHasKey('isDraw', $data['data']);
        $this->assertArrayHasKey('isDomination', $data['data']);
        $this->assertArrayHasKey('isValid', $data['data']);
        $this->assertArrayHasKey('inProgress', $data['data']);
    }
}


1		<?php
2
3		use GuzzleHttp\Client;
4		use GuzzleHttp\Psr7\Request;
5		use GuzzleHttp\Psr7\Response;
6
7		class AlertControllerTest extends \PHPUnit_Framework_TestCase
		0 ignored issues – show Coding Style Compatibility introduced 2016-01-17 00:22 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
8		{
9	View Code Duplication	public function testAlertReturnsCorrectNonEmptyHttpCode()
		0 ignored issues – show Duplication introduced 2016-01-17 00:22 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
10		{
11		$client = new Client();
12		$response = $client->request('GET', 'http://192.168.33.10/ps2alerts-api/public/v2/alerts/10000');
13
14		$this->assertEquals(200, $response->getStatusCode());
15		$data = json_decode($response->getBody(true), true);
		0 ignored issues – show Unused Code introduced 2016-01-17 00:22 UTC by Report Bug Copy Issue Report The call to `ResponseInterface::getBody()` has too many arguments starting with `true`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history... Unused Code introduced 2016-01-17 00:22 UTC by Report Bug Copy Issue Report `$data` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
16		}
17
18		public function testAlertHandlesEmptyData()
19		{
20		$client = new Client();
21		$response = $client->request(
22		'GET',
23		'http://192.168.33.10/ps2alerts-api/public/v2/alerts/1',
24		['http_errors' => false]
25		);
26
27		$this->assertEquals(404, $response->getStatusCode());
28		$this->assertTrue($response->hasHeader('Content-Type'));
29		$data = json_decode($response->getBody(true), true);
		0 ignored issues – show Unused Code introduced 2016-01-17 00:22 UTC by Report Bug Copy Issue Report The call to `ResponseInterface::getBody()` has too many arguments starting with `true`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
30
31		$this->assertArrayHasKey('error', $data);
32		$this->assertArrayHasKey('code', $data['error']);
33		$this->assertArrayHasKey('http_code', $data['error']);
34		$this->assertArrayHasKey('message', $data['error']);
35		}
36
37	View Code Duplication	public function testAlertReturnsBody()
		0 ignored issues – show Duplication introduced 2016-01-17 00:22 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
38		{
39		$client = new Client();
40		$response = $client->request('GET', 'http://192.168.33.10/ps2alerts-api/public/v2/alerts/10000');
41
42		$this->assertEquals(200, $response->getStatusCode());
43		$data = json_decode($response->getBody(true), true);
		0 ignored issues – show Unused Code introduced 2016-01-17 00:22 UTC by Report Bug Copy Issue Report The call to `ResponseInterface::getBody()` has too many arguments starting with `true`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history... Unused Code introduced 2016-01-17 00:22 UTC by Report Bug Copy Issue Report `$data` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
44		}
45
46		public function testAlertReturnsJsonHeaders()
47		{
48		$client = new Client();
49		$response = $client->request('GET', 'http://192.168.33.10/ps2alerts-api/public/v2/alerts/10000');
50
51		$this->assertTrue($response->hasHeader('Content-Type'));
52		$this->assertEquals('application/json', $response->getHeader('Content-Type')[0]);
53		}
54
55		public function testAlertReturnsAnyData()
56		{
57		$client = new Client();
58		$response = $client->request('GET', 'http://192.168.33.10/ps2alerts-api/public/v2/alerts/10000');
59
60		$this->assertEquals(200, $response->getStatusCode());
61		$this->assertTrue($response->hasHeader('Content-Type'));
62		$data = json_decode($response->getBody(true), true);
		0 ignored issues – show Unused Code introduced 2016-01-17 00:22 UTC by Report Bug Copy Issue Report The call to `ResponseInterface::getBody()` has too many arguments starting with `true`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
63		$this->assertArrayHasKey('data', $data);
64		$this->assertArrayHasKey('id', $data['data']);
65		}
66
67		public function testAlertReturnsExpectedData()
68		{
69		$client = new Client();
70		$response = $client->request('GET', 'http://192.168.33.10/ps2alerts-api/public/v2/alerts/10000');
71
72		$this->assertEquals(200, $response->getStatusCode());
73		$this->assertTrue($response->hasHeader('Content-Type'));
74		$data = json_decode($response->getBody(true), true);
		0 ignored issues – show Unused Code introduced 2016-01-17 00:22 UTC by Report Bug Copy Issue Report The call to `ResponseInterface::getBody()` has too many arguments starting with `true`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
75
76		$this->assertArrayHasKey('data', $data);
77		$this->assertArrayHasKey('id', $data['data']);
78		$this->assertArrayHasKey('started', $data['data']);
79		$this->assertArrayHasKey('ended', $data['data']);
80		$this->assertArrayHasKey('server', $data['data']);
81		$this->assertArrayHasKey('zone', $data['data']);
82		$this->assertArrayHasKey('winner', $data['data']);
83		$this->assertArrayHasKey('isDraw', $data['data']);
84		$this->assertArrayHasKey('isDomination', $data['data']);
85		$this->assertArrayHasKey('isValid', $data['data']);
86		$this->assertArrayHasKey('inProgress', $data['data']);
87		}
88		}
89

Maelstromeous / ps2alerts-api

Push — staging ( 5f9089...8e7d49 )

AlertControllerTest::testAlertReturnsBody() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like