PlayerStatisticsEndpoint::readLeaderboard() - Code Metrics - Inspection of "Piss off CORS" - Maelstromeous/ps2alerts-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0cb788...5f9089 )

by Matthew

created 2015-12-29 15:44 UTC

PlayerStatisticsEndpoint::readLeaderboard() A

↳ Parent: PlayerStatisticsEndpoint

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	6

Duplication

Lines	12
Ratio	100 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	12
loc	12
rs	9.4286
cc	2
eloc	6
nc	2
nop	1

<?php

namespace Ps2alerts\Api\Controller\Statistics;

use League\Route\Http\JsonResponse as Response;
use Ps2alerts\Api\Controller\EndpointBaseController;
use Ps2alerts\Api\Loader\Statistics\PlayerStatisticsLoader;
use Symfony\Component\HttpFoundation\Request;

class PlayerStatisticsEndpoint extends EndpointBaseController

{
    /**
     * Construct
     *
     * @param \Ps2alerts\Api\Loader\Metrics\PlayerStatisticsLoader $loader
     */
    public function __construct(PlayerStatisticsLoader $loader)
    {
        $this->loader = $loader;
    }

    /**
     * Gets top players
     *
     * @param  \Symfony\Component\HttpFoundation\Request $request
     *
     * @return \League\Route\Http\JsonResponse
     */
    public function readLeaderboard(Request $request)
    {
        $post = $request->request->all();

        $return = $this->loader->readLeaderboard($post);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        if (empty($return)) {
            return new Response\NoContent();
        }

        return new Response\Ok($return);
    }
}


1		<?php
2
3		namespace Ps2alerts\Api\Controller\Statistics;
4
5		use League\Route\Http\JsonResponse as Response;
6		use Ps2alerts\Api\Controller\EndpointBaseController;
7		use Ps2alerts\Api\Loader\Statistics\PlayerStatisticsLoader;
8		use Symfony\Component\HttpFoundation\Request;
9
10	View Code Duplication	class PlayerStatisticsEndpoint extends EndpointBaseController
		0 ignored issues – show Duplication introduced 2015-12-29 15:47 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
11		{
12		/**
13		* Construct
14		*
15		* @param \Ps2alerts\Api\Loader\Metrics\PlayerStatisticsLoader $loader
16		*/
17		public function __construct(PlayerStatisticsLoader $loader)
18		{
19		$this->loader = $loader;
20		}
21
22		/**
23		* Gets top players
24		*
25		* @param \Symfony\Component\HttpFoundation\Request $request
26		*
27		* @return \League\Route\Http\JsonResponse
28		*/
29		public function readLeaderboard(Request $request)
30		{
31		$post = $request->request->all();
32
33		$return = $this->loader->readLeaderboard($post);
		0 ignored issues – show Bug introduced 2015-12-29 15:47 UTC by Report Bug Copy Issue Report The method `readLeaderboard` does only exist in `Ps2alerts\Api\Loader\Sta...\PlayerStatisticsLoader`, but not in `Ps2alerts\Api\Loader\Ale...tTotalsStatisticsLoader`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
34
35		if (empty($return)) {
36		return new Response\NoContent();
37		}
38
39		return new Response\Ok($return);
40		}
41		}
42

Maelstromeous / ps2alerts-api

Push — master ( 0cb788...5f9089 )

PlayerStatisticsEndpoint::readLeaderboard() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like