Maelstromeous / ps2alerts-api

src/Controller/Endpoint/Alerts/AlertCombatEndpointController.php

Unused Use Statements -3 removed lines

@@ -2,11 +2,8 @@
 
 namespace Ps2alerts\Api\Controller\Endpoint\Alerts;
 
-use League\Fractal\Manager;
 use Ps2alerts\Api\Controller\Endpoint\Alerts\AlertEndpointController;
 use Ps2alerts\Api\Exception\InvalidArgumentException;
-use Ps2alerts\Api\Repository\Metrics\CombatRepository;
-use Ps2alerts\Api\Repository\Metrics\ClassRepository;
 use Psr\Http\Message\ServerRequestInterface;
 use Psr\Http\Message\ResponseInterface;
 

Spacing +13 added lines, -13 removed lines

@@ -49,23 +49,23 @@ 
             $data = $this->checkRedis('api', 'combatTotals', "{$server}-data");
             $dataArchive = $this->checkRedis('api', 'combatTotals', "{$server}-dataArchive");
 
-            if (! $data || ! $dataArchive) {
+            if (!$data || !$dataArchive) {
                 $sums = [];
                 foreach ($metrics as $metric) {
                     foreach ($factions as $faction) {
-                        $dbMetric = $metric . strtoupper($faction); // e.g. killsVS
-                        $dataMetric = $metric . strtoupper($faction); // e.g. killsVS
+                        $dbMetric = $metric.strtoupper($faction); // e.g. killsVS
+                        $dataMetric = $metric.strtoupper($faction); // e.g. killsVS
 
                         // Handle teamkills inconsistency
                         if ($metric === 'teamkills') {
-                            $dbMetric = 'teamKills' . strtoupper($faction);
+                            $dbMetric = 'teamKills'.strtoupper($faction);
                         }
                         $sums[] = "SUM(factions.{$dbMetric}) AS $dataMetric";
                     }
 
                     // Totals
-                    $dbMetric = 'total' . ucfirst($metric); // e.g. killsVS
-                    $dataMetric = 'total' . ucfirst($metric); // e.g. killsVS
+                    $dbMetric = 'total'.ucfirst($metric); // e.g. killsVS
+                    $dataMetric = 'total'.ucfirst($metric); // e.g. killsVS
 
                     // Handle teamkills inconsistency
                     if ($metric === 'teamkills') {
@@ -100,12 +100,12 @@ 
             // Merge the two arrays together
             foreach ($metrics as $metric) {
                 // Tot up totals
-                $dbMetric = 'total' . ucfirst($metric);
+                $dbMetric = 'total'.ucfirst($metric);
                 $mergedArray['totals'][$metric] = (int) $data[$dbMetric] + (int) $dataArchive[$dbMetric];
                 $results['all']['totals'][$metric] += $mergedArray['totals'][$metric];
 
                 foreach ($factions as $faction) {
-                    $dbMetric = $metric . strtoupper($faction);
+                    $dbMetric = $metric.strtoupper($faction);
                     $mergedArray[$metric][$faction] = (int) $data[$dbMetric] + (int) $dataArchive[$dbMetric];
                     $results['all'][$metric][$faction] += $mergedArray[$metric][$faction];
                 }
@@ -148,7 +148,7 @@ 
             $dataArchive = $this->checkRedis('api', 'classCombat', "{$server}-dataArchive", 'object');
 
             // If data needs a pull
-            if (! $data || ! $dataArchive) {
+            if (!$data || !$dataArchive) {
                 $query = $this->combatRepository->newQuery('single', true);
                 $query->cols([
                         'classID',
@@ -181,8 +181,8 @@ 
             // Typecase into ints and increase totals
             $metrics = ['kills', 'deaths', 'teamkills', 'suicides'];
             foreach ($data as $row) {
-                $row->classID   = (int) $row->classID;
-                $row->server   = (int) $row->server;
+                $row->classID = (int) $row->classID;
+                $row->server = (int) $row->server;
                 $classGroup = $this->findClassGrouping($row->classID);
                 $faction = $this->findClassFaction($row->classID);
 
@@ -201,8 +201,8 @@ 
             }
 
             foreach ($dataArchive as $row) {
-                $row->classID   = (int) $row->classID;
-                $row->server   = (int) $row->server;
+                $row->classID = (int) $row->classID;
+                $row->server = (int) $row->server;
 
                 foreach ($metrics as $metric) {
                     $row->$metric = (int) $row->$metric;

src/Controller/Endpoint/Alerts/AlertEndpointController.php

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use League\Fractal\Manager;
 use Ps2alerts\Api\Controller\Endpoint\AbstractEndpointController;
 use Ps2alerts\Api\Repository\AlertRepository;
-use Ps2alerts\Api\Transformer\AlertTotalTransformer;
 use Ps2alerts\Api\Transformer\AlertTransformer;
 use Psr\Http\Message\ServerRequestInterface;
 use Psr\Http\Message\ResponseInterface;

Spacing +4 added lines, -4 removed lines

@@ -103,11 +103,11 @@ 
         $limit    = (int) $_GET['limit'];
 
         // Set defaults if not supplied
-        if (empty($offset) || ! is_numeric($offset)) {
+        if (empty($offset) || !is_numeric($offset)) {
             $offset = 0;
         }
 
-        if (empty($limit) || ! is_numeric($limit)) {
+        if (empty($limit) || !is_numeric($limit)) {
             $limit = 50;
         }
 
@@ -173,11 +173,11 @@ 
         $limit  = (int) $_GET['limit'];
 
         // Set defaults if not supplied
-        if (empty($offset) || ! is_numeric($offset)) {
+        if (empty($offset) || !is_numeric($offset)) {
             $offset = 0;
         }
 
-        if (empty($limit) || ! is_numeric($limit)) {
+        if (empty($limit) || !is_numeric($limit)) {
             $limit = 50;
         }
 

src/Controller/Endpoint/ContextualDataEndpointController.php

Unused Use Statements -3 removed lines

@@ -5,10 +5,7 @@
 use League\Fractal\Manager;
 use Ps2alerts\Api\Controller\Endpoint\AbstractEndpointController;
 use Ps2alerts\Api\Repository\AlertRepository;
-use Ps2alerts\Api\Transformer\AlertTotalTransformer;
 use Ps2alerts\Api\Transformer\AlertTransformer;
-use Psr\Http\Message\ServerRequestInterface;
-use Psr\Http\Message\ResponseInterface;
 
 class ContextualDataEndpointController extends AbstractEndpointController
 {

Spacing +1 added lines, -1 removed lines

@@ -22,6 +22,6 @@
     public function __construct(
         Manager          $fractal
     ) {
-        $this->fractal     = $fractal;
+        $this->fractal = $fractal;
     }
 }

src/Controller/Endpoint/Leaderboards/LeaderboardEndpointController.php

Unused Use Statements -1 removed lines

@@ -11,7 +11,6 @@
 use Ps2alerts\Api\Repository\Metrics\OutfitTotalRepository;
 use Ps2alerts\Api\Repository\Metrics\PlayerTotalRepository;
 use Ps2alerts\Api\Repository\Metrics\WeaponTotalRepository;
-use Ps2alerts\Api\Transformer\Leaderboards\LeaderboardUpdatedTransformer;
 use Ps2alerts\Api\Transformer\Leaderboards\OutfitLeaderboardTransformer;
 use Ps2alerts\Api\Transformer\Leaderboards\PlayerLeaderboardTransformer;
 use Ps2alerts\Api\Transformer\Leaderboards\WeaponLeaderboardTransformer;

Spacing +12 added lines, -12 removed lines

@@ -83,7 +83,7 @@ 
             }
         }
 
-        if (! isset($field)) {
+        if (!isset($field)) {
             return $this->errorWrongArgs('Field wasn\'t provided and is required.');
         }
 
@@ -112,7 +112,7 @@ 
 
         // Gets outfit details
         for ($i = 0; $i < $count; $i++) {
-            if (! empty($players[$i]['playerOutfit'])) {
+            if (!empty($players[$i]['playerOutfit'])) {
                 // Gets outfit details
                 try {
                     $outfit = $this->dataEndpoint->getOutfit($players[$i]['playerOutfit']);
@@ -176,7 +176,7 @@ 
             }
         }
 
-        if (! isset($field)) {
+        if (!isset($field)) {
             return $this->errorWrongArgs('Field wasn\'t provided and is required.');
         }
 
@@ -239,7 +239,7 @@ 
             }
         }
 
-        if (! isset($field)) {
+        if (!isset($field)) {
             return $this->errorWrongArgs('Field wasn\'t provided and is required.');
         }
 
@@ -282,19 +282,19 @@ 
     public function validateRequestVars($request)
     {
         try {
-            if (! empty($_GET['field'])) {
+            if (!empty($_GET['field'])) {
                 $this->parseField($_GET['field']);
             }
 
-            if (! empty($_GET['server'])) {
+            if (!empty($_GET['server'])) {
                 $this->parseServer($_GET['server']);
             }
 
-            if (! empty($_GET['limit'])) {
+            if (!empty($_GET['limit'])) {
                 $this->parseOffset($_GET['limit']);
             }
 
-            if (! empty($_GET['offset'])) {
+            if (!empty($_GET['offset'])) {
                 $this->parseOffset($_GET['offset']);
             }
         } catch (InvalidArgumentException $e) {
@@ -320,7 +320,7 @@ 
             'captures'
         ];
 
-        if (! empty($field) && in_array($field, $validFields)) {
+        if (!empty($field) && in_array($field, $validFields)) {
             return $field;
         }
 
@@ -341,7 +341,7 @@ 
             unset($validServers[$key]);
         }
 
-        if (! empty($server) && in_array($server, $validServers)) {
+        if (!empty($server) && in_array($server, $validServers)) {
             return $server;
         }
 
@@ -355,7 +355,7 @@ 
      */
     public function parseLimit($limit)
     {
-        if (! isset($limit) && ! is_numeric($limit)) {
+        if (!isset($limit) && !is_numeric($limit)) {
             throw new InvalidArgumentException("Limit needs to be in numerical format.");
         }
 
@@ -367,7 +367,7 @@ 
      */
     public function parseOffset($offset)
     {
-        if (! isset($offset) && ! is_numeric($offset)) {
+        if (!isset($offset) && !is_numeric($offset)) {
             throw new InvalidArgumentException("Offset needs to be in numerical format.");
         }
 

src/Controller/Endpoint/Leaderboards/LeaderboardLadderEndpointController.php

Unused Use Statements -3 removed lines

@@ -2,10 +2,7 @@
 
 namespace Ps2alerts\Api\Controller\Endpoint\Leaderboards;
 
-use League\Fractal\Manager;
 use Ps2alerts\Api\Controller\Endpoint\AbstractEndpointController;
-use Ps2alerts\Api\Repository\Metrics\OutfitTotalRepository;
-use Ps2alerts\Api\Repository\Metrics\PlayerTotalRepository;
 use Psr\Http\Message\ServerRequestInterface;
 use Psr\Http\Message\ResponseInterface;
 

Spacing +1 added lines, -1 removed lines

@@ -83,7 +83,7 @@
 
         $data = [];
 
-        foreach($config['servers'] as $server) {
+        foreach ($config['servers'] as $server) {
             $key = "ps2alerts:api:leaderboards:status:{$server}";
 
             if ($redis->exists($key)) {

src/Controller/Endpoint/Search/SearchEndpointController.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use League\Fractal\Manager;
 use Ps2alerts\Api\Controller\Endpoint\AbstractEndpointController;
-use Ps2alerts\Api\Exception\InvalidArgumentException;
 use Ps2alerts\Api\Repository\Metrics\OutfitTotalRepository;
 use Ps2alerts\Api\Repository\Metrics\PlayerTotalRepository;
 use Ps2alerts\Api\Transformer\Search\OutfitSearchTransformer;

Spacing +3 added lines, -3 removed lines

@@ -52,7 +52,7 @@ 
         if ($this->parsePlayerName($args['term'], $response)) {
             $players = $this->searchForPlayer($args['term']);
 
-            if (! empty($players)) {
+            if (!empty($players)) {
                 return $this->respond(
                     'collection',
                     $players,
@@ -81,7 +81,7 @@ 
         if ($this->parseOutfitName($name, $response)) {
             $outfits = $this->searchForOutfit($name);
 
-            if (! empty($outfits)) {
+            if (!empty($outfits)) {
                 return $this->respond(
                     'collection',
                     $outfits,
@@ -199,7 +199,7 @@ 
             return $this->errorWrongArgs('Player ID cannot be longer than 19 characters.');
         }
 
-        if (! is_numeric($id)) {
+        if (!is_numeric($id)) {
             return $this->errorWrongArgs('Player ID must be numeric.');
         }
 

src/Transformer/AlertTransformer.php

Unused Use Statements -1 removed lines

@@ -14,7 +14,6 @@
 use Ps2alerts\Api\Repository\Metrics\VehicleTotalRepository;
 use Ps2alerts\Api\Repository\Metrics\WeaponTotalRepository;
 use Ps2alerts\Api\Repository\Metrics\XpRepository;
-
 use Ps2alerts\Api\Transformer\Metrics\ClassTransformer;
 use Ps2alerts\Api\Transformer\Metrics\CombatHistoryTransformer;
 use Ps2alerts\Api\Transformer\Metrics\CombatTransformer;

src/Transformer/Data/OutfitTransformer.php

Spacing +1 added lines, -1 removed lines

@@ -18,7 +18,7 @@
         $obj = [
             'id'          => (string) $data->outfit_id, // Bigint
             'name'        => (string) $data->name,
-            'tag'         => (! empty($data->alias)) ? (string) $data->alias : null,
+            'tag'         => (!empty($data->alias)) ? (string) $data->alias : null,
             'faction'     => (int) $data->leader->faction_id,
             'count'       => (int) $data->member_count,
             'leader'      => (string) $data->leader_character_id,

src/Transformer/Leaderboards/PlayerLeaderboardTransformer.php

Spacing +1 added lines, -1 removed lines

@@ -15,7 +15,7 @@
      */
     public function transform($data)
     {
-        if (! isset($data['playerOutfit'])) {
+        if (!isset($data['playerOutfit'])) {
             $outfit = null;
         } else {
             $outfit = $data['playerOutfit'];