Maelstromeous / ps2alerts-api

src/Command/CommandsCommon.php

Spacing +2 added lines, -2 removed lines

@@ -1,6 +1,6 @@
 <?php
 
 function convert($size) {
-    $unit=array('B','KB','MB','GB','TB','PB');
-    return @round($size/pow(1024,($i=floor(log($size,1024)))),2).' '.$unit[$i];
+    $unit = array('B', 'KB', 'MB', 'GB', 'TB', 'PB');
+    return @round($size / pow(1024, ($i = floor(log($size, 1024)))), 2).' '.$unit[$i];
 }

src/Command/DeleteAlertCommand.php

Upper-Lower-Casing +2 added lines, -2 removed lines

@@ -54,7 +54,7 @@ 
         $alert = $this->alertRepo->readSingleById($id, 'primary', true);
 
         if (empty($force) && empty($id)) {
-            $output->writeln("ALERT {$id} DOES NOT EXIST!");
+            $output->writeln("alert {$id} DOES NOT EXIST!");
             return false;
         }
 
@@ -99,7 +99,7 @@ 
         $this->deleteAlert($id);
 
         if ($this->verbose === 1) {
-            $output->writeln("Alert {$id} successfully deleted!");
+            $output->writeln("alert {$id} successfully deleted!");
         }
 
         return true;

Doc Comments +11 added lines, -5 removed lines

@@ -115,7 +115,7 @@ 
     /**
      * Processes players for alert
      * @param  string $id Alert ID
-     * @return void
+     * @return integer
      */
     protected function processPlayers($id)
     {
@@ -149,7 +149,7 @@ 
     /**
      * Processes outfits for alert
      * @param  string $id Alert ID
-     * @return void
+     * @return integer
      */
     protected function processOutfits($id)
     {
@@ -181,7 +181,7 @@ 
     /**
      * Processes XPs for alert
      * @param  string $id Alert ID
-     * @return void
+     * @return integer
      */
     protected function processXP($id)
     {
@@ -208,11 +208,11 @@ 
     /**
      * Executes the process based on inputs
      * @param  string $id          Alert ID
-     * @param  array  $cols        Columns to look for
+     * @param  string[]  $cols        Columns to look for
      * @param  string $table       Table to look for
      * @param  string $totalsTable Table total to update if applicable
      * @param  string $filter      Column to filter on
-     * @param  array  $fields      Fields to summarize
+     * @param  string[]  $fields      Fields to summarize
      * @param  array  $groupBy     Fields to group by
      * @return int
      */
@@ -270,6 +270,9 @@ 
         return $count;
     }
 
+    /**
+     * @param string $id
+     */
     protected function deleteAllFromTables(array $tables, $id, OutputInterface $output)
     {
         foreach ($tables as $table) {
@@ -288,6 +291,9 @@ 
         }
     }
 
+    /**
+     * @param string $id
+     */
     protected function deleteAlert($id)
     {
         $delete = $this->auraFactory->newDelete();

src/Controller/Endpoint/Admin/AdminEndpointController.php

Indentation +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
     /**
      * Construct
      *
-    */
+     */
     public function __construct()
     {
 

public/index.php

Spacing +5 added lines, -5 removed lines

@@ -1,12 +1,12 @@ 
 <?php
 
-include __DIR__ . '/../vendor/autoload.php';
+include __DIR__.'/../vendor/autoload.php';
 
 use League\Route\Http\Exception\NotFoundException;
 
 // ENV loading
 josegonzalez\Dotenv\Loader::load([
-    'filepath' => __DIR__ . '/../.env',
+    'filepath' => __DIR__.'/../.env',
     'toEnv'    => true
 ]);
 
@@ -21,10 +21,10 @@ 
 }
 
 // Container
-$container = include __DIR__ . '/../src/container.php';
+$container = include __DIR__.'/../src/container.php';
 
 // Routes
-$router = include __DIR__ . '/../src/routes.php';
+$router = include __DIR__.'/../src/routes.php';
 
 // FIRE!!!
 try {
@@ -44,7 +44,7 @@ 
 } catch (\Exception $e) {
     $response = $container->get('Zend\Diactoros\Response');
     $response->getBody()->write(
-        'An error occured! ' . $e->getMessage()
+        'An error occured! '.$e->getMessage()
     );
 
     $logger = $container->get('Monolog\Logger');

src/commands.php

Spacing +3 added lines, -3 removed lines

@@ -9,15 +9,15 @@
 use Ps2alerts\Api\Command\TestCommand;
 use Symfony\Component\Console\Application;
 
-require __DIR__ . '/../vendor/autoload.php';
+require __DIR__.'/../vendor/autoload.php';
 
 // ENV loading
 josegonzalez\Dotenv\Loader::load([
-    'filepath' => __DIR__ . '/../.env',
+    'filepath' => __DIR__.'/../.env',
     'toEnv'    => true
 ]);
 
-include __DIR__ . '/Command/CommandsCommon.php';
+include __DIR__.'/Command/CommandsCommon.php';
 
 $application = new Application();
 // List commands here

src/Command/BaseCommand.php

Spacing +1 added lines, -1 removed lines

@@ -11,7 +11,7 @@
 
     protected function configure()
     {
-        $container = include __DIR__ . '/../container.php';
+        $container = include __DIR__.'/../container.php';
 
         $this->container   = $container;
         $this->auraFactory = $container->get('Ps2alerts\Api\Factory\AuraFactory');

src/Command/ArchiveCommand.php

Doc Comments +2 added lines, -2 removed lines

@@ -122,8 +122,8 @@
      * Execution of routine
      *
      * @param  array                                            $alert
-     * @param  array                                            $tables
-     * @param  Symfony\Component\Console\Output\OutputInterface $output
+     * @param  string[]                                            $tables
+     * @param  OutputInterface $output
      *
      * @return void
      */

Upper-Lower-Casing +3 added lines, -3 removed lines

@@ -73,7 +73,7 @@ 
         $alerts = $this->alertRepo->fireStatementAndReturn($query);
         $count = count($alerts);
 
-        $output->writeln("Detected {$count} alerts to be archived");
+        $output->writeln("detected {$count} alerts to be archived");
 
         if ($count > 0) {
             $tables = [
@@ -115,7 +115,7 @@ 
             ['json' => $payload]
         );
 
-        $output->writeln("Archived {$records} records!");
+        $output->writeln("archived {$records} records!");
     }
 
     /**
@@ -183,7 +183,7 @@ 
             $this->recordsArchived += $stm->rowCount();
             $records += $stm->rowCount();
 
-            $output->writeln("Archived {$stm->rowCount()} from Alert #{$alert['ResultID']} - Table {$table}");
+            $output->writeln("archived {$stm->rowCount()} from Alert #{$alert['ResultID']} - Table {$table}");
         }
 
         $this->db->commit();

src/Controller/Endpoint/AbstractEndpointController.php

Unused Use Statements -1 removed lines

@@ -13,7 +13,6 @@
 use Ps2alerts\Api\Contract\RedisAwareInterface;
 use Ps2alerts\Api\Contract\RedisAwareTrait;
 use Ps2alerts\Api\Exception\InvalidArgumentException;
-use Psr\Http\Message\ServerRequestInterface;
 use Psr\Http\Message\ResponseInterface;
 
 abstract class AbstractEndpointController implements

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -437,7 +437,7 @@
                 }
 
                 if (!in_array($id, $filters)) {
-                    throw new InvalidArgumentException("Unrecognized {$mode}. Please check the IDs you sent.");
+                    throw new InvalidArgumentException("unrecognized {$mode}. Please check the IDs you sent.");
                 }
             }
 

src/Command/LeaderboardOutfitsCommand.php

Spacing +1 added lines, -1 removed lines

@@ -77,7 +77,7 @@
                         $query->where('playerServer', $server);
                     }
 
-                    $query->orderBy([$metric . ' DESC']);
+                    $query->orderBy([$metric.' DESC']);
                     $query->limit($limit);
                     $query->offset($count);