Maelstromeous / ps2alerts-api

src/Controller/Metrics/ClassMetricsEndpoint.php

Doc Comments +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
     /**
      * Returns a single entry
      *
-     * @param  Symfony\Component\HttpFoundation\Request $request
+     * @param  Request $request
      * @param  array   $args
      *
      * @return \League\Route\Http\JsonResponse

src/Controller/Alerts/AlertEndpointController.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use League\Route\Http\JsonResponse as Response;
 use Ps2alerts\Api\Controller\EndpointBaseController;
-use Ps2alerts\Api\QueryObjects\QueryObject;
 use Ps2alerts\Api\Loader\ResultLoader;
 use Symfony\Component\HttpFoundation\Request;
 

src/Controller/Statistics/OutfitTotalsStatisticsEndpoint.php

Doc Comments +1 added lines, -2 removed lines

@@ -12,7 +12,7 @@ 
     /**
      * Construct
      *
-     * @param \Ps2alerts\Api\Loader\Metrics\OutfitTotalsStatisticsLoader $loader
+     * @param OutfitTotalsStatisticsLoader $loader
      */
     public function __construct(OutfitTotalsStatisticsLoader $loader)
     {
@@ -23,7 +23,6 @@ 
      * Returns top X entries
      *
      * @param  \Symfony\Component\HttpFoundation\Request $request
-     * @param  array                                     $args
      *
      * @return \League\Route\Http\JsonResponse
      */

src/Controller/Statistics/PlayerStatisticsEndpoint.php

Doc Comments +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
     /**
      * Construct
      *
-     * @param \Ps2alerts\Api\Loader\Metrics\PlayerStatisticsLoader $loader
+     * @param PlayerStatisticsLoader $loader
      */
     public function __construct(PlayerStatisticsLoader $loader)
     {

src/Loader/Statistics/OutfitTotalsStatisticsLoader.php

Doc Comments +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
     /**
      * Construct
      *
-     * @param \Ps2alerts\Api\Repository\Metrics\OutfitTotalsRepository $repository
+     * @param OutfitTotalsRepository $repository
      */
     public function __construct(OutfitTotalsRepository $repository)
     {

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use League\Route\Http\JsonResponse as Response;
 use Ps2alerts\Api\Controller\EndpointBaseController;
-use Ps2alerts\Api\QueryObjects\QueryObject;
 use Ps2alerts\Api\Loader\ResultLoader;
 use Symfony\Component\HttpFoundation\Request;
 

src/Loader/Statistics/PlayerStatisticsLoader.php

Doc Comments +3 added lines

@@ -91,6 +91,9 @@
         );
     }
 
+    /**
+     * @param string $field
+     */
     public function validatePostVars($field, $value)
     {
         if ($field === 'metric' && ! empty($value)) {

Spacing +8 added lines, -8 removed lines

@@ -32,10 +32,10 @@ 
         $queryObject = new QueryObject;
 
         // Build based on metric alone (order by playerKills for example)
-        if (! empty($post['metric'] && empty($post['value']))
+        if (!empty($post['metric'] && empty($post['value']))
             && $this->validatePostVars('metric', $post['metric']) === true
         ) {
-            $direction = (! empty($post['direction']) ? $post['direction'] : 'desc');
+            $direction = (!empty($post['direction']) ? $post['direction'] : 'desc');
 
             $queryObject->setOrderBy($post['metric']);
             $queryObject->setOrderByDirection($direction);
@@ -44,11 +44,11 @@ 
         }
 
         // Build based on metric and a value (such as order by playerKills by server)
-        if (! empty($post['value'])
-            && ! empty($post['metric'])
+        if (!empty($post['value'])
+            && !empty($post['metric'])
             && $this->validatePostVars('metric', $post['metric']) === true
         ) {
-            $op = (! empty($post['operator']) ? $post['operator'] : '=');
+            $op = (!empty($post['operator']) ? $post['operator'] : '=');
 
             $queryObject->addWhere([
                 'col' => $post['metric'],
@@ -56,7 +56,7 @@ 
                 'value' => $post['value']
             ]);
 
-            $direction = (! empty($post['direction']) ? $post['direction'] : 'desc');
+            $direction = (!empty($post['direction']) ? $post['direction'] : 'desc');
 
             $queryObject->setOrderBy($post['metric']);
             $queryObject->setOrderByDirection($direction);
@@ -64,7 +64,7 @@ 
             $redisKey .= ":{$post['metric']}{$op}{$post['value']}-{$direction}";
         }
 
-        if (! empty($post['limit'])) {
+        if (!empty($post['limit'])) {
             $post['limit'] = intval($post['limit']);
 
             // Hard encode a 50 limit
@@ -93,7 +93,7 @@ 
 
     public function validatePostVars($field, $value)
     {
-        if ($field === 'metric' && ! empty($value)) {
+        if ($field === 'metric' && !empty($value)) {
             switch ($value) {
                 case 'playerKills':
                 case 'playerDeaths':

src/QueryObjects/QueryObject.php

Doc Comments +2 added lines, -2 removed lines

@@ -49,7 +49,7 @@ 
      * in the array and added to.
      * e.g. $queryObject->addSelect('COUNT(ResultID) AS COUNT');
      *
-     * @param string $string
+     * @param string $array
      */
     public function addSelect($array)
     {
@@ -171,7 +171,7 @@ 
     /**
      * Allows setting of workaround flags
      *
-     * @param array|string $flags
+     * @param string $flags
      */
     public function setFlags($flags)
     {

src/Repository/AbstractEndpointRepository.php

Spacing +5 added lines, -5 removed lines

@@ -66,14 +66,14 @@ 
         $query = $this->newQuery();
 
         // Setup select statements
-        if (! empty($queryObject->getSelects())) {
+        if (!empty($queryObject->getSelects())) {
             $query->cols($queryObject->getSelects());
         } else {
             $query->cols(['*']);
         }
 
         // Workarounds :-/
-        if (! empty($queryObject->getFlags())) {
+        if (!empty($queryObject->getFlags())) {
             if ($queryObject->getFlags() === 'outfitIDs') {
                 // Prevent the VS, NC and TR "no outfit" workaround
                 $queryObject->addWhere([
@@ -85,7 +85,7 @@ 
         }
 
         // Setup where statements
-        if (! empty($queryObject->getWheres())) {
+        if (!empty($queryObject->getWheres())) {
             foreach ($queryObject->getWheres() as $where) {
                 $col = $where['col'];
 
@@ -104,7 +104,7 @@ 
         }
 
         // Set up order statement
-        if (! empty($queryObject->getOrderBy())) {
+        if (!empty($queryObject->getOrderBy())) {
             $orderBy = $queryObject->getOrderBy();
             if ($orderBy === 'primary') {
                 $orderBy = $this->getPrimaryKey();
@@ -118,7 +118,7 @@ 
             ]);
         }
 
-        if (! empty($queryObject->getLimit())) {
+        if (!empty($queryObject->getLimit())) {
             $query->limit($queryObject->getLimit());
         }
 

src/Loader/Statistics/AlertStatisticsLoader.php

Spacing +4 added lines, -4 removed lines

@@ -54,7 +54,7 @@ 
             'value' => '1'
         ]);
 
-        if (! empty($post['ResultServer'])) {
+        if (!empty($post['ResultServer'])) {
             if ($this->inputValidator->validatePostVars(
                 'ResultServer',
                 $post['ResultServer']
@@ -67,7 +67,7 @@ 
             }
         }
 
-        if (! empty($post['ResultWinner'])) {
+        if (!empty($post['ResultWinner'])) {
             if ($this->inputValidator->validatePostVars(
                 'ResultWinner',
                 $post['ResultWinner']
@@ -80,7 +80,7 @@ 
             }
         }
 
-        if (! empty($post['ResultAlertCont'])) {
+        if (!empty($post['ResultAlertCont'])) {
             if ($this->inputValidator->validatePostVars(
                 'ResultAlertCont',
                 $post['ResultAlertCont']
@@ -93,7 +93,7 @@ 
             }
         }
 
-        if (! empty($post['ResultDomination'])) {
+        if (!empty($post['ResultDomination'])) {
             if ($this->inputValidator->validatePostVars(
                 'ResultDomination',
                 $post['ResultDomination']