Maelstromeous / ps2alerts-api

src/Controller/Metrics/ClassMetricsEndpoint.php

Doc Comments +1 added lines, -1 removed lines

@@ -13,7 +13,7 @@
     /**
      * Returns a single entry
      *
-     * @param  Symfony\Component\HttpFoundation\Request $request
+     * @param  Request $request
      * @param  array   $args
      *
      * @return \League\Route\Http\JsonResponse

src/Controller/Alerts/AlertEndpointController.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use League\Route\Http\JsonResponse as Response;
 use Ps2alerts\Api\Controller\EndpointBaseController;
-use Ps2alerts\Api\QueryObjects\QueryObject;
 use Ps2alerts\Api\Loader\ResultLoader;
 use Symfony\Component\HttpFoundation\Request;
 

src/Controller/Statistics/OutfitTotalsStatisticsEndpoint.php

Doc Comments +1 added lines, -2 removed lines

@@ -12,7 +12,7 @@ 
     /**
      * Construct
      *
-     * @param \Ps2alerts\Api\Loader\Metrics\OutfitTotalsStatisticsLoader $loader
+     * @param OutfitTotalsStatisticsLoader $loader
      */
     public function __construct(OutfitTotalsStatisticsLoader $loader)
     {
@@ -23,7 +23,6 @@ 
      * Returns top X entries
      *
      * @param  \Symfony\Component\HttpFoundation\Request $request
-     * @param  array                                     $args
      *
      * @return \League\Route\Http\JsonResponse
      */

src/Controller/Statistics/PlayerStatisticsEndpoint.php

Doc Comments +1 added lines, -1 removed lines

@@ -12,7 +12,7 @@
     /**
      * Construct
      *
-     * @param \Ps2alerts\Api\Loader\Metrics\PlayerStatisticsLoader $loader
+     * @param PlayerStatisticsLoader $loader
      */
     public function __construct(PlayerStatisticsLoader $loader)
     {

src/Loader/Statistics/OutfitTotalsStatisticsLoader.php

Doc Comments +1 added lines, -1 removed lines

@@ -16,7 +16,7 @@
     /**
      * Construct
      *
-     * @param \Ps2alerts\Api\Repository\Metrics\OutfitTotalsRepository $repository
+     * @param OutfitTotalsRepository $repository
      */
     public function __construct(OutfitTotalsRepository $repository)
     {

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use League\Route\Http\JsonResponse as Response;
 use Ps2alerts\Api\Controller\EndpointBaseController;
-use Ps2alerts\Api\QueryObjects\QueryObject;
 use Ps2alerts\Api\Loader\ResultLoader;
 use Symfony\Component\HttpFoundation\Request;
 

src/Loader/Statistics/PlayerStatisticsLoader.php

Doc Comments +3 added lines

@@ -91,6 +91,9 @@
         );
     }
 
+    /**
+     * @param string $field
+     */
     public function validatePostVars($field, $value)
     {
         if ($field === 'metric' && ! empty($value)) {

Spacing +8 added lines, -8 removed lines

@@ -32,10 +32,10 @@ 
         $queryObject = new QueryObject;
 
         // Build based on metric alone (order by playerKills for example)
-        if (! empty($post['metric'] && empty($post['value']))
+        if (!empty($post['metric'] && empty($post['value']))
             && $this->validatePostVars('metric', $post['metric']) === true
         ) {
-            $direction = (! empty($post['direction']) ? $post['direction'] : 'desc');
+            $direction = (!empty($post['direction']) ? $post['direction'] : 'desc');
 
             $queryObject->setOrderBy($post['metric']);
             $queryObject->setOrderByDirection($direction);
@@ -44,11 +44,11 @@ 
         }
 
         // Build based on metric and a value (such as order by playerKills by server)
-        if (! empty($post['value'])
-            && ! empty($post['metric'])
+        if (!empty($post['value'])
+            && !empty($post['metric'])
             && $this->validatePostVars('metric', $post['metric']) === true
         ) {
-            $op = (! empty($post['operator']) ? $post['operator'] : '=');
+            $op = (!empty($post['operator']) ? $post['operator'] : '=');
 
             $queryObject->addWhere([
                 'col' => $post['metric'],
@@ -56,7 +56,7 @@ 
                 'value' => $post['value']
             ]);
 
-            $direction = (! empty($post['direction']) ? $post['direction'] : 'desc');
+            $direction = (!empty($post['direction']) ? $post['direction'] : 'desc');
 
             $queryObject->setOrderBy($post['metric']);
             $queryObject->setOrderByDirection($direction);
@@ -64,7 +64,7 @@ 
             $redisKey .= ":{$post['metric']}{$op}{$post['value']}-{$direction}";
         }
 
-        if (! empty($post['limit'])) {
+        if (!empty($post['limit'])) {
             $post['limit'] = intval($post['limit']);
 
             // Hard encode a 50 limit
@@ -93,7 +93,7 @@ 
 
     public function validatePostVars($field, $value)
     {
-        if ($field === 'metric' && ! empty($value)) {
+        if ($field === 'metric' && !empty($value)) {
             switch ($value) {
                 case 'playerKills':
                 case 'playerDeaths':

src/Loader/AlertLoader.php

Spacing +3 added lines, -3 removed lines

@@ -41,7 +41,7 @@ 
             'value' => date('U', strtotime('-48 hours'))
         ]);
 
-        if (! empty($args['serverID'])) {
+        if (!empty($args['serverID'])) {
             $redisKey .= ":{$args['serverID']}";
             $queryObject->addWhere([
                 'col'   => 'ResultServer',
@@ -49,7 +49,7 @@ 
             ]);
         }
 
-        if (! empty($args['limit'])) {
+        if (!empty($args['limit'])) {
             if ($args['limit'] > 50) {
                 $args['limit'] = 50;
             }
@@ -81,7 +81,7 @@ 
             'value' => 1
         ]);
 
-        if (! empty($args['serverID'])) {
+        if (!empty($args['serverID'])) {
             $queryObject->addWhere([
                 'col'   => 'ResultServer',
                 'value' => $args['serverID']

src/Loader/Statistics/AbstractStatisticsLoader.php

Doc Comments +1 added lines, -1 removed lines

@@ -149,7 +149,7 @@
      * Takes common requests and appends them to the query object. Any other
      * special requirements will be handled after
      *
-     * @param  Ps2alerts\Api\QueryObjects\QueryObject $queryObject
+     * @param  QueryObject $queryObject
      * @param  array                                  $post
      *
      * @return Ps2alerts\Api\QueryObjects\QueryObject

Spacing +15 added lines, -15 removed lines

@@ -75,33 +75,33 @@ 
      */
     public function appendRedisKey($post, $redisKey)
     {
-        if (! empty($post['selects'])) {
+        if (!empty($post['selects'])) {
             $whereMD5 = md5($post['selects']);
             $redisKey .= "/select{$whereMD5}";
         }
 
-        if (! empty($post['wheres'])) {
+        if (!empty($post['wheres'])) {
             $whereMD5 = md5($post['wheres']);
             $redisKey .= "/where{$whereMD5}";
         }
 
-        if (! empty($post['whereIns'])) {
+        if (!empty($post['whereIns'])) {
             $whereInMD5 = md5($post['whereIns']);
             $redisKey .= "/whereIn{$whereInMD5}";
         }
 
-        if (! empty($post['orderBy'])) {
+        if (!empty($post['orderBy'])) {
             $orderMD5 = md5($post['orderBy']);
             $redisKey .= "/order{$orderMD5}";
         }
-        if (! empty($post['limit'])) {
+        if (!empty($post['limit'])) {
             // Enforce a max limit
             if ($post['limit'] > 50) {
                 $post['limit'] = 50;
             }
         }
 
-        if (empty($post['limit']) || ! isset($post['limit'])) {
+        if (empty($post['limit']) || !isset($post['limit'])) {
             $post['limit'] = 10;
         }
 
@@ -119,20 +119,20 @@ 
      */
     public function processPostVars($post)
     {
-        if (! empty($post['wheres'])) {
+        if (!empty($post['wheres'])) {
             $return['wheres'] = json_decode($post['wheres'], true);
             $this->getLogDriver()->addDebug(json_encode($return['wheres']));
         }
 
-        if (! empty($post['whereIns'])) {
+        if (!empty($post['whereIns'])) {
             $return['whereIns'] = json_decode($post['whereIns'], true);
         }
 
-        if (! empty($post['orderBy'])) {
+        if (!empty($post['orderBy'])) {
             $return['orderBy'] = json_decode($post['orderBy'], true);
         }
 
-        if (empty($post['limit']) || ! isset($post['limit'])) {
+        if (empty($post['limit']) || !isset($post['limit'])) {
             $post['limit'] = 10;
         }
 
@@ -156,7 +156,7 @@ 
      */
     public function setupQueryObject($queryObject, $post)
     {
-        if (! empty($post['wheres'])) {
+        if (!empty($post['wheres'])) {
             foreach ($post['wheres'] as $key => $value) {
                 $queryObject->addWhere([
                     'col'   => $key,
@@ -165,7 +165,7 @@ 
             }
         }
 
-        if (! empty($post['whereIns'])) {
+        if (!empty($post['whereIns'])) {
             foreach ($post['whereIns'] as $key => $value) {
                 // Escape strings manually, incase of player IDs etc
                 foreach ($value as $i => $val) {
@@ -181,16 +181,16 @@ 
             }
         }
 
-        if (! empty($post['orderBy'])) {
+        if (!empty($post['orderBy'])) {
             $queryObject->setOrderBy(array_keys($post['orderBy'])[0]);
             $queryObject->setOrderByDirection(array_values($post['orderBy'])[0]);
         }
 
-        if (! empty($post['limit'])) {
+        if (!empty($post['limit'])) {
             $queryObject->setLimit($post['limit']);
         }
 
-        if (! empty($this->getFlags())) {
+        if (!empty($this->getFlags())) {
             // If there are some funky things we have to do, set them.
             $queryObject->setFlags($this->getFlags());
         }

src/QueryObjects/QueryObject.php

Doc Comments +1 added lines, -1 removed lines

@@ -54,7 +54,7 @@
      * in the array and added to.
      * e.g. $queryObject->addSelect('COUNT(ResultID) AS COUNT');
      *
-     * @param string $string
+     * @param string $array
      */
     public function addSelect($array)
     {

Spacing +5 added lines, -5 removed lines

@@ -118,7 +118,7 @@ 
      */
     public function setOrderBy($string)
     {
-        if (! empty($string)) {
+        if (!empty($string)) {
             $this->orderBy = $string;
         }
     }
@@ -140,7 +140,7 @@ 
      */
     public function setOrderByDirection($string)
     {
-        if (! empty($string)) {
+        if (!empty($string)) {
             $this->orderByDirection = $string;
         }
     }
@@ -162,7 +162,7 @@ 
      */
     public function setDimension($string)
     {
-        if (! empty($string)) {
+        if (!empty($string)) {
             $this->dimension = $string;
         }
     }
@@ -184,7 +184,7 @@ 
      */
     public function setLimit($limit)
     {
-        if (! empty($limit) && is_numeric($limit)) {
+        if (!empty($limit) && is_numeric($limit)) {
             $this->limit = $limit;
         }
     }
@@ -206,7 +206,7 @@ 
      */
     public function setFlags($flags)
     {
-        if (! empty($flags)) {
+        if (!empty($flags)) {
             $this->flags = $flags;
         }
     }