ConfigServiceProvider::register() - Code Metrics - Maelstromeous/ps2alerts-api - Measure and Improve Code Quality continuously with Scrutinizer

ConfigServiceProvider::register() A
last analyzed 2018-01-02 23:34 UTC

↳ Parent: ConfigServiceProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines	62
Code Lines	52

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	52
nc	1
nop	0
dl	0
loc	62
rs	9.4743
c	0
b	0
f	0

How to fix Long Method

<?php

namespace Ps2alerts\Api\ServiceProvider;

use League\Container\ServiceProvider\AbstractServiceProvider;

class ConfigServiceProvider extends AbstractServiceProvider
{
    /**
     * @var array
     */
    protected $provides = [
        'config'
    ];

    /**
     * {@inheritdoc}
     */
    public function register()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $this->getContainer()->share('config', function () {
            return [
                'environment'    => $_ENV['ENV'],
                'base_url'       => $_ENV['BASE_URL'],
                'logger'         => $_ENV['LOGGER'],
                'slack_api'      => $_ENV['SLACK_API'],
                'slack_channel'  => $_ENV['SLACK_CHANNEL'],
                'slack_bot_name' => $_ENV['SLACK_BOT_NAME'],
                'database'     => [
                    'host'     => $_ENV['DB_HOST'],
                    'port'     => $_ENV['DB_PORT'],
                    'user'     => $_ENV['DB_USER'],
                    'password' => $_ENV['DB_PASS'],
                    'schema'   => $_ENV['DB_NAME']
                ],
                'database_data' => [
                    'host'     => $_ENV['DB_HOST'],
                    'port'     => $_ENV['DB_PORT'],
                    'user'     => $_ENV['DB_USER'],
                    'password' => $_ENV['DB_PASS'],
                    'schema'   => $_ENV['DB_NAME_DATA']
                ],
                'database_archive' => [
                    'host'     => $_ENV['DB_ARCHIVE_HOST'],
                    'port'     => $_ENV['DB_ARCHIVE_PORT'],
                    'user'     => $_ENV['DB_ARCHIVE_USER'],
                    'password' => $_ENV['DB_ARCHIVE_PASS'],
                    'schema'   => $_ENV['DB_ARCHIVE_NAME']
                ],
                'redis'        => [
                    'enabled'  => $_ENV['REDIS_ENABLED'],
                    'host'     => $_ENV['REDIS_HOST'],
                    'port'     => $_ENV['REDIS_PORT'],
                    'pass'     => $_ENV['REDIS_PASS'],
                    'db'       => $_ENV['REDIS_DB'],
                ],
                'servers'           => [1, 10, 13, 17, 25, 1000, 2000],
                'zones'             => [2, 4, 6, 8],
                'classes'           => [1, 3, 4, 5, 6, 7, 8, 10, 11, 12, 13, 14, 15, 17, 18, 19, 20, 21],
                'classesGroups' => [
                    'infiltrator' => [1, 8, 15],
                    'la'          => [3, 10, 17],
                    'medic'       => [4, 11, 18],
                    'engineer'    => [5, 12, 19],
                    'ha'          => [6, 13, 20],
                    'max'         => [7, 14, 21]
                ],
                'classesFactions' => [
                    'nc' => [1, 3, 4, 5, 6, 7],
                    'tr' => [8, 10, 11, 12, 13, 14],
                    'vs' => [15, 17, 18, 19, 20, 21]
                ],
                'factions'          => ['vs', 'nc', 'tr', 'draw'],
                'brackets'          => ['MOR', 'AFT', 'PRI'],
                'db_query_debug'    => $_ENV['DB_QUERY_DEBUG'],
                'commands_path'     => $_ENV['COMMANDS_PATH'],
                'census_service_id' => $_ENV['CENSUS_SERVICE_ID']
            ];
        });
    }
}


1			<?php
2
3			namespace Ps2alerts\Api\ServiceProvider;
4
5			use League\Container\ServiceProvider\AbstractServiceProvider;
6
7			class ConfigServiceProvider extends AbstractServiceProvider
8			{
9			/**
10			* @var array
11			*/
12			protected $provides = [
13			'config'
14			];
15
16			/**
17			* {@inheritdoc}
18			*/
19			public function register()
			0 ignored issues – show Coding Style introduced 2017-08-24 20:58 UTC by Report Bug Copy Issue Report `register` uses the super-global variable `$_ENV` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
20			{
21			$this->getContainer()->share('config', function () {
22			return [
23			'environment' => $_ENV['ENV'],
24			'base_url' => $_ENV['BASE_URL'],
25			'logger' => $_ENV['LOGGER'],
26			'slack_api' => $_ENV['SLACK_API'],
27			'slack_channel' => $_ENV['SLACK_CHANNEL'],
28			'slack_bot_name' => $_ENV['SLACK_BOT_NAME'],
29			'database' => [
30			'host' => $_ENV['DB_HOST'],
31			'port' => $_ENV['DB_PORT'],
32			'user' => $_ENV['DB_USER'],
33			'password' => $_ENV['DB_PASS'],
34			'schema' => $_ENV['DB_NAME']
35			],
36			'database_data' => [
37			'host' => $_ENV['DB_HOST'],
38			'port' => $_ENV['DB_PORT'],
39			'user' => $_ENV['DB_USER'],
40			'password' => $_ENV['DB_PASS'],
41			'schema' => $_ENV['DB_NAME_DATA']
42			],
43			'database_archive' => [
44			'host' => $_ENV['DB_ARCHIVE_HOST'],
45			'port' => $_ENV['DB_ARCHIVE_PORT'],
46			'user' => $_ENV['DB_ARCHIVE_USER'],
47			'password' => $_ENV['DB_ARCHIVE_PASS'],
48			'schema' => $_ENV['DB_ARCHIVE_NAME']
49			],
50			'redis' => [
51			'enabled' => $_ENV['REDIS_ENABLED'],
52			'host' => $_ENV['REDIS_HOST'],
53			'port' => $_ENV['REDIS_PORT'],
54			'pass' => $_ENV['REDIS_PASS'],
55			'db' => $_ENV['REDIS_DB'],
56			],
57			'servers' => [1, 10, 13, 17, 25, 1000, 2000],
58			'zones' => [2, 4, 6, 8],
59			'classes' => [1, 3, 4, 5, 6, 7, 8, 10, 11, 12, 13, 14, 15, 17, 18, 19, 20, 21],
60			'classesGroups' => [
61			'infiltrator' => [1, 8, 15],
62			'la' => [3, 10, 17],
63			'medic' => [4, 11, 18],
64			'engineer' => [5, 12, 19],
65			'ha' => [6, 13, 20],
66			'max' => [7, 14, 21]
67			],
68			'classesFactions' => [
69			'nc' => [1, 3, 4, 5, 6, 7],
70			'tr' => [8, 10, 11, 12, 13, 14],
71			'vs' => [15, 17, 18, 19, 20, 21]
72			],
73			'factions' => ['vs', 'nc', 'tr', 'draw'],
74			'brackets' => ['MOR', 'AFT', 'PRI'],
75			'db_query_debug' => $_ENV['DB_QUERY_DEBUG'],
76			'commands_path' => $_ENV['COMMANDS_PATH'],
77			'census_service_id' => $_ENV['CENSUS_SERVICE_ID']
78			];
79			});
80			}
81			}
82

Maelstromeous / ps2alerts-api

ConfigServiceProvider::register() A last analyzed 2018-01-02 23:34 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

ConfigServiceProvider::register() A
last analyzed 2018-01-02 23:34 UTC