AlertCombatEndpointController::getCombatTotals() - Code Metrics - Maelstromeous/ps2alerts-api - Measure and Improve Code Quality continuously with Scrutinizer

AlertCombatEndpointController::getCombatTotals() C
last analyzed 2018-01-02 23:34 UTC

↳ Parent: AlertCombatEndpointController

Complexity

Conditions	11
Paths	9

Size

Total Lines	92
Code Lines	56

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	11
eloc	56
nc	9
nop	2
dl	0
loc	92
rs	5.2653
c	1
b	0
f	0

How to fix Long Method Complexity

<?php

namespace Ps2alerts\Api\Controller\Endpoint\Alerts;

use Ps2alerts\Api\Exception\InvalidArgumentException;
use Ps2alerts\Api\Repository\Metrics\CombatRepository;
use Ps2alerts\Api\Repository\Metrics\ClassRepository;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Message\ResponseInterface;

class AlertCombatEndpointController extends AlertEndpointController
{
    public function __construct(
        classRepository $classRepository,
        combatRepository $combatRepository
    ) {
        $this->classRepository  = $classRepository;

        $this->combatRepository = $combatRepository;

    }

    /**
     * Retrieves combat totals on a global and per-server basis
     * @param  ServerRequestInterface $request
     * @param  ResponseInterface      $response
     * @return ResponseInterface
     */
    public function getCombatTotals(ServerRequestInterface $request, ResponseInterface $response)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        try {
            $servers = $this->validateQueryStringArguments($_GET['servers'], 'servers');
            $zones   = $this->validateQueryStringArguments($_GET['zones'], 'zones');
        } catch (InvalidArgumentException $e) {
            return $this->respondWithError($e->getMessage(), self::CODE_WRONG_ARGS);
        }

        $serversExploded = explode(',', $servers);
        $zonesExploded = explode(',', $zones);
        $zonesIn = $this->combatRepository->generateWhereInString($zonesExploded);


        $results = [];

        foreach ($serversExploded as $server) {
            $metrics = ['kills', 'deaths', 'teamkills', 'suicides', 'headshots'];
            $factions = ['vs', 'nc', 'tr'];

            // Check if we have an entry in Redis
            $data = $this->getRedisUtility()->checkRedis('api', 'combatTotals', "{$server}-data");
            $dataArchive = $this->getRedisUtility()->checkRedis('api', 'combatTotals', "{$server}-dataArchive");

            $mergedArray = [];

            if (! $data || ! $dataArchive) {
                $sums = [];
                foreach ($metrics as $metric) {
                    foreach ($factions as $faction) {
                        $dbMetric = $metric . strtoupper($faction); // e.g. killsVS
                        $dataMetric = $metric . strtoupper($faction); // e.g. killsVS

                        // Handle teamkills inconsistency
                        if ($metric === 'teamkills') {
                            $dbMetric = 'teamKills' . strtoupper($faction);
                        }
                        $sums[] = "SUM(factions.{$dbMetric}) AS $dataMetric";
                    }

                    // Totals
                    $dbMetric = 'total' . ucfirst($metric); // e.g. killsVS
                    $dataMetric = 'total' . ucfirst($metric); // e.g. killsVS

                    // Handle teamkills inconsistency
                    if ($metric === 'teamkills') {
                        $dbMetric = 'totalTKs'; // Christ knows why
                    }
                    $sums[] = "SUM(factions.{$dbMetric}) AS $dataMetric";
                }

                $query = $this->combatRepository->newQuery('single', true);

                $query->cols($sums);
                $query->from('ws_factions AS factions');
                $query->join(
                    'INNER',
                    'ws_results AS results',
                    "factions.resultID = results.ResultID"
                );
                $query->where('results.ResultServer = ?', $server);
                $query->where("results.ResultAlertCont IN {$zonesIn}");
                $query->where('results.Valid = ?', 1);

                $data = $this->combatRepository->fireStatementAndReturn($query, true);

                $dataArchive = $this->combatRepository->fireStatementAndReturn($query, true, false, true);


                // Store the results in Redis
                $this->getRedisUtility()->storeInRedis('api', 'combatTotals', "{$server}-data", $data, 3600);
                $this->getRedisUtility()->storeInRedis('api', 'combatTotals', "{$server}-dataArchive", $dataArchive, 3600);
            }

            $metrics = ['kills', 'deaths', 'teamkills', 'suicides', 'headshots'];
            $factions = ['vs', 'nc', 'tr'];

            // Merge the two arrays together
            foreach ($metrics as $metric) {
                // Tot up totals
                $dbMetric = 'total' . ucfirst($metric);
                $mergedArray['totals'][$metric] = (int) $data[$dbMetric] + (int) $dataArchive[$dbMetric];
                $results['all']['totals'][$metric] += $mergedArray['totals'][$metric];

                foreach ($factions as $faction) {
                    $dbMetric = $metric . strtoupper($faction);
                    $mergedArray[$metric][$faction] = (int) $data[$dbMetric] + (int) $dataArchive[$dbMetric];
                    $results['all'][$metric][$faction] += $mergedArray[$metric][$faction];
                }
            }

            $results[$server] = $mergedArray;
        }

        return $this->respondWithData($results);
    }

    public function getClassTotals(ServerRequestInterface $request, ResponseInterface $response)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        try {
            $servers = $this->validateQueryStringArguments($_GET['servers'], 'servers');
            $zones   = $this->validateQueryStringArguments($_GET['zones'], 'zones');
        } catch (InvalidArgumentException $e) {
            return $this->respondWithError($e->getMessage(), self::CODE_WRONG_ARGS);
        }

        $serversExploded = explode(',', $servers);
        $zonesExploded = explode(',', $zones);
        $zonesIn = $this->combatRepository->generateWhereInString($zonesExploded);

        $classes = $this->getConfig()['classes'];

        // Build classes array
        foreach ($classes as $class) {
            $results['totals'][$class] = [
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
                'kills'     => 0,
                'deaths'    => 0,
                'teamkills' => 0,
                'suicides'  => 0,
                'kdr'       => 0
            ];
        }

        foreach ($serversExploded as $server) {
            // Check if we have an entry in Redis
            $data = $this->getRedisUtility()->checkRedis('api', 'classCombat', "{$server}-data", 'object');
            $dataArchive = $this->getRedisUtility()->checkRedis('api', 'classCombat', "{$server}-dataArchive", 'object');

            // If data needs a pull
            if (! $data || ! $dataArchive) {
                $query = $this->combatRepository->newQuery('single', true);

                $query->cols([
                        'classID',
                        'results.ResultServer AS server',
                        'SUM(kills) AS kills',
                        'SUM(deaths) AS deaths',
                        'SUM(teamkills) AS teamkills',
                        'SUM(suicides) AS suicides'
                ]);
                $query->from('ws_classes AS classes');
                $query->join(
                    'INNER',
                    'ws_results AS results',
                    "classes.resultID = results.ResultID"
                );
                $query->where('results.ResultServer = ?', $server);
                $query->where("results.ResultAlertCont IN {$zonesIn}");
                $query->where('results.Valid = ?', 1);
                $query->where('classID != ?', 0);
                $query->groupBy(['classID, server']);

                $data = $this->classRepository->fireStatementAndReturn($query, false, true);

                $dataArchive = $this->classRepository->fireStatementAndReturn($query, false, true, true);


                // Store the results in Redis
                $this->getRedisUtility()->storeInRedis('api', 'classCombat', "{$server}-data", $data, 3600);
                $this->getRedisUtility()->storeInRedis('api', 'classCombat', "{$server}-dataArchive", $dataArchive, 3600);
            }

            // Typecase into ints and increase totals
            $metrics = ['kills', 'deaths', 'teamkills', 'suicides'];
            foreach ($data as $row) {

                $row->classID   = (int) $row->classID;
                $row->server   = (int) $row->server;
                $classGroup = $this->findClassGrouping($row->classID);
                $faction = $this->findClassFaction($row->classID);

                foreach ($metrics as $metric) {
                    $row->$metric = (int) $row->$metric;
                    $results[$row->server][$row->classID][$metric] += $row->$metric;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
                    $results['totals'][$row->classID][$metric] += $row->$metric;
                    $results['byMetric'][$metric][$row->classID] += $row->$metric;
                    $results['byMetric'][$metric]['total'] += $row->$metric;

                    // Assign to class group
                    $results['classGroups']['totals'][$classGroup][$metric] += $row->$metric;
                    $results['classGroups'][$row->server][$classGroup][$metric] += $row->$metric;
                    $results['classGroupFactionMetric'][$classGroup][$faction][$metric] += $row->$metric;
                }
            }

            foreach ($dataArchive as $row) {

                $row->classID   = (int) $row->classID;
                $row->server   = (int) $row->server;

                foreach ($metrics as $metric) {
                    $row->$metric = (int) $row->$metric;
                    $results[$row->server][$row->classID][$metric] += $row->$metric;
                    $results['totals'][$row->classID][$metric] += $row->$metric;
                    $results['byMetric'][$metric][$row->classID] += $row->$metric;
                    $results['byMetric'][$metric]['total'] += $row->$metric;

                    // Assign to class group
                    $classGroup = $this->findClassGrouping($row->classID);
                    $results['classGroups']['totals'][$classGroup][$metric] += $row->$metric;
                    $results['classGroups'][$row->server][$classGroup][$metric] += $row->$metric;

                    $faction = $this->findClassFaction($row->classID);
                    $results['classGroupFactionMetric'][$classGroup][$faction][$metric] += $row->$metric;
                }
            }

            // Calculate KDRs
            foreach ($results['byMetric']['kills'] as $class => $kills) {
                $results['byMetric']['kdr'][$class] = $kills / $results['byMetric']['deaths'][$class];

                if (empty($results['byMetric']['kdr']['max'])) {
                    $results['byMetric']['kdr']['max'] = $results['byMetric']['kdr'][$class];
                }

                if ($results['byMetric']['kdr'][$class] > $results['byMetric']['kdr']['max']) {
                    $results['byMetric']['kdr']['max'] = $results['byMetric']['kdr'][$class];
                }
            }

            foreach ($results['classGroups'] as $server => $classArray) {

                foreach ($classArray as $class => $metrics) {
                    $results['classGroups'][$server][$class]['kdr'] = $metrics['kills'] / $metrics['deaths'];
                }
            }

            foreach ($results['classGroupFactionMetric'] as $class => $factions) {

                foreach ($factions as $faction => $metrics) {
                    $results['classGroupFactionMetric'][$class][$faction]['kdr'] = $metrics['kills'] / $metrics['deaths'];
                }
            }
        }

        return $this->respondWithData($results);
    }

    private function findClassGrouping($classID)
    {
        $classGroups = $this->getConfig()['classesGroups'];

        foreach ($classGroups as $group => $ids) {
            foreach ($ids as $id) {
                if ($classID === $id) {
                    return $group;
                }
            }
        }

        return false;
    }

    private function findClassFaction($classID)
    {
        $classesFactions = $this->getConfig()['classesFactions'];

        foreach ($classesFactions as $faction => $ids) {
            foreach ($ids as $id) {
                if ($classID === $id) {
                    return $faction;
                }
            }
        }

        return false;
    }
}


1			<?php
2
3			namespace Ps2alerts\Api\Controller\Endpoint\Alerts;
4
5			use Ps2alerts\Api\Exception\InvalidArgumentException;
6			use Ps2alerts\Api\Repository\Metrics\CombatRepository;
7			use Ps2alerts\Api\Repository\Metrics\ClassRepository;
8			use Psr\Http\Message\ServerRequestInterface;
9			use Psr\Http\Message\ResponseInterface;
10
11			class AlertCombatEndpointController extends AlertEndpointController
12			{
13			public function __construct(
14			classRepository $classRepository,
15			combatRepository $combatRepository
16			) {
17			$this->classRepository = $classRepository;
			0 ignored issues – show Bug introduced 2017-07-16 14:16 UTC by Report Bug Copy Issue Report The property `classRepository` does not seem to exist. Did you mean `repository`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
18			$this->combatRepository = $combatRepository;
			0 ignored issues – show Bug introduced 2017-07-16 14:16 UTC by Report Bug Copy Issue Report The property `combatRepository` does not seem to exist. Did you mean `repository`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
19			}
20
21			/**
22			* Retrieves combat totals on a global and per-server basis
23			* @param ServerRequestInterface $request
24			* @param ResponseInterface $response
25			* @return ResponseInterface
26			*/
27			public function getCombatTotals(ServerRequestInterface $request, ResponseInterface $response)
			0 ignored issues – show Unused Code introduced 2017-08-24 20:58 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-08-24 20:58 UTC by Report Bug Copy Issue Report The parameter `$response` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Coding Style introduced 2017-08-24 20:58 UTC by Report Bug Copy Issue Report `getCombatTotals` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
28			{
29			try {
30			$servers = $this->validateQueryStringArguments($_GET['servers'], 'servers');
31			$zones = $this->validateQueryStringArguments($_GET['zones'], 'zones');
32			} catch (InvalidArgumentException $e) {
33			return $this->respondWithError($e->getMessage(), self::CODE_WRONG_ARGS);
34			}
35
36			$serversExploded = explode(',', $servers);
37			$zonesExploded = explode(',', $zones);

Maelstromeous / ps2alerts-api

AlertCombatEndpointController::getCombatTotals() C last analyzed 2018-01-02 23:34 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Available Fixes

Duplication Side-by-Side

Filter issues like

AlertCombatEndpointController::getCombatTotals() C
last analyzed 2018-01-02 23:34 UTC