Ps2alerts\Api\Controller\Endpoint\Leaderboards\LeaderboardLadderEndpointController

Complexity

Total Complexity

8

Size/Duplication

Total Lines	86
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	playerLadder()	0	14	1
B	update()	0	33	4
A	lastUpdate()	0	18	3

<?php

// @todo Go over this ENTIRE file again as there's been major refactors since and it's likely broken!

namespace Ps2alerts\Api\Controller\Endpoint\Leaderboards;

use Ps2alerts\Api\Controller\Endpoint\AbstractEndpointController;
use Psr\Http\Message\ServerRequestInterface;
use Psr\Http\Message\ResponseInterface;

class LeaderboardLadderEndpointController extends AbstractEndpointController
{
    public function playerLadder(ServerRequestInterface $request, ResponseInterface $response, array $args)

The parameter $request is not used and could be removed.

The parameter $response is not used and could be removed.

    {
        $redis = $this->getRedisDriver();

The method getRedisDriver() does not seem to exist on object<Ps2alerts\Api\Controller\Endpoint\Leaderboards\LeaderboardLadderEndpointController>.

        $metric = $args['metric'];
        $server = $args['server'];

        $list = "ps2alerts:api:leaderboards:players:{$metric}:listById-{$server}";

        var_dump($list);

var_dump($list); looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data.

        $entries = $redis->get($list);

        var_dump($entries);
    }

    /**
     * Prompts the Leaderboard:Check command to resync the leaderboards
     *
     * @param  ServerRequestInterface  $request
     * @param  ResponseInterface $response
     *
     * @return ResponseInterface
     */
    public function update(ServerRequestInterface $request, ResponseInterface $response)

update uses the super-global variable $_SERVER which is generally not recommended.

update uses the super-global variable $_GET which is generally not recommended.

    {
        $config = $this->getConfig();

$config is not used, you could remove the assignment.

        // Only accept commands from internal IP
        $ip = $request->getClientIp();

The method getClientIp() does not seem to exist on object<Psr\Http\Message\ServerRequestInterface>.

        if ($ip !== $_SERVER['SERVER_ADDR']) {
            $response->setStatusCode(404);

It seems like you code against a concrete implementation and not the interface Psr\Http\Message\ResponseInterface as the method setStatusCode() does only exist in the following implementations of said interface: Zend\Diactoros\Response, Zend\Diactoros\Response\EmptyResponse, Zend\Diactoros\Response\HtmlResponse, Zend\Diactoros\Response\JsonResponse, Zend\Diactoros\Response\RedirectResponse, Zend\Diactoros\Response\TextResponse.

            return $response;
        }

        $server = $_GET['server'];

        $redis = $this->getRedisDriver();

The method getRedisDriver() does not seem to exist on object<Ps2alerts\Api\Controller\Endpoint\Leaderboards\LeaderboardLadderEndpointController>.

        $key = "ps2alerts:api:leaderboards:status:{$server}";

        // If we have a key, change the flag to force exists so the cronjob can run
        if ($redis->exists($key)) {
            $data = json_decode($redis->get($key));

             // Ignore if already flagged as being updated
            if ($data->beingUpdated == 0) {
                $data->forceUpdate = 1;
                $redis->set($key, json_encode($data));
            }
        } else {

This else statement is empty and can be removed.

            // Panic.
        }

        $response = $response->withStatus(202);
        return $response;
    }

    /**
     * Returns a list of times that a server leaderboard has been updated
     *
     * @param  ServerRequestInterface  $request
     * @param  ResponseInterface $response
     *
     * @return ResponseInterface
     */
    public function lastUpdate(ServerRequestInterface $request, ResponseInterface $response)

The parameter $request is not used and could be removed.

The parameter $response is not used and could be removed.

    {
        $config = $this->getConfig();
        $redis = $this->getRedisDriver();

The method getRedisDriver() does not seem to exist on object<Ps2alerts\Api\Controller\Endpoint\Leaderboards\LeaderboardLadderEndpointController>.

        $data = [];

        foreach($config['servers'] as $server) {
            $key = "ps2alerts:api:leaderboards:status:{$server}";

            if ($redis->exists($key)) {
                $entry = json_decode($redis->get($key));
                $data[$server] = $this->createItem($entry, new LeaderboardUpdatedTransformer);

The method createItem() does not seem to exist on object<Ps2alerts\Api\Controller\Endpoint\Leaderboards\LeaderboardLadderEndpointController>.

            }
        }

        return $this->respondWithData($data);
    }
}