| Conditions | 8 |
| Total Lines | 56 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 3 | ||
| Bugs | 0 | Features | 1 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | from modules.get_image import get_image |
||
| 32 | def kekify(bot, update, kek_param): |
||
| 33 | try: |
||
| 34 | if kek_param == "-l" or kek_param == "": |
||
| 35 | crop = "50%x100% " |
||
| 36 | piece_one = "result-0.jpg " |
||
| 37 | piece_two = "result-1.jpg " |
||
| 38 | flip = "-flop " |
||
| 39 | order = kek_folder + piece_one + kek_folder + piece_two |
||
| 40 | append = "+append " |
||
| 41 | result = "kek-left.jpg" |
||
| 42 | elif kek_param == "-r": |
||
| 43 | crop = "50%x100% " |
||
| 44 | piece_one = "result-1.jpg " |
||
| 45 | piece_two = "result-0.jpg " |
||
| 46 | flip = "-flop " |
||
| 47 | order = kek_folder + piece_two + kek_folder + piece_one |
||
| 48 | append = "+append " |
||
| 49 | result = "kek-right.jpg" |
||
| 50 | elif kek_param == "-t": |
||
| 51 | crop = "100%x50% " |
||
| 52 | piece_one = "result-0.jpg " |
||
| 53 | piece_two = "result-1.jpg " |
||
| 54 | flip = "-flip " |
||
| 55 | order = kek_folder + piece_one + kek_folder + piece_two |
||
| 56 | append = "-append " |
||
| 57 | result = "kek-top.jpg" |
||
| 58 | elif kek_param == "-b": |
||
| 59 | crop = "100%x50% " |
||
| 60 | piece_one = "result-1.jpg " |
||
| 61 | piece_two = "result-0.jpg " |
||
| 62 | flip = "-flip " |
||
| 63 | order = kek_folder + piece_two + kek_folder + piece_one |
||
| 64 | append = "-append " |
||
| 65 | result = "kek-bot.jpg" |
||
| 66 | elif kek_param == "-m": |
||
| 67 | kekify(bot, update, "-l") |
||
| 68 | kekify(bot, update, "-r") |
||
| 69 | kekify(bot, update, "-t") |
||
| 70 | kekify(bot, update, "-b") |
||
| 71 | append_lr = "convert " + kek_folder + "kek-left.jpg " + kek_folder + "kek-right.jpg +append " + kek_folder + "kek-lr-temp.jpg" |
||
| 72 | subprocess.run(append_lr, shell=True) |
||
| 73 | append_tb = "convert " + kek_folder + "kek-top.jpg " + kek_folder + "kek-bot.jpg +append " + kek_folder + "kek-tb-temp.jpg" |
||
| 74 | subprocess.run(append_tb, shell=True) |
||
| 75 | append_all = "convert " + kek_folder + "kek-lr-temp.jpg " + kek_folder + "kek-tb-temp.jpg -append " + kek_folder + "multikek.jpg" |
||
| 76 | subprocess.run(append_all, shell=True) |
||
| 77 | result = "multikek.jpg" |
||
| 78 | return result |
||
| 79 | cut = "convert " + kek_folder + "original.jpg -crop " + crop + kek_folder + "result.jpg" |
||
| 80 | subprocess.run(cut, shell=True) |
||
| 81 | mirror = "convert " + kek_folder + piece_one + flip + kek_folder + piece_two |
||
| 82 | subprocess.run(mirror, shell=True) |
||
| 83 | append = "convert " + order + append + kek_folder + result |
||
| 84 | subprocess.run(append, shell=True) |
||
| 85 | return result |
||
| 86 | except: |
||
| 87 | update.message.reply_text("Unknown kek parameter.\nUse -l, -r, -t, -b or -m") |
||
| 88 |