MaartenStaa / laravel-41-route-caching

src/Router.php

<?php namespace MaartenStaa\Routing;

/**
 * Copyright (c) 2015 by Maarten Staa.
 *
 * Some rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions are
 * met:
 *
 *     * Redistributions of source code must retain the above copyright
 *       notice, this list of conditions and the following disclaimer.
 *
 *     * Redistributions in binary form must reproduce the above
 *       copyright notice, this list of conditions and the following
 *       disclaimer in the documentation and/or other materials provided
 *       with the distribution.
 *
 *     * The names of the contributors may not be used to endorse or
 *       promote products derived from this software without specific
 *       prior written permission.
 *
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 */

use Closure;
use Illuminate\Container\Container;
use Illuminate\Events\Dispatcher;
use Illuminate\Routing\Router as LaravelRouter;

class Router extends LaravelRouter
{
    /**
     * Version of the cache key
     *
     * @var string
     */
    protected $cacheVersion = 'v1';

    /**
     * Create a new Router instance.
     *
     * @param \Illuminate\Events\Dispatcher        $events
     * @param \Illuminate\Container\Container|null $container
     */
    public function __construct(Dispatcher $events, Container $container = null)
    {
        parent::__construct($events, $container);

        $this->routes = new RouteCollection;
    }

    /**
     * Indicate that the routes that are defined in the given callback
     * should be cached.
     *
     * @param  string  $filename
     * @param  Closure $callback
     * @param  int     $cacheMinutes
     * @return string

Should the return type not be null|string?

     */
    public function cache($filename, Closure $callback, $cacheMinutes = 1440)
    {
        // If $cacheMinutes is 0 or lower, there is no need to cache anything.
        if ($cacheMinutes <= 0) {
            // Call closure to define routes that should be cached.
            call_user_func($callback, $this);

            // No cache key.
            return null;
        }

        $cacher = $this->container['cache'];
        $cacheKey = $this->getCacheKey($filename);

        // Check if the current route group is cached.
        if (($cache = $cacher->get($cacheKey)) !== null) {
            $this->routes->restoreRouteCache($cache);

It seems like you code against a specific sub-type and not the parent class Illuminate\Routing\RouteCollection as the method restoreRouteCache() does only exist in the following sub-classes of Illuminate\Routing\RouteCollection: MaartenStaa\Routing\RouteCollection. Maybe you want to instanceof check for one of these explicitly?

        } else {
            // Back up current RouteCollection contents.
            $this->routes->saveRouteCollection();

It seems like you code against a specific sub-type and not the parent class Illuminate\Routing\RouteCollection as the method saveRouteCollection() does only exist in the following sub-classes of Illuminate\Routing\RouteCollection: MaartenStaa\Routing\RouteCollection. Maybe you want to instanceof check for one of these explicitly?

            // Call closure to define routes that should be cached.
            call_user_func($callback, $this);

            // Put routes in cache.
            $cache = $this->routes->getCacheableRoutes();

It seems like you code against a specific sub-type and not the parent class Illuminate\Routing\RouteCollection as the method getCacheableRoutes() does only exist in the following sub-classes of Illuminate\Routing\RouteCollection: MaartenStaa\Routing\RouteCollection. Maybe you want to instanceof check for one of these explicitly?

            $cacher->put($cacheKey, $cache, $cacheMinutes);

            // And restore the routes that shouldn't be cached.
            $this->routes->restoreRouteCollection();

It seems like you code against a specific sub-type and not the parent class Illuminate\Routing\RouteCollection as the method restoreRouteCollection() does only exist in the following sub-classes of Illuminate\Routing\RouteCollection: MaartenStaa\Routing\RouteCollection. Maybe you want to instanceof check for one of these explicitly?

        }

        return $cacheKey;
    }

    /**
     * Clear the cached data for the given routes file.
     *
     * @param string $filename
     */
    public function clearCache($filename)
    {
        $cacher = $this->container['cache'];

        $cacher->forget($this->getCacheKey($filename));
    }

    /**
     * Get the key under which the routes cache for the given file should be stored.
     *
     * @param  string $filename
     * @return string
     */
    protected function getCacheKey($filename)
    {
        return 'routes.cache.'.$this->cacheVersion.'.'.md5($filename).filemtime($filename);
    }

    /**
     * Determine if the action is routing to a controller.
     *
     * @param  array  $action
     * @return bool
     */
    public function routingToController($action)
    {
        return parent::routingToController($action);
    }

    /**
     * Add a controller based route action to the action array.
     *
     * @param  array|string  $action
     * @return array
     */
    protected function getControllerAction($action)
    {
        if (is_string($action) === true) {
            $action = array('uses' => $action);
        }

        // Here we'll get an instance of this controller dispatcher and hand it off to
        // the Closure so it will be used to resolve the class instances out of our
        // IoC container instance and call the appropriate methods on the class.
        if (count($this->groupStack) > 0) {
            $action['uses'] = $this->prependGroupUses($action['uses']);
        }

        // Here we'll get an instance of this controller dispatcher and hand it off to
        // the Closure so it will be used to resolve the class instances out of our
        // IoC container instance and call the appropriate methods on the class.
        $action['controller'] = $action['uses'];

        $closure = $action['uses'];

        return array_set($action, 'uses', $closure);
    }

    /**
     * Replace the string action in the given array with a Closure to call.
     *
     * @param  array $action
     * @return array
     */
    public function makeControllerActionClosure(array $action)
    {
        $closure = $this->getClassClosure($action['uses']);

        return array_set($action, 'uses', $closure);
    }

    /**
     * Create a new route instance.
     *
     * @param  array|string  $methods
     * @param  string  $uri
     * @param  mixed   $action
     * @return \Illuminate\Routing\Route
     */
    protected function createRoute($methods, $uri, $action)
    {
        // If the route is routing to a controller we will parse the route action into
        // an acceptable array format before registering it and creating this route
        // instance itself. We need to build the Closure that will call this out.
        if ($this->routingToController($action) === true) {
            $action = $this->getControllerAction($action);
        }

        $route = $this->newRoute(
            $methods,
            $uri = $this->prefix($uri),
            $action
        );

        // If we have groups that need to be merged, we will merge them now after this
        // route has already been created and is ready to go. After we're done with
        // the merge we will be ready to return the route back out to the caller.
        if (empty($this->groupStack) === false) {
            $this->mergeController($route);
        }

        $this->addWhereClausesToRoute($route);

        return $route;
    }

    /**
     * Create a new Route object.
     *
     * @param  array|string              $methods
     * @param  string                    $uri
     * @param  mixed                     $action
     * @return \Illuminate\Routing\Route
     */
    protected function newRoute($methods, $uri, $action)
    {
        return new Route($methods, $uri, $action);

It seems like $methods defined by parameter $methods on line 227 can also be of type string; however, Illuminate\Routing\Route::__construct() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * Add the necessary where clauses to the route based on its initial registration.
     *
     * @param  \Illuminate\Routing\Route  $route
     * @return \Illuminate\Routing\Route
     */
    protected function addWhereClausesToRoute($route)
    {
        $route->where(
            array_merge($this->patterns, array_get($route->getAction(), 'where', array()))
        );
        return $route;
    }
}