Ma27\ApiKeyAuthenticationBundle\Service\Auth\ApiKeyAuthenticationHandler

Complexity

Total Complexity

20

Size/Duplication

Total Lines	246
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	10

Test Coverage

Coverage

82.61%

Importance

Changes

0

13 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	15	1
A	removeSession()	0	14	2
A	getOm()	0	4	1
A	getPasswordHasher()	0	4	1
A	getKeyFactory()	0	4	1
A	getEventDispatcher()	0	4	1
A	getModelName()	0	4	1
A	getClassMetadata()	0	4	1
A	resolveObject()	0	6	1
A	validateCredentials()	0	7	2
A	buildEventObject()	0	9	2
B	authenticate()	0	38	4
A	buildKey()	0	12	2

<?php

namespace Ma27\ApiKeyAuthenticationBundle\Service\Auth;

use Doctrine\Common\Persistence\ObjectManager;
use Ma27\ApiKeyAuthenticationBundle\Event\OnAuthenticationEvent;
use Ma27\ApiKeyAuthenticationBundle\Event\OnInvalidCredentialsEvent;
use Ma27\ApiKeyAuthenticationBundle\Event\OnLogoutEvent;
use Ma27\ApiKeyAuthenticationBundle\Exception\CredentialException;
use Ma27\ApiKeyAuthenticationBundle\Ma27ApiKeyAuthenticationEvents;
use Ma27\ApiKeyAuthenticationBundle\Service\Key\KeyFactoryInterface;
use Ma27\ApiKeyAuthenticationBundle\Service\Mapping\ClassMetadata;
use Ma27\ApiKeyAuthenticationBundle\Service\Password\PasswordHasherInterface;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;

/**
 * Concrete handler for api key authorization.
 */
class ApiKeyAuthenticationHandler implements AuthenticationHandlerInterface
{
    /**
     * @var ObjectManager
     */
    private $om;

    /**
     * @var PasswordHasherInterface
     */
    private $passwordHasher;

    /**
     * @var KeyFactoryInterface
     */
    private $keyFactory;

    /**
     * @var EventDispatcherInterface
     */
    private $eventDispatcher;

    /**
     * @var string
     */
    private $modelName;

    /**
     * @var ClassMetadata
     */
    private $classMetadata;

    /**
     * Constructor.
     *
     * @param ObjectManager            $om
     * @param PasswordHasherInterface  $passwordHasher
     * @param KeyFactoryInterface      $keyFactory
     * @param EventDispatcherInterface $dispatcher
     * @param string                   $modelName
     * @param ClassMetadata            $metadata
     */
    public function __construct(
        ObjectManager $om,
        PasswordHasherInterface $passwordHasher,
        KeyFactoryInterface $keyFactory,
        EventDispatcherInterface $dispatcher,
        $modelName,
        ClassMetadata $metadata
    ) {
        $this->om = $om;
        $this->passwordHasher = $passwordHasher;
        $this->keyFactory = $keyFactory;
        $this->eventDispatcher = $dispatcher;
        $this->modelName = (string) $modelName;
        $this->classMetadata = $metadata;
    }

    /**
     * {@inheritdoc}
     *
     * @throws \InvalidArgumentException If the `login` or `password` property is missing.
     * @throws CredentialException       If the credentials couldn't be validated.
     */
    public function authenticate(array $credentials)
    {
        $loginProperty = $this->classMetadata->getPropertyName(ClassMetadata::LOGIN_PROPERTY);
        $passwordProperty = $this->classMetadata->getPropertyName(ClassMetadata::PASSWORD_PROPERTY);

        if (!array_key_exists($passwordProperty, $credentials)) {
            throw new \InvalidArgumentException(sprintf(
                'Unable to find password property "%s" in credential set!',
                $passwordProperty
            ));
        }

        if (!array_key_exists($loginProperty, $credentials)) {
            throw new \InvalidArgumentException(sprintf(
                'Unable to find login property "%s" in credential set!',
                $loginProperty
            ));
        }

        $object = $this->resolveObject($loginProperty, $credentials);

It seems like $loginProperty defined by $this->classMetadata->getPropertyName(\Ma27\ApiKeyAuthenticationBundle\Service\Mapping\ClassMetadata::LOGIN_PROPERTY) on line 85 can also be of type null or object<ReflectionProperty>; however, Ma27\ApiKeyAuthenticationBundle\Service\Auth\ApiKeyAuthenticationHandler::resolveObject() does only seem to accept string, maybe add an additional type check?

        if (!$this->validateCredentials($object, $credentials[$passwordProperty])) {

It seems like $object defined by $this->resolveObject($loginProperty, $credentials) on line 102 can also be of type null; however, Ma27\ApiKeyAuthenticationBundle\Service\Auth\ApiKeyAuthenticationHandler::validateCredentials() does only seem to accept object, maybe add an additional type check?

            $this->eventDispatcher->dispatch(
                Ma27ApiKeyAuthenticationEvents::CREDENTIAL_FAILURE,
                new OnInvalidCredentialsEvent($object)
            );

            throw new CredentialException();
        }

        $this->eventDispatcher->dispatch(Ma27ApiKeyAuthenticationEvents::AUTHENTICATION, new OnAuthenticationEvent($object));
        $this->buildKey($object);

It seems like $object defined by $this->resolveObject($loginProperty, $credentials) on line 102 can also be of type null; however, Ma27\ApiKeyAuthenticationBundle\Service\Auth\ApiKeyAuthenticationHandler::buildKey() does only seem to accept object, maybe add an additional type check?

        $this->om->persist($object);

It seems like $object defined by $this->resolveObject($loginProperty, $credentials) on line 102 can also be of type null; however, Doctrine\Common\Persistence\ObjectManager::persist() does only seem to accept object, maybe add an additional type check?

        $this->om->flush();

        return $object;
    }

    /**
     * {@inheritdoc}
     */
    public function removeSession($user, $purgeJob = false)
    {
        $this->classMetadata->modifyProperty($user, null, ClassMetadata::API_KEY_PROPERTY);

        $event = $this->buildEventObject($user, $purgeJob);
        $this->eventDispatcher->dispatch(Ma27ApiKeyAuthenticationEvents::LOGOUT, $event);

        $this->om->persist($user);

        // on purge jobs one big flush will be commited to the db after the whole action
        if (!$purgeJob) {
            $this->om->flush();
        }
    }

    /**
     * Getter for the object manager.
     *
     * @return ObjectManager
     */
    protected function getOm()
    {
        return $this->om;
    }

    /**
     * Getter for the password hasher.
     *
     * @return PasswordHasherInterface
     */
    protected function getPasswordHasher()
    {
        return $this->passwordHasher;
    }

    /**
     * Getter for the key factory.
     *
     * @return KeyFactoryInterface
     */
    protected function getKeyFactory()
    {
        return $this->keyFactory;
    }

    /**
     * Getter for the dispatcher.
     *
     * @return EventDispatcherInterface
     */
    protected function getEventDispatcher()
    {
        return $this->eventDispatcher;
    }

    /**
     * Getter for the model name.
     *
     * @return string
     */
    protected function getModelName()
    {
        return $this->modelName;
    }

    /**
     * @return ClassMetadata
     */
    protected function getClassMetadata()
    {
        return $this->classMetadata;
    }

    /**
     * Simple helper which builds the API key and stores it in the user.
     *
     * @param object $userObject
     */
    private function buildKey($userObject)
    {
        $key = $this->classMetadata->getPropertyValue($userObject, ClassMetadata::API_KEY_PROPERTY);

        if (empty($key)) {
            $this->classMetadata->modifyProperty(
                $userObject,
                $this->keyFactory->getKey(),
                ClassMetadata::API_KEY_PROPERTY
            );
        }
    }

    /**
     * Simple helper which searches the ObjectManager by the given login parameter.
     *
     * @param string $loginProperty
     * @param array  $credentials
     *
     * @return object
     */
    private function resolveObject($loginProperty, array $credentials)
    {
        return $this->om->getRepository($this->modelName)->findOneBy([
            $loginProperty => $credentials[$loginProperty],
        ]);
    }

    /**
     * Validates the existance of the object and ensures that a valid password is given.
     *
     * @param object $object
     * @param string $password
     *
     * @return bool
     */
    private function validateCredentials($object, $password)
    {
        return !(
            null === $object
            || !$this->passwordHasher->compareWith($object->getPassword(), $password)
        );
    }

    /**
     * Builds the `OnLogoutEvent`.
     *
     * @param object $user
     * @param bool   $purgeJob
     *
     * @return OnLogoutEvent
     */
    private function buildEventObject($user, $purgeJob = false)
    {
        $event = new OnLogoutEvent($user);
        if ($purgeJob) {
            $event->markAsPurgeJob();
        }

        return $event;
    }
}