Ma27\ApiKeyAuthenticationBundle\DependencyInjection\Ma27ApiKeyAuthenticationExtension

Complexity

Total Complexity

15

Size/Duplication

Total Lines	123
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	8

Test Coverage

Coverage

97.14%

Importance

Changes	21
Bugs	4	Features	2

5 Methods

Rating	Name	Duplication	Size	Complexity
A	loadServices()	0	6	2
A	load()	0	21	1
A	loadPassword()	0	14	2
A	loadApiKeyPurger()	0	21	4
B	overrideServices()	0	26	6

<?php

namespace Ma27\ApiKeyAuthenticationBundle\DependencyInjection;

use Symfony\Component\Config\FileLocator;
use Symfony\Component\DependencyInjection\Alias;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\Loader;
use Symfony\Component\HttpKernel\DependencyInjection\Extension;
use Symfony\Component\Validator\Tests\Fixtures\Reference;

/**
 * This is the class that loads and manages your bundle configuration.
 *
 * To learn more see {@link http://symfony.com/doc/current/cookbook/bundles/extension.html}
 */
class Ma27ApiKeyAuthenticationExtension extends Extension
{
    /**
     * {@inheritdoc}
     */
    public function load(array $configs, ContainerBuilder $container)
    {
        $configuration = new Configuration();
        $config = $this->processConfiguration($configuration, $configs);

        $container->setParameter('ma27_api_key_authentication.key_header', $config['key_header']);
        $container->setParameter('ma27_api_key_authentication.model_name', $config['user']['model_name']);
        $container->setParameter('ma27_api_key_authentication.object_manager', $config['user']['object_manager']);
        $container->setParameter(
            'ma27_api_key_authentication.property.apiKeyLength',
            (int) floor($config['user']['api_key_length'] / 2) // TODO to be moved to the `KeyFactory`
        );

        $loader = new Loader\YamlFileLoader($container, new FileLocator(__DIR__.'/../Resources/config'));
        $this->loadPassword($container, $config['user']['password'], $loader);
        $this->loadServices($loader);
        $this->loadApiKeyPurger($container, $loader, $config['api_key_purge']);
        $this->overrideServices($container, $config['services']);

        $container->setParameter('ma27_api_key_authentication.response_values', $config['response']);
    }

    /**
     * Loads the password strategy.
     *
     * @param ContainerBuilder      $container
     * @param string                $passwordConfig
     * @param Loader\YamlFileLoader $loader
     */
    private function loadPassword(ContainerBuilder $container, $passwordConfig, Loader\YamlFileLoader $loader)
    {
        // TODO refactor this, the `phpass_iteration_length` is specific for a single strategy and therefore it shouldn't be present in the semantic configuration.
        $container->setParameter(
            'ma27_api_key_authentication.password_hasher.phpass.iteration_length',
            isset($passwordConfig['phpass_iteration_length']) ? $passwordConfig['phpass_iteration_length'] : 8
        );
        $loader->load('hashers.yml');

        $container->setParameter(
            'ma27_api_key_authentication.password_hashing_service',
            $passwordConfig['strategy']
        );
    }

    /**
     * Loads all internal services.
     *
     * @param Loader\YamlFileLoader $loader
     */
    private function loadServices(Loader\YamlFileLoader $loader)
    {
        foreach (array('security_key', 'authentication', 'security', 'annotation') as $file) {
            $loader->load(sprintf('%s.yml', $file));
        }
    }

    /**
     * Loads the purger job command into the container.
     *
     * @param ContainerBuilder      $container
     * @param Loader\YamlFileLoader $loader
     * @param string[]              $purgerConfig
     */
    private function loadApiKeyPurger(ContainerBuilder $container, Loader\YamlFileLoader $loader, array $purgerConfig)
    {
        if ($this->isConfigEnabled($container, $purgerConfig)) {
            $loader->load('session_cleanup.yml');

            if ($purgerConfig['log_state']) {
                @trigger_error('The options `api_key_purge.log_state` and the corresponding logger support are deprecated and will be dropped/removed in 2.0!', E_USER_DEPRECATED);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

                $container->setParameter(
                    'ma27_api_key_authentication.logger',
                    $purgerConfig['logger_service']
                );

                $definition = $container->getDefinition('ma27_api_key_authentication.cleanup_command');
                $definition->addArgument(new Reference($container->getParameter('ma27_api_key_authentication.logger')));

The call to Reference::__construct() has too many arguments starting with $container->getParameter('ma27_api_key_authentication.logger').

            }

            if ($this->isConfigEnabled($container, $purgerConfig['last_action_listener'])) {

$purgerConfig['last_action_listener'] is of type string, but the function expects a array.

                $loader->load('last_action_listener.yml');
            }
        }
    }

    /**
     * Processes the service override configuration into the container.
     *
     * @param ContainerBuilder $container
     * @param array            $services
     */
    private function overrideServices(ContainerBuilder $container, array $services)
    {
        $semanticServiceReplacements = array_filter($services);
        if (!empty($semanticServiceReplacements)) {
            $serviceConfig = array(
                'auth_handler'    => 'ma27_api_key_authentication.auth_handler',
                'key_factory'     => 'ma27_api_key_authentication.key_factory',
                'password_hasher' => 'ma27_api_key_authentication.password.strategy',
            );

            if (isset($services['password_hasher'])) {
                @trigger_error('The option `services.password_hasher` is deprecated, to be removed in 2.0, create a custom hasher instead!', E_USER_DEPRECATED);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

            }

            foreach ($serviceConfig as $configIndex => $replaceableServiceId) {
                if (!isset($semanticServiceReplacements[$configIndex])
                    || null === $serviceId = $semanticServiceReplacements[$configIndex]
                ) {
                    continue;
                }

                $container->removeDefinition($replaceableServiceId);
                $container->setAlias($replaceableServiceId, new Alias($serviceId));
            }
        }
    }
}