Ma27\ApiKeyAuthenticationBundle\Service\Password\PHPPasswordHasher

Complexity

Total Complexity

4

Size/Duplication

Total Lines	40
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	2
A	generateHash()	0	4	1
A	compareWith()	0	4	1

<?php

namespace Ma27\ApiKeyAuthenticationBundle\Service\Password;

/**
 * Concrete hasher that uses the php 5.5 api.
 */
class PHPPasswordHasher implements PasswordHasherInterface
{
    /**
     * @var int
     */
    private $cost;

    /**
     * Constructor.
     *
     * @param int $cost
     */
    public function __construct($cost = 12)
    {
        if (!function_exists('password_hash')) {
            throw new \RuntimeException(
                'In order to use this strategy please install the package "ircmaxell/password-compat" '.
                'or upgrade your php version to 5.5 or higher!'
            );
        }

        $this->cost = (int) $cost;
    }

    /**
     * {@inheritdoc}
     */
    public function generateHash($password)
    {
        return password_hash($password, PASSWORD_BCRYPT, array('cost' => $this->cost));

The expression password_hash($password, PASSWORD_BCRYPT, array('cost' => $this->cost)); of type null|false|string adds false to the return on line 37 which is incompatible with the return type declared by the interface Ma27\ApiKeyAuthenticationBundle\Service\Password\PasswordHasherInterface::generateHash of type string. It seems like you forgot to handle an error condition.

    }

    /**
     * {@inheritdoc}
     */
    public function compareWith($password, $raw)
    {
        return password_verify($raw, $password);
    }
}