Ma27\ApiKeyAuthenticationBundle\Command\SessionCleanupCommand

Complexity

Total Complexity

9

Size/Duplication

Total Lines	177
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	13

Test Coverage

Coverage

88.68%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	17	1
A	configure()	0	18	1
B	execute()	0	32	3
A	searchUsers()	0	16	1
A	displaySuccess()	0	4	1
A	getUsersByCriteria()	0	13	2

<?php

namespace Ma27\ApiKeyAuthenticationBundle\Command;

use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\Common\Collections\Criteria;
use Doctrine\Common\Collections\Selectable;
use Doctrine\Common\Persistence\ObjectManager;
use Ma27\ApiKeyAuthenticationBundle\Event\OnApiKeyCleanupErrorEvent;
use Ma27\ApiKeyAuthenticationBundle\Event\OnBeforeSessionCleanupEvent;
use Ma27\ApiKeyAuthenticationBundle\Event\OnSuccessfulCleanupEvent;
use Ma27\ApiKeyAuthenticationBundle\Ma27ApiKeyAuthenticationEvents;
use Ma27\ApiKeyAuthenticationBundle\Service\Auth\AuthenticationHandlerInterface;
use Ma27\ApiKeyAuthenticationBundle\Service\Mapping\ClassMetadata;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\EventDispatcher\EventDispatcherInterface;

/**
 * Command which is responsible for the session cleanup.
 */
class SessionCleanupCommand extends Command
{
    /**
     * @var ObjectManager
     */
    private $om;

    /**
     * @var AuthenticationHandlerInterface
     */
    private $handler;

    /**
     * @var EventDispatcherInterface
     */
    private $eventDispatcher;

    /**
     * @var string
     */
    private $modelName;

    /**
     * @var ClassMetadata
     */
    private $classMetadata;

    /**
     * @var string
     */
    private $dateTimeRule;

    /**
     * Constructor.
     *
     * @param ObjectManager                  $om
     * @param AuthenticationHandlerInterface $authenticationHandler
     * @param EventDispatcherInterface       $eventDispatcher
     * @param string                         $modelName
     * @param ClassMetadata                  $classMetadata
     * @param string                         $dateTimeRule
     */
    public function __construct(
        ObjectManager $om,
        AuthenticationHandlerInterface $authenticationHandler,
        EventDispatcherInterface $eventDispatcher,
        $modelName,
        ClassMetadata $classMetadata,
        $dateTimeRule
    ) {
        $this->om = $om;
        $this->handler = $authenticationHandler;
        $this->eventDispatcher = $eventDispatcher;
        $this->modelName = (string) $modelName;
        $this->classMetadata = $classMetadata;
        $this->dateTimeRule = (string) $dateTimeRule;

        parent::__construct();
    }

    /**
     * {@inheritdoc}
     */
    protected function configure()
    {
        $this
            ->setName('ma27:auth:session-cleanup')
            ->setDescription('Cleans all outdated sessions')
            ->setHelp(<<<'EOF'
The <info>ma27:auth:session-cleanup</info> command purges all api keys of users that were inactive for at least 5 days

The usage is pretty simple:

    <info>php app/console ma27:auth:session-cleanup</info>

NOTE: you have to enable the cleanup section of that bundle (please review the docs for more information)

<info>It's recommended to use a cronjob that purges old api keys every day/two days</info>
EOF
            );
    }

    /**
     * {@inheritdoc}
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        try {
            $filteredUsers = $this->searchUsers();
            $processedObjects = 0;

            $event = new OnBeforeSessionCleanupEvent($filteredUsers);
            $this->eventDispatcher->dispatch(Ma27ApiKeyAuthenticationEvents::BEFORE_CLEANUP, $event);

            // purge filtered users
            foreach ($filteredUsers as $user) {
                $this->handler->removeSession($user, true);
                ++$processedObjects;
            }

            $this->displaySuccess($processedObjects, $output);

            $afterEvent = new OnSuccessfulCleanupEvent($filteredUsers);
            $this->eventDispatcher->dispatch(Ma27ApiKeyAuthenticationEvents::CLEANUP_SUCCESS, $afterEvent);

            $this->om->flush();
        } catch (\Exception $ex) {
            $this->eventDispatcher->dispatch(
                Ma27ApiKeyAuthenticationEvents::CLEANUP_ERROR,
                new OnApiKeyCleanupErrorEvent($ex)
            );

            throw $ex;
        }

        return 0;
    }

    /**
     * Search query for users with outdated api keys.
     *
     * @return object[]
     */
    private function searchUsers()
    {
        $criteria = Criteria::create()
            ->where(Criteria::expr()->lte(
                $this->classMetadata->getPropertyName(ClassMetadata::LAST_ACTION_PROPERTY),

It seems like $this->classMetadata->getPropertyName(\Ma27\ApiKeyAuthenticationBundle\Service\Mapping\ClassMetadata::LAST_ACTION_PROPERTY) targeting Ma27\ApiKeyAuthenticationBundle\Service\Mapping\ClassMetadata::getPropertyName() can also be of type null or object<ReflectionProperty>; however, Doctrine\Common\Collections\ExpressionBuilder::lte() does only seem to accept string, maybe add an additional type check?

                new \DateTime($this->dateTimeRule))
            )
            ->andWhere(
                Criteria::expr()->neq(
                    $this->classMetadata->getPropertyName(ClassMetadata::API_KEY_PROPERTY),

It seems like $this->classMetadata->getPropertyName(\Ma27\ApiKeyAuthenticationBundle\Service\Mapping\ClassMetadata::API_KEY_PROPERTY) targeting Ma27\ApiKeyAuthenticationBundle\Service\Mapping\ClassMetadata::getPropertyName() can also be of type null or object<ReflectionProperty>; however, Doctrine\Common\Collections\ExpressionBuilder::neq() does only seem to accept string, maybe add an additional type check?

                    null
                )
            );

        return $this->getUsersByCriteria($criteria);
    }

    /**
     * Outputs the suces after the cleanup.
     *
     * @param                 $processed
     * @param OutputInterface $output
     */
    private function displaySuccess($processed, OutputInterface $output)
    {
        $output->writeln(sprintf('<info>Processed %d items successfully</info>', $processed));
    }

    /**
     * Simple utility to query users by a given criteria.
     *
     * As there's no unified query language defined in doctrine/common, the criteria tool of doctrine/collections
     * should help. The ORM and Mongo-ODM support the `Selectable` API which means that they can build native
     * DB queries for their database based on a criteria object. The other official implementations PHPCR and CouchDB-ODM
     * don't support that, so they have to be evaluated manually.
     *
     * @param Criteria $criteria
     *
     * @return object[]
     */
    private function getUsersByCriteria(Criteria $criteria)
    {
        $repository = $this->om->getRepository($this->modelName);

        if ($repository instanceof Selectable) {
            $filteredUsers = $repository->matching($criteria);
        } else {
            $allUsers = new ArrayCollection($repository->findAll());
            $filteredUsers = $allUsers->matching($criteria);
        }

        return $filteredUsers->toArray();
    }
}