Issues in Init.php (master) - Issues in master - MW-Peachy/Peachy - Measure and Improve Code Quality continuously with Scrutinizer

Issues (165)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Init.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
This file is part of Peachy MediaWiki Bot API

Peachy is free software: you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by
the Free Software Foundation, either version 3 of the License, or
(at your option) any later version.

This program is distributed in the hope that it will be useful,
but WITHOUT ANY WARRANTY; without even the implied warranty of
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
GNU General Public License for more details.

You should have received a copy of the GNU General Public License
along with this program.  If not, see <http://www.gnu.org/licenses/>.

Peachy is not responsible for any damage caused to the system running it.
*/

/**
 * @file
 * Main Peachy file
 * Defines constants, initializes global variables
 * Stores Peachy
 * @license GPL
 */

/**
 * The version that Peachy is running
 */
define( 'PEACHYVERSION', '2.0 (alpha 8)' );

/**
 * Minimum MediaWiki version that is required for Peachy
 */
define( 'MINMW', '1.23' );

/**
 * Minimum PHP version that is required for Peachy
 */
define( 'MINPHP', '5.2.1' );

/**
 * PECHO constants, used for {@link outputText}()
 */
define( 'PECHO_VERBOSE', -1 );

/**
 * PECHO constants, used for {@link outputText}()
 */
define( 'PECHO_NORMAL', 0 );

/**
 * PECHO constants, used for {@link outputText}()
 */
define( 'PECHO_NOTICE', 1 );

/**
 * PECHO constants, used for {@link outputText}()
 */
define( 'PECHO_WARN', 2 );

/**
 * PECHO constants, used for {@link outputText}()
 */
define( 'PECHO_ERROR', 3 );

/**
 * PECHO constants, used for {@link outputText}()
 */
define( 'PECHO_FATAL', 4 );

$pgIP = dirname( __FILE__ ) . DIRECTORY_SEPARATOR;

//If out /tmp directory doesnt exist, make it!
if( !file_exists( __DIR__ . '/tmp' ) ) {
    mkdir(__DIR__ . '/tmp');
}

require_once( $pgIP . 'Includes/Exceptions.php' );
require_once( $pgIP . 'Includes/AutoUpdate.php' );

peachyCheckPHPVersion( MINPHP );

$pgHooks = array();
$pgProxy = array();
$pgUA = 'Peachy MediaWiki Bot API Version ' . PEACHYVERSION;

require_once( $pgIP . 'Includes/Hooks.php' );
require_once( $pgIP . 'HTTP.php' );
require_once( $pgIP . 'Includes/Autoloader.php' );
require_once( $pgIP . 'GenFunctions.php' );
require_once( $pgIP . 'config.inc.php' );
require_once( $pgIP . 'Includes/SSH.php' );
require_once($pgIP . 'Includes/lime.php');

$pgVerbose = array();
if( $pgDisplayPechoVerbose ) $pgVerbose[] = -1;
if( $pgDisplayPechoNormal ) $pgVerbose[] = 0;
if( $pgDisplayPechoNotice ) $pgVerbose[] = 1;
if( $pgDisplayPechoWarn ) $pgVerbose[] = 2;
if( $pgDisplayPechoError ) $pgVerbose[] = 3;
if( $pgDisplayPechoFatal ) $pgVerbose[] = 4;

$pgIRCTrigger = array( '!', '.' );

//Last version check
$tmp = null;

if( function_exists( 'mb_internal_encoding' ) ) {
    mb_internal_encoding("UTF-8");
}

// Suppress warnings if timezone not set on server
date_default_timezone_set( @date_default_timezone_get() );

//Check for updates before loading Peachy.
if( !$pgDisableUpdates && !defined( 'PEACHY_PHPUNIT_TESTS' ) ) {
    //the below MUST have its own Http object or else things will break
    $updater = new AutoUpdate(new HTTP());
    $Uptodate = $updater->Checkforupdate();
    if (!$Uptodate) {
        $updater->updatePeachy();
    }
}

require_once( $pgIP . 'Includes/Peachy.php' );

/**
 * Simple version_compare() wrapper
 * @param string $check_version string
 * @throws DependencyError
 * @return void
 */
function peachyCheckPHPVersion( $check_version )
{
    if (version_compare(PHP_VERSION, $check_version, '<')) {
        throw new DependencyError("PHP " . $check_version, "http://php.net/downloads.php");
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }
}


1			<?php
2
3			/*
4			This file is part of Peachy MediaWiki Bot API
5
6			Peachy is free software: you can redistribute it and/or modify
7			it under the terms of the GNU General Public License as published by
8			the Free Software Foundation, either version 3 of the License, or
9			(at your option) any later version.
10
11			This program is distributed in the hope that it will be useful,
12			but WITHOUT ANY WARRANTY; without even the implied warranty of
13			MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14			GNU General Public License for more details.
15
16			You should have received a copy of the GNU General Public License
17			along with this program. If not, see <http://www.gnu.org/licenses/>.
18
19			Peachy is not responsible for any damage caused to the system running it.
20			*/
21
22			/**
23			* @file
24			* Main Peachy file
25			* Defines constants, initializes global variables
26			* Stores Peachy
27			* @license GPL
28			*/
29
30			/**
31			* The version that Peachy is running
32			*/
33			define( 'PEACHYVERSION', '2.0 (alpha 8)' );
34
35			/**
36			* Minimum MediaWiki version that is required for Peachy
37			*/
38			define( 'MINMW', '1.23' );
39
40			/**
41			* Minimum PHP version that is required for Peachy
42			*/
43			define( 'MINPHP', '5.2.1' );
44
45			/**
46			* PECHO constants, used for {@link outputText}()
47			*/
48			define( 'PECHO_VERBOSE', -1 );
49
50			/**
51			* PECHO constants, used for {@link outputText}()
52			*/
53			define( 'PECHO_NORMAL', 0 );
54
55			/**
56			* PECHO constants, used for {@link outputText}()
57			*/
58			define( 'PECHO_NOTICE', 1 );
59
60			/**
61			* PECHO constants, used for {@link outputText}()
62			*/
63			define( 'PECHO_WARN', 2 );
64
65			/**
66			* PECHO constants, used for {@link outputText}()
67			*/
68			define( 'PECHO_ERROR', 3 );
69
70			/**
71			* PECHO constants, used for {@link outputText}()
72			*/
73			define( 'PECHO_FATAL', 4 );
74
75			$pgIP = dirname( __FILE__ ) . DIRECTORY_SEPARATOR;
76
77			//If out /tmp directory doesnt exist, make it!
78			if( !file_exists( __DIR__ . '/tmp' ) ) {
79			mkdir(__DIR__ . '/tmp');
80			}
81
82			require_once( $pgIP . 'Includes/Exceptions.php' );
83			require_once( $pgIP . 'Includes/AutoUpdate.php' );
84
85			peachyCheckPHPVersion( MINPHP );
86
87			$pgHooks = array();
88			$pgProxy = array();
89			$pgUA = 'Peachy MediaWiki Bot API Version ' . PEACHYVERSION;
90
91			require_once( $pgIP . 'Includes/Hooks.php' );
92			require_once( $pgIP . 'HTTP.php' );
93			require_once( $pgIP . 'Includes/Autoloader.php' );
94			require_once( $pgIP . 'GenFunctions.php' );
95			require_once( $pgIP . 'config.inc.php' );
96			require_once( $pgIP . 'Includes/SSH.php' );
97			require_once($pgIP . 'Includes/lime.php');
98
99			$pgVerbose = array();
100			if( $pgDisplayPechoVerbose ) $pgVerbose[] = -1;
101			if( $pgDisplayPechoNormal ) $pgVerbose[] = 0;
102			if( $pgDisplayPechoNotice ) $pgVerbose[] = 1;
103			if( $pgDisplayPechoWarn ) $pgVerbose[] = 2;
104			if( $pgDisplayPechoError ) $pgVerbose[] = 3;
105			if( $pgDisplayPechoFatal ) $pgVerbose[] = 4;
106
107			$pgIRCTrigger = array( '!', '.' );
108
109			//Last version check
110			$tmp = null;
111
112			if( function_exists( 'mb_internal_encoding' ) ) {
113			mb_internal_encoding("UTF-8");
114			}
115
116			// Suppress warnings if timezone not set on server
117			date_default_timezone_set( @date_default_timezone_get() );
118
119			//Check for updates before loading Peachy.
120			if( !$pgDisableUpdates && !defined( 'PEACHY_PHPUNIT_TESTS' ) ) {
121			//the below MUST have its own Http object or else things will break
122			$updater = new AutoUpdate(new HTTP());
123			$Uptodate = $updater->Checkforupdate();
124			if (!$Uptodate) {
125			$updater->updatePeachy();
126			}
127			}
128
129			require_once( $pgIP . 'Includes/Peachy.php' );
130
131			/**
132			* Simple version_compare() wrapper
133			* @param string $check_version string
134			* @throws DependencyError
135			* @return void
136			*/
137			function peachyCheckPHPVersion( $check_version )
138			{
139			if (version_compare(PHP_VERSION, $check_version, '<')) {
140			throw new DependencyError("PHP " . $check_version, "http://php.net/downloads.php");
			0 ignored issues – show Documentation introduced 2016-01-19 16:04 UTC by Report Bug Copy Issue Report Show Similar Issues like this `'http://php.net/downloads.php'` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
141			}
142			}
143

MW-Peachy / Peachy

Issues (165)

Security Analysis no request data

Init.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like