Issues (431)

Security Analysis    not enabled

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

include/classes/notification.class.php (1 issue)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
$defflip = (!cfip()) ? exit(header('HTTP/1.1 401 Unauthorized')) : 1;
3
4
class Notification extends Mail {
5
  var $table = 'notifications';
6
  var $tableSettings = 'notification_settings';
7
8
  public function setInactive($id) {
9
    $field = array(
10
      'name' => 'active',
11
      'type' => 'i',
12
      'value' => 0
13
    );
14
    return $this->updateSingle($id, $field);
0 ignored issues
show
$field is of type array<string,string|inte...ng","value":"integer"}>, but the function expects a string.

It seems like the type of the argument is not accepted by the function/method which you are calling.

In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug.

We suggest to add an explicit type cast like in the following example:

function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
Loading history...
15
  }
16
17
  /**
18
   * We check our notification table for existing data
19
   * so we can avoid duplicate entries
20
   **/
21
  public function isNotified($aData) {
22
    $this->debug->append("STA " . __METHOD__, 4);
23
    $data = json_encode($aData);
24
    $stmt = $this->mysqli->prepare("SELECT id FROM $this->table WHERE data = ? AND active = 1 LIMIT 1");
25
    if ($stmt && $stmt->bind_param('s', $data) && $stmt->execute() && $stmt->store_result() && $stmt->num_rows == 1) {
26
        return true;
27
    }
28
    
29
    return $this->sqlError('E0041');
30
  }
31
32
  /**
33
   * Get all active notifications
34
   **/
35
  public function getAllActive($strType) {
36
    $this->debug->append("STA " . __METHOD__, 4);
37
    $stmt =$this->mysqli->prepare("SELECT id, data FROM $this->table WHERE active = 1 AND type = ?");
38
    if ($stmt && $stmt->bind_param('s', $strType) && $stmt->execute() && $result = $stmt->get_result())
39
      return $result->fetch_all(MYSQLI_ASSOC);
40
    return $this->sqlError('E0042');
41
  }
42
43
  /**
44
   * Add a new notification to the table
45
   * @param type string Type of the notification
46
   * @return bool
47
   **/
48
  public function addNotification($account_id, $type, $data) {
49
    $this->debug->append("STA " . __METHOD__, 4);
50
    // Store notification data as json
51
    $data = json_encode($data);
52
    $stmt = $this->mysqli->prepare("INSERT INTO $this->table (account_id, type, data, active) VALUES (?, ?,?,1)");
53
    if ($stmt && $stmt->bind_param('iss', $account_id, $type, $data) && $stmt->execute())
54
      return true;
55
    return $this->sqlError('E0043');
56
  }
57
58
  /**
59
   * Fetch notifications for a user account
60
   * @param id int Account ID
61
   * @return array Notification data
62
   **/
63
  public function getNotifications($account_id,$limit=50) {
64
    $this->debug->append("STA " . __METHOD__, 4);
65
    $stmt = $this->mysqli->prepare("SELECT * FROM $this->table WHERE account_id = ? ORDER BY time DESC LIMIT ?");
66
    if ($stmt && $stmt->bind_param('ii', $account_id, $limit) && $stmt->execute() && $result = $stmt->get_result())
67
      return $result->fetch_all(MYSQLI_ASSOC);
68
    return $this->getError();
69
  }
70
71
  /**
72
   * Fetch notification settings for user account
73
   * @param id int Account ID
74
   * @return array Notification settings
75
   **/
76
  public function getNotificationSettings($account_id) {
77
    // Some defaults, we cover them here so we can avoid adding default settings on user creation
78
    $aDefaults = array( 'newsletter' => 1 );
79
    $this->debug->append("STA " . __METHOD__, 4);
80
    $stmt = $this->mysqli->prepare("SELECT * FROM $this->tableSettings WHERE account_id = ?");
81
    if ($stmt && $stmt->bind_param('i', $account_id) && $stmt->execute() && $result = $stmt->get_result()) {
82
      if ($result->num_rows > 0) {
83
        $aFound = array();
84
        while ($row = $result->fetch_assoc()) {
85
          if (array_key_exists($row['type'], $aDefaults)) $aFound[] = $row['type'];
86
          $aData[$row['type']] = $row['active'];
87
        }
88
        // Check found types against our defaults, set if required
89
        foreach ($aDefaults as $type => $value) {
90
          if (!in_array($type, $aFound)) {
91
            $aData[$type] = $value;
92
          }
93
        }
94
        return $aData;
95
      } else {
96
        foreach ($aDefaults as $type => $value) $aData[$type] = $value;
97
        return $aData;
98
      }
99
    }
100
    return $this->sqlError('E0045');
101
  }
102
103
  /**
104
   * Get all accounts that wish to receive a specific notification
105
   * @param strType string Notification type
106
   * @return data array User Accounts
107
   **/
108
  public function getNotificationAccountIdByType($strType) {
109
    $this->debug->append("STA " . __METHOD__, 4);
110
    $stmt = $this->mysqli->prepare("SELECT account_id FROM $this->tableSettings WHERE type IN (?, ?) AND active = 1 GROUP BY account_id");
111
    $notStrType = substr('push_'.$strType, 0, 15);
112
    if ($stmt && $stmt->bind_param('ss', $strType, $notStrType) && $stmt->execute() && $result = $stmt->get_result()) {
113
      return $result->fetch_all(MYSQLI_ASSOC);
114
    }
115
    return $this->sqlError('E0046');
116
  }
117
118
  /**
119
   * Update accounts notification settings
120
   * @param account_id int Account ID
121
   * @param data array Data array
122
   * @return bool
123
   **/
124
  public function updateSettings($account_id, $data) {
125
    $this->debug->append("STA " . __METHOD__, 4);
126
    $failed = $ok = 0;
127
    foreach ($data as $type => $active) {
128
      $stmt = $this->mysqli->prepare("INSERT INTO $this->tableSettings (active, type, account_id) VALUES (?,?,?) ON DUPLICATE KEY UPDATE active = ?");
129
      if ($stmt && $stmt->bind_param('isii', $active, $type, $account_id, $active) && $stmt->execute()) {
130
        $ok++;
131
      } else {
132
        $failed++;
133
      }
134
    }
135
    if ($failed > 0) {
136
      $this->setErrorMessage($this->getErrorMsg('E0047', $failed));
137
      return $this->sqlError();
138
    }
139
    $this->log->log("info", "User $account_id updated notification settings");
140
    return true;
141
  }
142
143
  /**
144
   * Send a specific notification setup in notification_settings
145
   * @param type string Notification type
146
   * @return bool
147
   **/
148
  public function sendNotification($account_id, $strType, $aMailData) {
149
    // Check if we notified for this event already
150
    if ( $this->isNotified($aMailData) ) {
151
      $this->setErrorMessage('A notification for this event has been sent already');
152
      return false;
153
    }
154
    // Check if this user wants strType notifications
155
    $stmt = $this->mysqli->prepare("SELECT type FROM $this->tableSettings WHERE type IN (?, ?) AND active = 1 AND account_id = ?");
156
    $notStrType = substr('push_'.$strType, 0, 15);
157
    if ($stmt && $stmt->bind_param('ssi', $strType, $notStrType, $account_id) && $stmt->execute() && $result = $stmt->get_result()) {
158
    	$types = array_map(function($a){ return reset($a);}, $result->fetch_all(MYSQLI_ASSOC));
159
    	$stmt->close();
160
    	$result = true;
161
    	foreach ($types as $type){
162
    	  if (strpos($type, 'push_') === 0){
163
    		if (PushNotification::Instance() instanceof PushNotification){
164
    			$result &= PushNotification::Instance()->sendNotification($account_id, $strType, $aMailData); 
165
    		}
166
    	  } else {
167
    		$result &= $this->sendMail('notifications/' . $strType, $aMailData); 
168
    	  }
169
    	}
170
    	if ($result){
171
    		$this->addNotification($account_id, $strType, $aMailData);
172
    		return true;
173
    	} else {
174
          $this->setErrorMessage('SendMail call failed: ' . $this->getError());
175
          return false;
176
        }
177
    } else {
178
      $this->setErrorMessage('User disabled ' . $strType . ' notifications');
179
      return true;
180
    }
181
    $this->setErrorMessage('Error sending mail notification');
182
    return false;
183
  }
184
185
  /**
186
   * Cleanup old notifications
187
   * @param none
188
   * @return bool true or false
189
   **/
190
  public function cleanupNotifications($days=7) {
191
    $failed = 0;
192
    $this->deleted = 0;
193
    $stmt = $this->mysqli->prepare("DELETE FROM $this->table WHERE time < (NOW() - INTERVAL ? DAY)");
194 View Code Duplication
    if (! ($this->checkStmt($stmt) && $stmt->bind_param('i', $days) && $stmt->execute())) {
195
      $failed++;
196
    } else {
197
      $this->deleted += $stmt->affected_rows;
198
    }
199 View Code Duplication
    if ($failed > 0) {
200
      $this->setCronMessage('Failed to delete ' . $failed . ' notifications from ' . $this->table . ' table');
201
      return false;
202
    }
203
    return true;
204
  }
205
}
206
207
$notification = new Notification();
208
$notification->setDebug($debug);
209
$notification->setLog($log);
210
$notification->setMysql($mysqli);
211
$notification->setSmarty($smarty);
212
$notification->setConfig($config);
213
$notification->setSetting($setting);
214
$notification->setErrorCodes($aErrorCodes);
215