mysqlims::__construct() - Code Metrics - Inspection of "Implement Read/Write Split directly on PHP / Fixed..." - MPOS/php-mpos - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — development (#2642)

unknown

created 2017-12-08 22:59 UTC

mysqlims::__construct() C

↳ Parent: mysqlims

Complexity

Conditions	12
Paths	12

Size

Total Lines	34
Code Lines	25

Duplication

Lines	12
Ratio	35.29 %

Importance

Changes

Metric	Value
dl	12
loc	34
rs	5.1612
c	0
b	0
f	0
cc	12
eloc	25
nc	12
nop	3

How to fix Complexity

<?php
/*
 * This class will run queries on master/slave servers depending on the query itself.
 */
class mysqlims extends mysqli
namespace YourVendor;

class YourClass { }
{
    private $mysqliW;
    private $mysqliR = null;

    /*
     * Pass main and slave connection arrays to the constructor, and strict as true/false
     *
     * @param array $main
     * @param array $slave
     * @param boolean $strict
     *
     * @return void

     */
    public function __construct($main, $slave = false, $strict = false)
    {
        var_dump($main);

        var_dump($slave);
        if ($strict) {
            $this->mysqliW = new mysqli_strict($main['host'],

                $main['user'], $main['pass'],
                $main['name'], $main['port']);
            if ($slave && is_array($slave) && isset($slave['enabled']) && $slave['enabled']

                === true) {
                $this->mysqliR = new mysqli_strict($slave['host'],

                    $slave['user'], $slave['pass'],
                    $slave['name'], $slave['port']);
            }
        } else {
            $this->mysqliW = new mysqli($main['host'],
                $main['user'], $main['pass'],
                $main['name'], $main['port']);
            if ($slave && is_array($slave) && isset($slave['enabled']) && $slave['enabled']

                === true) {
                $this->mysqliR = new mysqli($slave['host'],
                    $slave['user'], $slave['pass'],
                    $slave['name'], $slave['port']);
            }
        }

        if ($this->mysqliW->connect_errno) {
            throw new Exception("Failed to connect to MySQL: (".$this->mysqliW->connect_errno.") ".$this->mysqliW->connect_error);
        }

        if ($this->mysqliR->connect_errno) {
            throw new Exception("Failed to connect to MySQL: (".$this->mysqliR->connect_errno.") ".$this->mysqliR->connect_error);
        }
    }

    /*
     * Override standard mysqli_prepare to select master/slave server
     * @param $string query
     *
     * @return mysqli_stmt
     */
    public function prepare($query)

    {
        if (stripos($query, "SELECT") && stripos($query, "FOR UPDATE") === false && $this->mysqliR !== null) {
            return $this->mysqliR->prepare($query);
        } else {
            return $this->mysqliW->prepare($query);
        }
    }

    /*
     * Override standard mysqli_query to select master/slave server
     * @param string $query
     * @param int $resultmode
     *
     * @return boolean
     * @return mixed
     */
    public function query($query, $resultmode = MYSQLI_STORE_RESULT)

    {
        if (stripos($query, "SELECT") && stripos($query, "FOR UPDATE") === false && $this->mysqliR !== null) {/* Use readonly server */
            return $this->mysqliR->query($query, $resultmode);
        } else {
            return $this->mysqliW->query($query, $resultmode);
        }
    }
}

1		<?php
2		/*
3		* This class will run queries on master/slave servers depending on the query itself.
4		*/
5		class mysqlims extends mysqli
		0 ignored issues – show Coding Style Compatibility introduced 2017-12-08 23:04 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
6		{
7		private $mysqliW;
8		private $mysqliR = null;
9
10		/*
11		* Pass main and slave connection arrays to the constructor, and strict as true/false
12		*
13		* @param array $main
14		* @param array $slave
15		* @param boolean $strict
16		*
17		* @return void
		0 ignored issues – show Comprehensibility Best Practice introduced 2017-12-08 23:04 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
18		*/
19		public function __construct($main, $slave = false, $strict = false)
20		{
21		var_dump($main);
		0 ignored issues – show Security Debugging Code introduced 2017-12-08 23:04 UTC by Report Bug Copy Issue Report `var_dump($main);` looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data. Loading history...
22		var_dump($slave);
23		if ($strict) {
24		$this->mysqliW = new mysqli_strict($main['host'],
		0 ignored issues – show Unused Code introduced 2017-12-08 23:04 UTC by Report Bug Copy Issue Report The call to `mysqli_strict::__construct()` has too many arguments starting with `$main['host']`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
25		$main['user'], $main['pass'],
26		$main['name'], $main['port']);
27	View Code Duplication	if ($slave && is_array($slave) && isset($slave['enabled']) && $slave['enabled']
		0 ignored issues – show Duplication introduced 2017-12-08 23:04 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
28		=== true) {
29		$this->mysqliR = new mysqli_strict($slave['host'],
		0 ignored issues – show Unused Code introduced 2017-12-08 23:04 UTC by Report Bug Copy Issue Report The call to `mysqli_strict::__construct()` has too many arguments starting with `$slave['host']`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
30		$slave['user'], $slave['pass'],
31		$slave['name'], $slave['port']);
32		}
33		} else {
34		$this->mysqliW = new mysqli($main['host'],
35		$main['user'], $main['pass'],
36		$main['name'], $main['port']);
37	View Code Duplication	if ($slave && is_array($slave) && isset($slave['enabled']) && $slave['enabled']
		0 ignored issues – show Duplication introduced 2017-12-08 23:04 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
38		=== true) {
39		$this->mysqliR = new mysqli($slave['host'],
40		$slave['user'], $slave['pass'],
41		$slave['name'], $slave['port']);
42		}
43		}
44
45		if ($this->mysqliW->connect_errno) {
46		throw new Exception("Failed to connect to MySQL: (".$this->mysqliW->connect_errno.") ".$this->mysqliW->connect_error);
47		}
48
49		if ($this->mysqliR->connect_errno) {
50		throw new Exception("Failed to connect to MySQL: (".$this->mysqliR->connect_errno.") ".$this->mysqliR->connect_error);
51		}
52		}
53
54		/*
55		* Override standard mysqli_prepare to select master/slave server
56		* @param $string query
57		*
58		* @return mysqli_stmt
59		*/
60	View Code Duplication	public function prepare($query)
		0 ignored issues – show Duplication introduced 2017-12-08 23:04 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
61		{
62		if (stripos($query, "SELECT") && stripos($query, "FOR UPDATE") === false && $this->mysqliR !== null) {
63		return $this->mysqliR->prepare($query);
64		} else {
65		return $this->mysqliW->prepare($query);
66		}
67		}
68
69		/*
70		* Override standard mysqli_query to select master/slave server
71		* @param string $query
72		* @param int $resultmode
73		*
74		* @return boolean
75		* @return mixed
76		*/
77	View Code Duplication	public function query($query, $resultmode = MYSQLI_STORE_RESULT)
		0 ignored issues – show Duplication introduced 2017-12-08 23:04 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
78		{
79		if (stripos($query, "SELECT") && stripos($query, "FOR UPDATE") === false && $this->mysqliR !== null) {/* Use readonly server */
80		return $this->mysqliR->query($query, $resultmode);
81		} else {
82		return $this->mysqliW->query($query, $resultmode);
83		}
84		}
85		}

MPOS / php-mpos

Pull Request — development (#2642)

mysqlims::__construct() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like