View GitHub Repository php-mpos

Schedule Inspection
Subscribe
Completed
Push — development ( d1d4a0...e79b55 )
by Sebastian
02:47
created

include/classes/coins/coin_scrypt.class.php (3 issues)

← previous file next file →

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1 
<?php
0 ignored issues
– show
Coding Style Compatibility introduced by
For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 9 and the first side effect is on line 2.

The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.

The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.

To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.

Loading history...
2 
$defflip = (!cfip()) ? exit(header('HTTP/1.1 401 Unauthorized')) : 1;
3 

            


            
                                                                                                            
                            
            
                                    
            
            

                
                    4
                

                                    
                                                    
                
                
                
/**

            


            
                                                                                                            
                                                                
            
                                    
            
            

                
                    5
                

                                    
                                                    
                
                
                
 * We extend our CoinBase class

            


            
                                                        
            
                                    
            
            

                
                    6
                

                                    
                                                    
                
                
                
 * No need to change anything, base class supports

            


            
                                                        
            
                                    
            
            

                
                    7
                

                                    
                                                    
                
                
                
 * scrypt and sha256d

            


            
                                                        
            
                                    
            
            

                
                    8
                

                                    
                                                    
                
                
                
 **/

            


            
                                                        
            
                                    
            
            

                
                    9
                

                                    
                                                    
                
                
                
class Coin extends CoinBase {

            


                            

                    
                        
                    
                    
                    
                    
                                                                                                                                                        
                        

                            
                            
0 ignored issues

                            –
                            show
                        


                        

                                                                                        




    

        
            Coding Style
            Compatibility
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.
                                            

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
You can fix this by adding a namespace to your class:


namespace YourVendor;

class YourClass { }





When choosing a vendor namespace, try to pick something that is not too generic
to avoid conflicts with other libraries.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                            




    

        
            Comprehensibility
            Best Practice
    
    
    
        introduced 
                            by 
            

        

        

            
        

        

            

                

                    
                
                
            


        

    

    

        
                        

                            
                                
                            
                        

                                        
The type Coin has been defined more than once; this definition is ignored, only the first definition in include/classes/coins/coin_neoscrypt.class.php (L9-11) is considered.
                                                                                                                                                                                                                                                            

                    
                                            

                            

                            

                                
                                    
                                
                            


                            
This check looks for classes that have been defined more than once.


If you can, we would recommend to use standard object-oriented programming
techniques. For example, to avoid multiple types, it might make sense to create a
common interface, and then multiple, different implementations for that interface.


This also has the side-effect of providing you with better IDE auto-completion,
static analysis and also better OPCode caching from PHP.


                        

                                                    

                     Loading history...
                

                    


    




                                                                                    


                    		
                

            
                                                        
            
                                    
            
            

                
                    10
                

                                    
                                                    
                
                
                
  protected $target_bits = 16;

            


            
                                                        
            
                                    
            
            

                
                    11
                

                                    
                                                    
                
                
                
}

            


            
                                                        
            
                                    
            
            

                
                    12