Api

Complexity

Total Complexity

19

Size/Duplication

Total Lines	61
Duplicated Lines	0 %

Coupling/Cohesion

Components	3
Dependencies	1

Test Coverage

Coverage

0%

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setStartTime()	0	3	1
A	isActive()	0	11	3
A	get_json()	0	15	4
B	checkAccess()	0	17	11

<?php
$defflip = (!cfip()) ? exit(header('HTTP/1.1 401 Unauthorized')) : 1;

/**
 * Helper class for our API
 **/
class Api extends Base {
  private $api_version = '1.0.0';

  function setStartTime($dStartTime) {

It is generally recommended to explicitly declare the visibility for methods.

    $this->dStartTime = $dStartTime;

The property dStartTime does not exist. Did you maybe forget to declare it?

  }
  function isActive($error=true) {

It is generally recommended to explicitly declare the visibility for methods.

    if (!$this->setting->getValue('disable_api')) {

The property setting does not exist. Did you maybe forget to declare it?

      return true;
    } else {
      if ($error == true) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

        unset($_SESSION['POPUP']);
        header('HTTP/1.1 501 Not implemented');
        die('501 Not implemented');
      }
    }
  }

  /**
   * Create API json object from input array
   * @param data Array data to create JSON for
   * @param force bool Enforce a JSON object
   * @return string JSON object
   **/
  function get_json($data, $force=false) {

It is generally recommended to explicitly declare the visibility for methods.

    $json = json_encode(
      array( $_REQUEST['action'] => array(
        'version' => $this->api_version,
        'runtime' => (microtime(true) - $this->dStartTime) * 1000,
        'data' => $data
      )), $force ? JSON_FORCE_OBJECT : 0
    );
    // JSONP support issue #1700
    if (isset($_REQUEST['callback']) && ctype_alpha($_REQUEST['callback'])) {
      header('Content-type: application/json; charset=utf-8');
      return $_REQUEST['callback'] . '(' . $json . ');';
    }
    return $json;
  }

  /**
   * Check user access level to the API call
   **/
  function checkAccess($user_id, $get_id=NULL) {

It is generally recommended to explicitly declare the visibility for methods.

    if (!empty($get_id) && is_array($get_id)) die("Access denied");
    if (is_array($user_id)) die("Access denied");
    if ( ! $this->user->isAdmin($user_id) && (!empty($get_id) && $get_id != $user_id || !is_int($user_id))) {
      // User is NOT admin and tries to access an ID that is not their own
      header("HTTP/1.1 401 Unauthorized");
      die("Access denied");
    } else if ($this->user->isAdmin($user_id) && !empty($get_id)) {
      // User is an admin and tries to fetch another users data
      $id = $get_id;
      // Is it a username or a user ID
      ctype_digit($_REQUEST['id']) ? $id = $get_id : $id = $this->user->getUserId($get_id);

The property user does not exist. Did you maybe forget to declare it?

    } else {
      $id = $user_id;
    }
    return $id;
  }
}

$api = new Api();
$api->setConfig($config);
$api->setUser($user);
$api->setSetting($setting);
$api->setStartTime($dStartTime=microtime(true));