RoundStats - Code Metrics - MPOS/php-mpos - Measure and Improve Code Quality continuously with Scrutinizer

RoundStats F
last analyzed 2019-03-06 18:44 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	272
Duplicated Lines	63.97 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	71
lcom	1
cbo	1
dl	174
loc	272
ccs	0
cts	204
cp	0
rs	2.7199
c	0
b	0
f	0

14 Methods

Rating	Name	Duplication	Size	Complexity
A	getNextBlock()	11	11	5
A	getPreviousBlock()	11	11	5
A	searchForBlockHeight()	11	11	5
A	getNextBlockForStats()	12	12	5
A	getDetailsForBlockHeight()	0	14	5
B	getRoundStatsForAccounts()	0	24	6
A	getPPLNSRoundStatsForAccounts()	18	18	5
A	getPPLNSRoundShares()	12	12	5
A	getAllRoundTransactions()	20	20	5
A	getUserRoundTransactions()	18	18	5
A	getAllReportBlocksFoundHeight()	0	11	5
A	getUserReportBlocksFoundHeight()	13	13	5
A	getRoundStatsForUser()	15	15	5
A	getUserRoundTransHeight()	14	14	5

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like RoundStats often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use RoundStats, and based on these observations, apply Extract Interface, too.

<?php
$defflip = (!cfip()) ? exit(header('HTTP/1.1 401 Unauthorized')) : 1;

class RoundStats extends Base {
  /**
   * Get next block for round stats
   **/
  public function getNextBlock($iHeight=0) {

    $stmt = $this->mysqli->prepare("
      SELECT height
      FROM " . $this->block->getTableName() . "
class MyClass { }

$x = new MyClass();
$x->foo = true;
      WHERE height > ?
      ORDER BY height ASC
      LIMIT 1");
    if ($this->checkStmt($stmt) && $stmt->bind_param('i', $iHeight) && $stmt->execute() && $result = $stmt->get_result())
      return $result->fetch_object()->height;
    return $this->sqlError();
  }

  /**
   * Get prev block for round stats
   **/
  public function getPreviousBlock($iHeight=0) {

    $stmt = $this->mysqli->prepare("
      SELECT height
      FROM " . $this->block->getTableName() . "
      WHERE height < ?
      ORDER BY height DESC
      LIMIT 1");
    if ($this->checkStmt($stmt) && $stmt->bind_param('i', $iHeight) && $stmt->execute() && $result = $stmt->get_result())
      return $result->fetch_object()->height;
    return $this->sqlError();
  }

  /**
   * search for block height
   **/
  public function searchForBlockHeight($iHeight=0) {

    $stmt = $this->mysqli->prepare("
       SELECT height 
       FROM " . $this->block->getTableName() . "
       WHERE height >= ?
       ORDER BY height ASC 
       LIMIT 1");
    if ($this->checkStmt($stmt) && $stmt->bind_param('i', $iHeight) && $stmt->execute() && $result = $stmt->get_result())
      return $result->fetch_object()->height;
    return $this->sqlError();
  }

  /**
   * get next block for stats paging
   **/
  public function getNextBlockForStats($iHeight=0, $limit=10) {

    $stmt = $this->mysqli->prepare("
      SELECT MAX(x.height) AS height
      FROM (
        SELECT height FROM " . $this->block->getTableName() . "
        WHERE height >= ?
        ORDER BY height ASC LIMIT ?
      ) AS x");
    if ($this->checkStmt($stmt) && $stmt->bind_param("ii", $iHeight, $limit) && $stmt->execute() && $result = $stmt->get_result())
      return $result->fetch_object()->height;
    return $this->sqlError();
  }

  /**
   * Get details for block height
   * @param height int Block Height
   * @return data array Block information from DB
   **/
  public function getDetailsForBlockHeight($iHeight=0) {
    $stmt = $this->mysqli->prepare("
      SELECT 
      b.id, height, blockhash, amount, confirmations, difficulty, FROM_UNIXTIME(time) as time, shares,
      IF(a.is_anonymous, 'anonymous', a.username) AS finder,
      ROUND(difficulty * POW(2, 32 - " . $this->coin->getTargetBits() . "), 0) AS estshares,
class MyClass { }

$x = new MyClass();
$x->foo = true;
      (time - (SELECT time FROM " . $this->block->getTableName() . " WHERE height < ? ORDER BY height DESC LIMIT 1)) AS round_time
      FROM " . $this->block->getTableName() . " as b
      LEFT JOIN " . $this->user->getTableName() . " AS a ON b.account_id = a.id
class MyClass { }

$x = new MyClass();
$x->foo = true;
      WHERE b.height = ? LIMIT 1");
    if ($this->checkStmt($stmt) && $stmt->bind_param('ii', $iHeight, $iHeight) && $stmt->execute() && $result = $stmt->get_result())
      return $result->fetch_assoc();
    return $this->sqlError();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
  }

  /**
   * Get shares statistics for round block height
   * @param height int Block Height
   * @return data array Block information from DB
   **/
  public function getRoundStatsForAccounts($iHeight=0) {
    $stmt = $this->mysqli->prepare("
      SELECT
        a.id,
        a.username,
        a.is_anonymous,
        s.valid,
        s.invalid
        FROM " . $this->statistics->getTableName() . " AS s
class MyClass { }

$x = new MyClass();
$x->foo = true;
        LEFT JOIN " . $this->block->getTableName() . " AS b ON s.block_id = b.id
        LEFT JOIN " . $this->user->getTableName() . " AS a ON a.id = s.account_id
        WHERE b.height = ? AND s.valid > 0
        GROUP BY username ASC
        ORDER BY valid DESC
        ");
    if ($this->checkStmt($stmt) && $stmt->bind_param('i', $iHeight) && $stmt->execute() && $result = $stmt->get_result()) {
      $aData = null;
      while ($row = $result->fetch_assoc()) {
        $aData[$row['id']] = $row;
      }
      return $aData;
    }
    return $this->sqlError();
  }

  /**
   * Get pplns statistics for round block height
   * @param height int Block Height
   * @return data array Block information from DB
   **/
  public function getPPLNSRoundStatsForAccounts($iHeight=0) {

    $stmt = $this->mysqli->prepare("
      SELECT
        a.username,
        a.is_anonymous,
        s.pplns_valid,
        s.pplns_invalid
        FROM " . $this->statistics->getTableName() . " AS s
        LEFT JOIN " . $this->block->getTableName() . " AS b ON s.block_id = b.id
        LEFT JOIN " . $this->user->getTableName() . " AS a ON a.id = s.account_id
        WHERE b.height = ? AND s.pplns_valid > 0
        GROUP BY username ASC
        ORDER BY pplns_valid DESC
        ");
    if ($this->checkStmt($stmt) && $stmt->bind_param('i', $iHeight) && $stmt->execute() && $result = $stmt->get_result())
      return $result->fetch_all(MYSQLI_ASSOC);
    return $this->sqlError();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
  }

  /**
   * Get total valid pplns shares for block height
   **/
  public function getPPLNSRoundShares($iHeight=0) {

    $stmt = $this->mysqli->prepare("
      SELECT
        SUM(s.pplns_valid) AS pplns_valid
        FROM " . $this->statistics->getTableName() . " AS s
        LEFT JOIN " . $this->block->getTableName() . " AS b ON s.block_id = b.id
        WHERE b.height = ?
        ");
    if ($this->checkStmt($stmt) && $stmt->bind_param('i', $iHeight) && $stmt->execute() && $result = $stmt->get_result())
      return $result->fetch_object()->pplns_valid;
    return $this->sqlError();
  }

  /**
   * Get all transactions for round block height for admin
   * @param height int Block Height
   * @return data array Block round transactions
   **/
  public function getAllRoundTransactions($iHeight=0) {

    $this->debug->append("STA " . __METHOD__, 4);
    $stmt = $this->mysqli->prepare("
      SELECT
      t.id AS id,
      a.id AS uid,
      a.username AS username,
      a.is_anonymous,
      t.type AS type,
      t.amount AS amount
      FROM " . $this->transaction->getTableName() . " AS t
class MyClass { }

$x = new MyClass();
$x->foo = true;
      LEFT JOIN " . $this->block->getTableName() . " AS b ON t.block_id = b.id
      LEFT JOIN " . $this->user->getTableName() . " AS a ON t.account_id = a.id
      WHERE b.height = ? AND t.type = 'Credit'
      ORDER BY amount DESC");
    if ($this->checkStmt($stmt) && $stmt->bind_param('i', $iHeight) && $stmt->execute() && $result = $stmt->get_result())
      return $result->fetch_all(MYSQLI_ASSOC);
    $this->debug->append('Unable to fetch transactions');
    return $this->sqlError();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
  }

  /**
   * Get transactions for round block height user id
   * @param height int Block Height
   * @param id int user id
   * @return data array Block round transactions for user id
   **/
  public function getUserRoundTransactions($iHeight=0, $id=0) {

    $this->debug->append("STA " . __METHOD__, 4);
    $stmt = $this->mysqli->prepare("
      SELECT
      t.id AS id,
      a.username AS username,
      t.type AS type,
      t.amount AS amount
      FROM " . $this->transaction->getTableName() . " AS t
      LEFT JOIN " . $this->block->getTableName() . " AS b ON t.block_id = b.id
      LEFT JOIN " . $this->user->getTableName() . " AS a ON t.account_id = a.id
      WHERE b.height = ? AND a.id = ?
      ORDER BY id ASC");
    if ($this->checkStmt($stmt) && $stmt->bind_param('ii', $iHeight, $id) && $stmt->execute() && $result = $stmt->get_result())
      return $result->fetch_all(MYSQLI_ASSOC);
    $this->debug->append('Unable to fetch transactions');
    return $this->sqlError();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
  }

  /**
   * Get ALL last blocks from height for admin panel
   **/
  public function getAllReportBlocksFoundHeight($iHeight=0, $limit=10) {
    $stmt = $this->mysqli->prepare("
      SELECT
        height, shares
      FROM " . $this->block->getTableName() . "
      WHERE height <= ?
      ORDER BY height DESC LIMIT ?");
    if ($this->checkStmt($stmt) && $stmt->bind_param("ii", $iHeight, $limit) && $stmt->execute() && $result = $stmt->get_result())
      return $result->fetch_all(MYSQLI_ASSOC);
    return $this->sqlError();
  }

  /**
   * Get USER last blocks from height for admin panel
   **/
  public function getUserReportBlocksFoundHeight($iHeight=0, $limit=10, $iUser) {

    $stmt = $this->mysqli->prepare("
      SELECT
        b.height, b.shares
        FROM " . $this->block->getTableName() . " AS b
        LEFT JOIN " . $this->statistics->getTableName() . " AS s ON s.block_id = b.id
        LEFT JOIN " . $this->user->getTableName() . " AS a ON a.id = s.account_id 
      WHERE b.height <= ? AND a.id = ?
      ORDER BY height DESC LIMIT ?");
    if ($this->checkStmt($stmt) && $stmt->bind_param('iii', $iHeight, $iUser, $limit) && $stmt->execute() && $result = $stmt->get_result())
      return $result->fetch_all(MYSQLI_ASSOC);
    return $this->sqlError();
  }

  /**
   * Get shares for block height for user admin panel
   **/
  public function getRoundStatsForUser($iHeight=0, $iUser) {

    $stmt = $this->mysqli->prepare("
      SELECT
        s.valid,
        s.invalid,
        s.pplns_valid,
        s.pplns_invalid
        FROM " . $this->statistics->getTableName() . " AS s
        LEFT JOIN " . $this->block->getTableName() . " AS b ON s.block_id = b.id
        LEFT JOIN " . $this->user->getTableName() . " AS a ON a.id = s.account_id
        WHERE b.height = ? AND a.id = ?");
    if ($this->checkStmt($stmt) && $stmt->bind_param('ii', $iHeight, $iUser) && $stmt->execute() && $result = $stmt->get_result())
      return $result->fetch_assoc();
    return $this->sqlError();
  }

  /**
   * Get credit transactions for round block height for admin panel
   **/
  public function getUserRoundTransHeight($iHeight=0, $iUser) {

    $this->debug->append("STA " . __METHOD__, 4);
    $stmt = $this->mysqli->prepare("
      SELECT
      IFNULL(t.amount, 0) AS amount
      FROM " . $this->transaction->getTableName() . " AS t
      LEFT JOIN " . $this->block->getTableName() . " AS b ON t.block_id = b.id
      LEFT JOIN " . $this->user->getTableName() . " AS a ON t.account_id = a.id
      WHERE b.height = ? AND t.type = 'Credit' AND t.account_id = ?");
    if ($this->checkStmt($stmt) && $stmt->bind_param('ii', $iHeight, $iUser) && $stmt->execute() && $result = $stmt->get_result())
      return $result->fetch_object()->amount;
    $this->debug->append('Unable to fetch transactions');
    return $this->sqlError();
  }
}

$roundstats = new RoundStats();
$roundstats->setDebug($debug);
$roundstats->setMysql($mysqli);
$roundstats->setConfig($config);
$roundstats->setErrorCodes($aErrorCodes);
$roundstats->setUser($user);
$roundstats->setStatistics($statistics);
$roundstats->setBlock($block);
$roundstats->setTransaction($transaction);
$roundstats->setCoin($coin);


MPOS / php-mpos

RoundStats F last analyzed 2019-03-06 18:44 UTC